[PATCH V2 11/15] csky/perf: Remove driver-specific throttle support

kan.liang@linux.intel.com posted 15 patches 8 months, 4 weeks ago
There is a newer version of this series
[PATCH V2 11/15] csky/perf: Remove driver-specific throttle support
Posted by kan.liang@linux.intel.com 8 months, 4 weeks ago
From: Kan Liang <kan.liang@linux.intel.com>

The throttle support has been added in the generic code. Remove
the driver-specific throttle support.

Besides the throttle, perf_event_overflow may return true because of
event_limit. It already does an inatomic event disable. The pmu->stop
is not required either.

Signed-off-by: Kan Liang <kan.liang@linux.intel.com>
Cc: Mao Han <han_mao@c-sky.com>
Cc: Guo Ren <ren_guo@c-sky.com>
Cc: linux-csky@vger.kernel.org
---
 arch/csky/kernel/perf_event.c | 3 +--
 1 file changed, 1 insertion(+), 2 deletions(-)

diff --git a/arch/csky/kernel/perf_event.c b/arch/csky/kernel/perf_event.c
index e5f18420ce64..e0a36acd265b 100644
--- a/arch/csky/kernel/perf_event.c
+++ b/arch/csky/kernel/perf_event.c
@@ -1139,8 +1139,7 @@ static irqreturn_t csky_pmu_handle_irq(int irq_num, void *dev)
 		perf_sample_data_init(&data, 0, hwc->last_period);
 		csky_pmu_event_set_period(event);
 
-		if (perf_event_overflow(event, &data, regs))
-			csky_pmu_stop_event(event);
+		perf_event_overflow(event, &data, regs);
 	}
 
 	csky_pmu_enable(&csky_pmu.pmu);
-- 
2.38.1
Re: [PATCH V2 11/15] csky/perf: Remove driver-specific throttle support
Posted by Guo Ren 8 months, 4 weeks ago
On Wed, May 14, 2025 at 6:49 PM <kan.liang@linux.intel.com> wrote:
>
> From: Kan Liang <kan.liang@linux.intel.com>
>
> The throttle support has been added in the generic code. Remove
> the driver-specific throttle support.
Acked-by: Guo Ren <guoren@kernel.org>

>
> Besides the throttle, perf_event_overflow may return true because of
> event_limit. It already does an inatomic event disable. The pmu->stop
> is not required either.
>
> Signed-off-by: Kan Liang <kan.liang@linux.intel.com>
> Cc: Mao Han <han_mao@c-sky.com>
> Cc: Guo Ren <ren_guo@c-sky.com>
> Cc: linux-csky@vger.kernel.org
> ---
>  arch/csky/kernel/perf_event.c | 3 +--
>  1 file changed, 1 insertion(+), 2 deletions(-)
>
> diff --git a/arch/csky/kernel/perf_event.c b/arch/csky/kernel/perf_event.c
> index e5f18420ce64..e0a36acd265b 100644
> --- a/arch/csky/kernel/perf_event.c
> +++ b/arch/csky/kernel/perf_event.c
> @@ -1139,8 +1139,7 @@ static irqreturn_t csky_pmu_handle_irq(int irq_num, void *dev)
>                 perf_sample_data_init(&data, 0, hwc->last_period);
>                 csky_pmu_event_set_period(event);
>
> -               if (perf_event_overflow(event, &data, regs))
> -                       csky_pmu_stop_event(event);
> +               perf_event_overflow(event, &data, regs);
>         }
>
>         csky_pmu_enable(&csky_pmu.pmu);
> --
> 2.38.1
>
>


-- 
Best Regards
 Guo Ren