[PATCH v2 2/3] dt-bindings: arm: rockchip: Add Sakura Pi RK3308B

Hsun Lai posted 3 patches 9 months ago
There is a newer version of this series
[PATCH v2 2/3] dt-bindings: arm: rockchip: Add Sakura Pi RK3308B
Posted by Hsun Lai 9 months ago
This patch adds device tree binding support for
Sakura Pi RK3308B, with compatibility for the
Rockchip RK3308 SoC.

Link: https://docs.sakurapi.org/article/sakurapi-rk3308b/introduce

Signed-off-by: Hsun Lai <i@chainsx.cn>
---

(no changes since v1)

 Documentation/devicetree/bindings/arm/rockchip.yaml | 5 +++++
 1 file changed, 5 insertions(+)

diff --git a/Documentation/devicetree/bindings/arm/rockchip.yaml b/Documentation/devicetree/bindings/arm/rockchip.yaml
index 115c3ca43..c64adc0d0 100644
--- a/Documentation/devicetree/bindings/arm/rockchip.yaml
+++ b/Documentation/devicetree/bindings/arm/rockchip.yaml
@@ -1109,6 +1109,11 @@ properties:
           - const: rockchip,rk3588-toybrick-x0
           - const: rockchip,rk3588
 
+      - description: Sakura Pi RK3308B
+        items:
+          - const: sakurapi,rk3308-sakurapi-rk3308b
+          - const: rockchip,rk3308
+
       - description: Sinovoip RK3308 Banana Pi P2 Pro
         items:
           - const: sinovoip,rk3308-bpi-p2pro
-- 
2.34.1
Re: [PATCH v2 2/3] dt-bindings: arm: rockchip: Add Sakura Pi RK3308B
Posted by Krzysztof Kozlowski 8 months, 4 weeks ago
On 14/05/2025 09:59, Hsun Lai wrote:
> This patch adds device tree binding support for
> Sakura Pi RK3308B, with compatibility for the
> Rockchip RK3308 SoC.
> 
> Link: https://docs.sakurapi.org/article/sakurapi-rk3308b/introduce
> 
> Signed-off-by: Hsun Lai <i@chainsx.cn>
> ---
> 
> (no changes since v1)
Really? And the tag?

<form letter>
This is a friendly reminder during the review process.

It looks like you received a tag and forgot to add it.

If you do not know the process, here is a short explanation:
Please add Acked-by/Reviewed-by/Tested-by tags when posting new versions
of patchset, under or above your Signed-off-by tag, unless patch changed
significantly (e.g. new properties added to the DT bindings). Tag is
"received", when provided in a message replied to you on the mailing
list. Tools like b4 can help here. However, there's no need to repost
patches *only* to add the tags. The upstream maintainer will do that for
tags received on the version they apply.

Please read:
https://elixir.bootlin.com/linux/v6.12-rc3/source/Documentation/process/submitting-patches.rst#L577

If a tag was not added on purpose, please state why and what changed.
</form letter>

Best regards,
Krzysztof