block: Remove obsolete configs BLK_MQ_{PCI,VIRTIO}

[PATCH] block: Remove obsolete configs BLK_MQ_{PCI,VIRTIO}

Posted by Lukas Bulwahn 8 months, 4 weeks ago

From: Lukas Bulwahn <lukas.bulwahn@redhat.com>

Commit 9bc1e897a821 ("blk-mq: remove unused queue mapping helpers") makes
the two config options, BLK_MQ_PCI and BLK_MQ_VIRTIO, have no remaining
effect.

Remove the two obsolete config options.

Signed-off-by: Lukas Bulwahn <lukas.bulwahn@redhat.com>
---
 block/Kconfig | 8 --------
 1 file changed, 8 deletions(-)

diff --git a/block/Kconfig b/block/Kconfig
index df8973bc0539..15027963472d 100644
--- a/block/Kconfig
+++ b/block/Kconfig
@@ -211,14 +211,6 @@ config BLK_INLINE_ENCRYPTION_FALLBACK
 
 source "block/partitions/Kconfig"
 
-config BLK_MQ_PCI
-	def_bool PCI
-
-config BLK_MQ_VIRTIO
-	bool
-	depends on VIRTIO
-	default y
-
 config BLK_PM
 	def_bool PM
 
-- 
2.49.0

Re: [PATCH] block: Remove obsolete configs BLK_MQ_{PCI,VIRTIO}

Posted by Jens Axboe 8 months, 4 weeks ago

On Wed, 14 May 2025 08:55:13 +0200, Lukas Bulwahn wrote:
> Commit 9bc1e897a821 ("blk-mq: remove unused queue mapping helpers") makes
> the two config options, BLK_MQ_PCI and BLK_MQ_VIRTIO, have no remaining
> effect.
> 
> Remove the two obsolete config options.
> 
> 
> [...]

Applied, thanks!

[1/1] block: Remove obsolete configs BLK_MQ_{PCI,VIRTIO}
      commit: 1e332795d00655305cf0ae40be4e2eaa9a399d79

Best regards,
-- 
Jens Axboe

Re: [PATCH] block: Remove obsolete configs BLK_MQ_{PCI,VIRTIO}

Posted by Daniel Wagner 8 months, 4 weeks ago

On Wed, May 14, 2025 at 08:55:13AM +0200, Lukas Bulwahn wrote:
> From: Lukas Bulwahn <lukas.bulwahn@redhat.com>
> 
> Commit 9bc1e897a821 ("blk-mq: remove unused queue mapping helpers") makes
> the two config options, BLK_MQ_PCI and BLK_MQ_VIRTIO, have no remaining
> effect.
> 
> Remove the two obsolete config options.

A quick grep revealed that there is at least a test config still in the
tree which uses BLK_MQ_VIRTIO:

drivers/gpu/drm/ci/x86_64.config
108:CONFIG_BLK_MQ_VIRTIO=y

Not sure how this is supposed to be handled.

> Signed-off-by: Lukas Bulwahn <lukas.bulwahn@redhat.com>

Reviewed-by: Daniel Wagner <dwagner@suse.de>

Re: [PATCH] block: Remove obsolete configs BLK_MQ_{PCI,VIRTIO}

Posted by Lukas Bulwahn 8 months, 4 weeks ago

On Wed, May 14, 2025 at 9:10 AM Daniel Wagner <dwagner@suse.de> wrote:
>
> On Wed, May 14, 2025 at 08:55:13AM +0200, Lukas Bulwahn wrote:
> > From: Lukas Bulwahn <lukas.bulwahn@redhat.com>
> >
> > Commit 9bc1e897a821 ("blk-mq: remove unused queue mapping helpers") makes
> > the two config options, BLK_MQ_PCI and BLK_MQ_VIRTIO, have no remaining
> > effect.
> >
> > Remove the two obsolete config options.
>
> A quick grep revealed that there is at least a test config still in the
> tree which uses BLK_MQ_VIRTIO:
>
> drivers/gpu/drm/ci/x86_64.config
> 108:CONFIG_BLK_MQ_VIRTIO=y
>
> Not sure how this is supposed to be handled.
>

I noticed that as well, but that is really yet another clean up.

Generally, these config files in the kernel tree are ill designed and
terribly maintained.

They are ill designed, because when they are created, they are dropped
as complete kernel configurations, whereas they intend to set a
specific fragment of options, and have the rest as default. That
creates needless large files, distracts from what is important in
those files, and creates some record of the default of various options
at this random point of time where the config was created, which now
makes the clean-up pretty complicated.

They are terribly maintained, i.e., the command
./scripts/checkkconfigsymbols.py | grep "configs" -B 1, will show all
the references to config options in those config files, for config
options that do not exist anymore in the current tree. In the current
linux-next tree, there are over 200 references to non-existing config
options from such config files. At this point, I do not worry about
adding one more such reference in one of those files.

This whole proper clean-up of those files is a larger project, though;
maybe for some later day.

Lukas

> > Signed-off-by: Lukas Bulwahn <lukas.bulwahn@redhat.com>
>
> Reviewed-by: Daniel Wagner <dwagner@suse.de>
>

Re: [PATCH] block: Remove obsolete configs BLK_MQ_{PCI,VIRTIO}

Posted by John Garry 8 months, 4 weeks ago

On 14/05/2025 08:04, Daniel Wagner wrote:
> On Wed, May 14, 2025 at 08:55:13AM +0200, Lukas Bulwahn wrote:
>> From: Lukas Bulwahn<lukas.bulwahn@redhat.com>
>>
>> Commit 9bc1e897a821 ("blk-mq: remove unused queue mapping helpers") makes
>> the two config options, BLK_MQ_PCI and BLK_MQ_VIRTIO, have no remaining
>> effect.
>>
>> Remove the two obsolete config options.
> A quick grep revealed that there is at least a test config still in the
> tree which uses BLK_MQ_VIRTIO:
> 
> drivers/gpu/drm/ci/x86_64.config
> 108:CONFIG_BLK_MQ_VIRTIO=y
> 
> Not sure how this is supposed to be handled.

I got a feeling that this stuff (like kernel config files) should not be 
there ...

Reviewed-by: John Garry <john.g.garry@oracle.com>

Re: [PATCH] block: Remove obsolete configs BLK_MQ_{PCI,VIRTIO}

Posted by Christoph Hellwig 8 months, 4 weeks ago

Looks good:

Reviewed-by: Christoph Hellwig <hch@lst.de>