[v2] mtd: rawnand: brcmnand: remove unused parameters

[PATCH v2] mtd: rawnand: brcmnand: remove unused parameters

Posted by Álvaro Fernández Rojas 8 months, 4 weeks ago

last_cmd and last_byte are now unused brcmnand_host members.
last_addr is only written and never read so we can remove it too.

Signed-off-by: Álvaro Fernández Rojas <noltari@gmail.com>
Reviewed-by: Florian Fainelli <florian.fainelli@broadcom.com>
---
 drivers/mtd/nand/raw/brcmnand/brcmnand.c | 24 ++++++------------------
 1 file changed, 6 insertions(+), 18 deletions(-)

 v2: fix unused host variable warnings.

diff --git a/drivers/mtd/nand/raw/brcmnand/brcmnand.c b/drivers/mtd/nand/raw/brcmnand/brcmnand.c
index 17f6d9723df9..299dd2bca5b4 100644
--- a/drivers/mtd/nand/raw/brcmnand/brcmnand.c
+++ b/drivers/mtd/nand/raw/brcmnand/brcmnand.c
@@ -310,9 +310,6 @@ struct brcmnand_host {
 	struct platform_device	*pdev;
 	int			cs;
 
-	unsigned int		last_cmd;
-	unsigned int		last_byte;
-	u64			last_addr;
 	struct brcmnand_cfg	hwcfg;
 	struct brcmnand_controller *ctrl;
 };
@@ -2233,14 +2230,11 @@ static int brcmnand_read_page(struct nand_chip *chip, uint8_t *buf,
 			      int oob_required, int page)
 {
 	struct mtd_info *mtd = nand_to_mtd(chip);
-	struct brcmnand_host *host = nand_get_controller_data(chip);
 	u8 *oob = oob_required ? (u8 *)chip->oob_poi : NULL;
 	u64 addr = (u64)page << chip->page_shift;
 
-	host->last_addr = addr;
-
-	return brcmnand_read(mtd, chip, host->last_addr,
-			mtd->writesize >> FC_SHIFT, (u32 *)buf, oob);
+	return brcmnand_read(mtd, chip, addr, mtd->writesize >> FC_SHIFT,
+			     (u32 *)buf, oob);
 }
 
 static int brcmnand_read_page_raw(struct nand_chip *chip, uint8_t *buf,
@@ -2252,11 +2246,9 @@ static int brcmnand_read_page_raw(struct nand_chip *chip, uint8_t *buf,
 	int ret;
 	u64 addr = (u64)page << chip->page_shift;
 
-	host->last_addr = addr;
-
 	brcmnand_set_ecc_enabled(host, 0);
-	ret = brcmnand_read(mtd, chip, host->last_addr,
-			mtd->writesize >> FC_SHIFT, (u32 *)buf, oob);
+	ret = brcmnand_read(mtd, chip, addr, mtd->writesize >> FC_SHIFT,
+			    (u32 *)buf, oob);
 	brcmnand_set_ecc_enabled(host, 1);
 	return ret;
 }
@@ -2363,13 +2355,10 @@ static int brcmnand_write_page(struct nand_chip *chip, const uint8_t *buf,
 			       int oob_required, int page)
 {
 	struct mtd_info *mtd = nand_to_mtd(chip);
-	struct brcmnand_host *host = nand_get_controller_data(chip);
 	void *oob = oob_required ? chip->oob_poi : NULL;
 	u64 addr = (u64)page << chip->page_shift;
 
-	host->last_addr = addr;
-
-	return brcmnand_write(mtd, chip, host->last_addr, (const u32 *)buf, oob);
+	return brcmnand_write(mtd, chip, addr, (const u32 *)buf, oob);
 }
 
 static int brcmnand_write_page_raw(struct nand_chip *chip, const uint8_t *buf,
@@ -2381,9 +2370,8 @@ static int brcmnand_write_page_raw(struct nand_chip *chip, const uint8_t *buf,
 	u64 addr = (u64)page << chip->page_shift;
 	int ret = 0;
 
-	host->last_addr = addr;
 	brcmnand_set_ecc_enabled(host, 0);
-	ret = brcmnand_write(mtd, chip, host->last_addr, (const u32 *)buf, oob);
+	ret = brcmnand_write(mtd, chip, addr, (const u32 *)buf, oob);
 	brcmnand_set_ecc_enabled(host, 1);
 
 	return ret;
-- 
2.39.5

Re: [PATCH v2] mtd: rawnand: brcmnand: remove unused parameters

Posted by Miquel Raynal 8 months, 3 weeks ago

On Wed, 14 May 2025 08:14:54 +0200, Álvaro Fernández Rojas wrote:
> last_cmd and last_byte are now unused brcmnand_host members.
> last_addr is only written and never read so we can remove it too.
> 
> 

Applied to nand/next, thanks!

[1/1] mtd: rawnand: brcmnand: remove unused parameters
      commit: 56fce75470041b5b0d92ae10637416e1a4cceb1b

Patche(s) should be available on mtd/linux.git and will be
part of the next PR (provided that no robot complains by then).

Kind regards,
Miquèl

RE: [PATCH v2] mtd: rawnand: brcmnand: remove unused parameters

Posted by William Zhang 8 months, 4 weeks ago

Hi Alvaro,

> -----Original Message-----
> From: bcm-kernel-feedback-list.pdl@broadcom.com <bcm-kernel-feedback-
> list.pdl@broadcom.com> On Behalf Of Álvaro Fernández Rojas
> Sent: Tuesday, May 13, 2025 11:15 PM
> To: dregan@broadcom.com; florian.fainelli@broadcom.com;
> computersforpeace@gmail.com; kamal.dasu@broadcom.com; bcm-kernel-
> feedback-list@broadcom.com; miquel.raynal@bootlin.com; richard@nod.at;
> vigneshr@ti.com; jonas.gorski@gmail.com; dgcbueu@gmail.com; linux-
> mtd@lists.infradead.org; linux-kernel@vger.kernel.org
> Cc: Álvaro Fernández Rojas <noltari@gmail.com>
> Subject: [PATCH v2] mtd: rawnand: brcmnand: remove unused parameters
>
> last_cmd and last_byte are now unused brcmnand_host members.
> last_addr is only written and never read so we can remove it too.
>
> Signed-off-by: Álvaro Fernández Rojas <noltari@gmail.com>
> Reviewed-by: Florian Fainelli <florian.fainelli@broadcom.com>
> ---
>  drivers/mtd/nand/raw/brcmnand/brcmnand.c | 24 ++++++------------------
>  1 file changed, 6 insertions(+), 18 deletions(-)
>
>  v2: fix unused host variable warnings.
>
> diff --git a/drivers/mtd/nand/raw/brcmnand/brcmnand.c
> b/drivers/mtd/nand/raw/brcmnand/brcmnand.c
> index 17f6d9723df9..299dd2bca5b4 100644
> --- a/drivers/mtd/nand/raw/brcmnand/brcmnand.c
> +++ b/drivers/mtd/nand/raw/brcmnand/brcmnand.c
> @@ -310,9 +310,6 @@ struct brcmnand_host {
>  	struct platform_device	*pdev;
>  	int			cs;
>
> -	unsigned int		last_cmd;
> -	unsigned int		last_byte;
> -	u64			last_addr;
>  	struct brcmnand_cfg	hwcfg;
>  	struct brcmnand_controller *ctrl;
>  };
> @@ -2233,14 +2230,11 @@ static int brcmnand_read_page(struct nand_chip
> *chip, uint8_t *buf,
>  			      int oob_required, int page)
>  {
>  	struct mtd_info *mtd = nand_to_mtd(chip);
> -	struct brcmnand_host *host = nand_get_controller_data(chip);
>  	u8 *oob = oob_required ? (u8 *)chip->oob_poi : NULL;
>  	u64 addr = (u64)page << chip->page_shift;
>
> -	host->last_addr = addr;
> -
> -	return brcmnand_read(mtd, chip, host->last_addr,
> -			mtd->writesize >> FC_SHIFT, (u32 *)buf, oob);
> +	return brcmnand_read(mtd, chip, addr, mtd->writesize >> FC_SHIFT,
> +			     (u32 *)buf, oob);
>  }
>
>  static int brcmnand_read_page_raw(struct nand_chip *chip, uint8_t *buf,
> @@ -2252,11 +2246,9 @@ static int brcmnand_read_page_raw(struct
> nand_chip *chip, uint8_t *buf,
>  	int ret;
>  	u64 addr = (u64)page << chip->page_shift;
>
> -	host->last_addr = addr;
> -
>  	brcmnand_set_ecc_enabled(host, 0);
> -	ret = brcmnand_read(mtd, chip, host->last_addr,
> -			mtd->writesize >> FC_SHIFT, (u32 *)buf, oob);
> +	ret = brcmnand_read(mtd, chip, addr, mtd->writesize >> FC_SHIFT,
> +			    (u32 *)buf, oob);
>  	brcmnand_set_ecc_enabled(host, 1);
>  	return ret;
>  }
> @@ -2363,13 +2355,10 @@ static int brcmnand_write_page(struct nand_chip
> *chip, const uint8_t *buf,
>  			       int oob_required, int page)
>  {
>  	struct mtd_info *mtd = nand_to_mtd(chip);
> -	struct brcmnand_host *host = nand_get_controller_data(chip);
>  	void *oob = oob_required ? chip->oob_poi : NULL;
>  	u64 addr = (u64)page << chip->page_shift;
>
> -	host->last_addr = addr;
> -
> -	return brcmnand_write(mtd, chip, host->last_addr, (const u32 *)buf,
> oob);
> +	return brcmnand_write(mtd, chip, addr, (const u32 *)buf, oob);
>  }
>
>  static int brcmnand_write_page_raw(struct nand_chip *chip, const uint8_t
> *buf,
> @@ -2381,9 +2370,8 @@ static int brcmnand_write_page_raw(struct
> nand_chip *chip, const uint8_t *buf,
>  	u64 addr = (u64)page << chip->page_shift;
>  	int ret = 0;
>
> -	host->last_addr = addr;
>  	brcmnand_set_ecc_enabled(host, 0);
> -	ret = brcmnand_write(mtd, chip, host->last_addr, (const u32 *)buf, oob);
> +	ret = brcmnand_write(mtd, chip, addr, (const u32 *)buf, oob);
>  	brcmnand_set_ecc_enabled(host, 1);
>
>  	return ret;
> --
> 2.39.5

Reviewed-by: William Zhang <william.zhang@broadcom.com>