[PATCH] selftests: remove duplicated function definition

Chen Linxuan posted 1 patch 8 months, 4 weeks ago
tools/testing/selftests/mount_setattr/mount_setattr_test.c | 5 -----
1 file changed, 5 deletions(-)
[PATCH] selftests: remove duplicated function definition
Posted by Chen Linxuan 8 months, 4 weeks ago
I failed to build this test on Ubuntu 24.04. Compiler complains that
function sys_open_tree has already been defined in
"../filesystems/overlayfs/wrappers.h".

Signed-off-by: Chen Linxuan <chenlinxuan@uniontech.com>
---
 tools/testing/selftests/mount_setattr/mount_setattr_test.c | 5 -----
 1 file changed, 5 deletions(-)

diff --git a/tools/testing/selftests/mount_setattr/mount_setattr_test.c b/tools/testing/selftests/mount_setattr/mount_setattr_test.c
index 48a000cabc971..eaa4e912120ab 100644
--- a/tools/testing/selftests/mount_setattr/mount_setattr_test.c
+++ b/tools/testing/selftests/mount_setattr/mount_setattr_test.c
@@ -173,11 +173,6 @@ static inline int sys_mount_setattr(int dfd, const char *path, unsigned int flag
 #define AT_RECURSIVE 0x8000 /* Apply to the entire subtree */
 #endif
 
-static inline int sys_open_tree(int dfd, const char *filename, unsigned int flags)
-{
-	return syscall(__NR_open_tree, dfd, filename, flags);
-}
-
 static ssize_t write_nointr(int fd, const void *buf, size_t count)
 {
 	ssize_t ret;
-- 
2.43.0
Re: [PATCH] selftests: remove duplicated function definition
Posted by Christian Brauner 8 months, 4 weeks ago
On Wed, May 14, 2025 at 10:02:02AM +0800, Chen Linxuan wrote:
> I failed to build this test on Ubuntu 24.04. Compiler complains that
> function sys_open_tree has already been defined in
> "../filesystems/overlayfs/wrappers.h".
> 
> Signed-off-by: Chen Linxuan <chenlinxuan@uniontech.com>
> ---

This is already fixed in the next vfs tree. Thanks though!