From: Arnd Bergmann <arnd@arndb.de>

I ran into a build time warning and spent some time trying to
gently rewrite the new driver to avoid the warning and make it
behave more like other drivers.

I'm still a bit confused about what the driver actually does
and why a buffer has to be mapped into a two devices, but I hope
that either my patches clear this up enough, or if they are wrong
are helpful to have someone else sort it out properly.

The patches are currently queued for v6.16 in Greg's usb-next
tree, so my fixes look correct, I hope he can apply them there
before the merge window.

Arnd Bergmann (3):
  ALSA: qc_audio_offload: rename dma/iova/va/cpu/phys variables
  ALSA: qc_audio_offload: avoid leaking xfer_buf allocation
  ALSA: qc_audio_offload: try to reduce address space confusion

 sound/usb/qcom/qc_audio_offload.c  | 158 ++++++++++++++++-------------
 sound/usb/qcom/usb_audio_qmi_v01.c |   4 +-
 sound/usb/qcom/usb_audio_qmi_v01.h |   4 +-
 3 files changed, 89 insertions(+), 77 deletions(-)


Cc: Jaroslav Kysela <perex@perex.cz>
Cc: Takashi Iwai <tiwai@suse.com>
Cc: Arnd Bergmann <arnd@arndb.de>
Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Cc: Mark Brown <broonie@kernel.org>
Cc: Wesley Cheng <quic_wcheng@quicinc.com>
Cc: Dan Carpenter <dan.carpenter@linaro.org>
Cc: linux-sound@vger.kernel.org
Cc: linux-kernel@vger.kernel.org


-- 
2.39.5

On Tue, 13 May 2025 14:34:39 +0200,
Arnd Bergmann wrote:
> 
> From: Arnd Bergmann <arnd@arndb.de>
> 
> I ran into a build time warning and spent some time trying to
> gently rewrite the new driver to avoid the warning and make it
> behave more like other drivers.
> 
> I'm still a bit confused about what the driver actually does
> and why a buffer has to be mapped into a two devices, but I hope
> that either my patches clear this up enough, or if they are wrong
> are helpful to have someone else sort it out properly.
> 
> The patches are currently queued for v6.16 in Greg's usb-next
> tree, so my fixes look correct, I hope he can apply them there
> before the merge window.
> 
> Arnd Bergmann (3):
>   ALSA: qc_audio_offload: rename dma/iova/va/cpu/phys variables
>   ALSA: qc_audio_offload: avoid leaking xfer_buf allocation
>   ALSA: qc_audio_offload: try to reduce address space confusion

JFYI, the qcom offload stuff is currently only on Greg's USB tree, not
on Mark's or my sound git tree.


Takashi

> 
>  sound/usb/qcom/qc_audio_offload.c  | 158 ++++++++++++++++-------------
>  sound/usb/qcom/usb_audio_qmi_v01.c |   4 +-
>  sound/usb/qcom/usb_audio_qmi_v01.h |   4 +-
>  3 files changed, 89 insertions(+), 77 deletions(-)
> 
> 
> Cc: Jaroslav Kysela <perex@perex.cz>
> Cc: Takashi Iwai <tiwai@suse.com>
> Cc: Arnd Bergmann <arnd@arndb.de>
> Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
> Cc: Mark Brown <broonie@kernel.org>
> Cc: Wesley Cheng <quic_wcheng@quicinc.com>
> Cc: Dan Carpenter <dan.carpenter@linaro.org>
> Cc: linux-sound@vger.kernel.org
> Cc: linux-kernel@vger.kernel.org
> 
> 
> -- 
> 2.39.5
> 
>

On Wed, May 14, 2025 at 11:01:02AM +0200, Takashi Iwai wrote:
> On Tue, 13 May 2025 14:34:39 +0200,
> Arnd Bergmann wrote:
> > 
> > From: Arnd Bergmann <arnd@arndb.de>
> > 
> > I ran into a build time warning and spent some time trying to
> > gently rewrite the new driver to avoid the warning and make it
> > behave more like other drivers.
> > 
> > I'm still a bit confused about what the driver actually does
> > and why a buffer has to be mapped into a two devices, but I hope
> > that either my patches clear this up enough, or if they are wrong
> > are helpful to have someone else sort it out properly.
> > 
> > The patches are currently queued for v6.16 in Greg's usb-next
> > tree, so my fixes look correct, I hope he can apply them there
> > before the merge window.
> > 
> > Arnd Bergmann (3):
> >   ALSA: qc_audio_offload: rename dma/iova/va/cpu/phys variables
> >   ALSA: qc_audio_offload: avoid leaking xfer_buf allocation
> >   ALSA: qc_audio_offload: try to reduce address space confusion
> 
> JFYI, the qcom offload stuff is currently only on Greg's USB tree, not
> on Mark's or my sound git tree.

Ok, I'll take this through the usb tree now, thanks.

greg k-h