1. Patchew
  2. linux
  3. [PATCH 0/2] UFFDIO_API.2const: Two man page updates
  4. View patch

[PATCH 2/2] UFFDIO_API.2const: Add an entry for UFFDIO_MOVE

Peter Xu posted 2 patches 9 months ago
There is a newer version of this series
[PATCH 2/2] UFFDIO_API.2const: Add an entry for UFFDIO_MOVE
Posted by Peter Xu 9 months ago 
Add the entry for UFFDIO_MOVE in UFFDIO_API.

Signed-off-by: Peter Xu <peterx@redhat.com>
---
 man/man2const/UFFDIO_API.2const | 6 ++++++
 1 file changed, 6 insertions(+)

diff --git a/man/man2const/UFFDIO_API.2const b/man/man2const/UFFDIO_API.2const
index 1c554107a..17ea6f905 100644
--- a/man/man2const/UFFDIO_API.2const
+++ b/man/man2const/UFFDIO_API.2const
@@ -204,6 +204,12 @@ ioctl.
 If this feature bit is set,
 the write protection faults would be asynchronously resolved
 by the kernel.
+.TP
+.BR UFFD_FEATURE_MOVE " (since Linux 6.8)"
+If this feature bit is set,
+the kernel supports resolving faults with the
+.B UFFDIO_MOVE
+ioctl.
 .P
 The returned
 .I argp->ioctls
-- 
2.49.0
Re: [PATCH 2/2] UFFDIO_API.2const: Add an entry for UFFDIO_MOVE
Posted by Alejandro Colomar 9 months ago 
Hi Peter,

On Mon, May 12, 2025 at 01:19:22PM -0400, Peter Xu wrote:
> Add the entry for UFFDIO_MOVE in UFFDIO_API.
> 
> Signed-off-by: Peter Xu <peterx@redhat.com>

Should we add the following tag?

Fixes: d7dec35a3b19 (2025-05-01; "man/man2/ioctl_userfaultfd.2, man/man2const/UFFDIO_MOVE.2const: Document UFFDIO_MOVE")

Also, I think the subject should mention UFFD_FEATURE_MOVE, or at least
somewhere in the commit message.


Have a lovely day!
Alex

> ---
>  man/man2const/UFFDIO_API.2const | 6 ++++++
>  1 file changed, 6 insertions(+)
> 
> diff --git a/man/man2const/UFFDIO_API.2const b/man/man2const/UFFDIO_API.2const
> index 1c554107a..17ea6f905 100644
> --- a/man/man2const/UFFDIO_API.2const
> +++ b/man/man2const/UFFDIO_API.2const
> @@ -204,6 +204,12 @@ ioctl.
>  If this feature bit is set,
>  the write protection faults would be asynchronously resolved
>  by the kernel.
> +.TP
> +.BR UFFD_FEATURE_MOVE " (since Linux 6.8)"
> +If this feature bit is set,
> +the kernel supports resolving faults with the
> +.B UFFDIO_MOVE
> +ioctl.
>  .P
>  The returned
>  .I argp->ioctls
> -- 
> 2.49.0
> 
> 

-- 
<https://www.alejandro-colomar.es/>
Re: [PATCH 2/2] UFFDIO_API.2const: Add an entry for UFFDIO_MOVE
Posted by Peter Xu 9 months ago 
On Wed, May 14, 2025 at 05:02:57PM +0200, Alejandro Colomar wrote:
> Hi Peter,
> 
> On Mon, May 12, 2025 at 01:19:22PM -0400, Peter Xu wrote:
> > Add the entry for UFFDIO_MOVE in UFFDIO_API.
> > 
> > Signed-off-by: Peter Xu <peterx@redhat.com>
> 
> Should we add the following tag?
> 
> Fixes: d7dec35a3b19 (2025-05-01; "man/man2/ioctl_userfaultfd.2, man/man2const/UFFDIO_MOVE.2const: Document UFFDIO_MOVE")

Sure.

> 
> Also, I think the subject should mention UFFD_FEATURE_MOVE, or at least
> somewhere in the commit message.

I'll rename the subject to:

  UFFDIO_API.2const: Add an entry for UFFDIO_FEATURE_MOVE

I didn't know we need Fixes for man pages.  I'll also attach a fixes for
the first patch for commit a252b3345 ("ioctl_userfaultfd.2: Describe
two-step feature handshake").

Thanks,

-- 
Peter Xu
Re: [PATCH 2/2] UFFDIO_API.2const: Add an entry for UFFDIO_MOVE
Posted by Alejandro Colomar 8 months, 4 weeks ago 
Hi Peter,

On Wed, May 14, 2025 at 01:22:49PM -0400, Peter Xu wrote:
> On Wed, May 14, 2025 at 05:02:57PM +0200, Alejandro Colomar wrote:
> > Hi Peter,
> > 
> > On Mon, May 12, 2025 at 01:19:22PM -0400, Peter Xu wrote:
> > > Add the entry for UFFDIO_MOVE in UFFDIO_API.
> > > 
> > > Signed-off-by: Peter Xu <peterx@redhat.com>
> > 
> > Should we add the following tag?
> > 
> > Fixes: d7dec35a3b19 (2025-05-01; "man/man2/ioctl_userfaultfd.2, man/man2const/UFFDIO_MOVE.2const: Document UFFDIO_MOVE")
> 
> Sure.
> 
> > 
> > Also, I think the subject should mention UFFD_FEATURE_MOVE, or at least
> > somewhere in the commit message.
> 
> I'll rename the subject to:
> 
>   UFFDIO_API.2const: Add an entry for UFFDIO_FEATURE_MOVE
> 
> I didn't know we need Fixes for man pages.

We don't *need* it (as you don't technically need it in any projects),
but it's nice to have.  :)

>  I'll also attach a fixes for
> the first patch for commit a252b3345 ("ioctl_userfaultfd.2: Describe
> two-step feature handshake").

Thanks!


Cheers,
Alex

> 
> Thanks,
> 
> -- 
> Peter Xu
> 

-- 
<https://www.alejandro-colomar.es/>
Re: [PATCH 2/2] UFFDIO_API.2const: Add an entry for UFFDIO_MOVE
Posted by Suren Baghdasaryan 9 months ago 
On Mon, May 12, 2025 at 10:19 AM Peter Xu <peterx@redhat.com> wrote:
>
> Add the entry for UFFDIO_MOVE in UFFDIO_API.
>
> Signed-off-by: Peter Xu <peterx@redhat.com>

Reviewed-by: Suren Baghdasaryan <surenb@google.com>

Thanks!


> ---
>  man/man2const/UFFDIO_API.2const | 6 ++++++
>  1 file changed, 6 insertions(+)
>
> diff --git a/man/man2const/UFFDIO_API.2const b/man/man2const/UFFDIO_API.2const
> index 1c554107a..17ea6f905 100644
> --- a/man/man2const/UFFDIO_API.2const
> +++ b/man/man2const/UFFDIO_API.2const
> @@ -204,6 +204,12 @@ ioctl.
>  If this feature bit is set,
>  the write protection faults would be asynchronously resolved
>  by the kernel.
> +.TP
> +.BR UFFD_FEATURE_MOVE " (since Linux 6.8)"
> +If this feature bit is set,
> +the kernel supports resolving faults with the
> +.B UFFDIO_MOVE
> +ioctl.
>  .P
>  The returned
>  .I argp->ioctls
> --
> 2.49.0
>

Patchew 2.1-devel-b67e4c2

© 2016 - 2026 Red Hat, Inc.