[v5] Convert inno hdmi to drm bridge

[PATCH v5 00/10] Convert inno hdmi to drm bridge

Posted by Andy Yan 7 months, 1 week ago

From: Andy Yan <andy.yan@rock-chips.com>


Convert it to drm bridge driver, it will be convenient for us to
migrate the connector part to the display driver later.

Patches that have already been merged in drm-misc-next are dropped.

PATCH 1~8 are some cleanup and refactor.
PATCH 9 converts the curren driver to drm bridge mode.
PATCH 10 add Add entry in MAINTAINERS file.

Changes in v5:
- Split cleanup code as separate patch
- Switch to devm_drm_bridge_alloc() API
- Link to V4: https://lore.kernel.org/linux-rockchip/20250422070455.432666-1-andyshrk@163.com/

Changes in v4:
- Do not store colorimetry within inno_hdmi struct
- Link to V3: https://lore.kernel.org/linux-rockchip/20250402123150.238234-1-andyshrk@163.com/

Changes in v3:
- First included in v3
- Link to V2: https://lore.kernel.org/dri-devel/20250325132944.171111-1-andyshrk@163.com/

Andy Yan (10):
  drm/rockchip: inno_hdmi: Merge register definition to c file
  drm/rockchip: inno_hdmi: Refactor register macros to make checkpatch
    happy
  drm/rockchip: inno_hdmi: Remove unnecessary parentheses to make
    checkpatch happy
  drm/rockchip: inno_hdmi: Rename function inno_hdmi_reset to
    inno_hdmi_init_hw
  drm/rockchip: inno_hdmi: Move ddc/i2c configuration and HOTPLUG unmute
    to inno_hdmi_init_hw
  drm/rockchip: inno_hdmi: Use sleep_range instead of udelay
  drm/rockchip: inno_hdmi: switch i2c registration to devm functions
  drm/rockchip: inno_hdmi: Simpify clk get/enable by
    devm_clk_get_enabled api
  drm/rockchip: inno-hdmi: Convert to drm bridge
  MAINTAINERS: Add entry for Innosilicon hdmi bridge library

 MAINTAINERS                                   |   8 +
 drivers/gpu/drm/bridge/Kconfig                |   7 +
 drivers/gpu/drm/bridge/Makefile               |   1 +
 .../inno_hdmi.c => bridge/inno-hdmi.c}        | 911 ++++++++++--------
 drivers/gpu/drm/rockchip/Kconfig              |   1 +
 drivers/gpu/drm/rockchip/Makefile             |   2 +-
 drivers/gpu/drm/rockchip/inno_hdmi-rockchip.c | 188 ++++
 drivers/gpu/drm/rockchip/inno_hdmi.h          | 349 -------
 include/drm/bridge/inno_hdmi.h                |  33 +
 9 files changed, 737 insertions(+), 763 deletions(-)
 rename drivers/gpu/drm/{rockchip/inno_hdmi.c => bridge/inno-hdmi.c} (52%)
 create mode 100644 drivers/gpu/drm/rockchip/inno_hdmi-rockchip.c
 delete mode 100644 drivers/gpu/drm/rockchip/inno_hdmi.h
 create mode 100644 include/drm/bridge/inno_hdmi.h

-- 
2.43.0

Re: (subset) [PATCH v5 00/10] Convert inno hdmi to drm bridge

Posted by Heiko Stuebner 5 months, 2 weeks ago

On Mon, 12 May 2025 20:46:01 +0800, Andy Yan wrote:
> Convert it to drm bridge driver, it will be convenient for us to
> migrate the connector part to the display driver later.
> 
> Patches that have already been merged in drm-misc-next are dropped.
> 
> PATCH 1~8 are some cleanup and refactor.
> PATCH 9 converts the curren driver to drm bridge mode.
> PATCH 10 add Add entry in MAINTAINERS file.
> 
> [...]

Applied, thanks!

[01/10] drm/rockchip: inno_hdmi: Merge register definition to c file
        commit: 9c3111df6a681f7b0057f05e7211a98d240237eb
[02/10] drm/rockchip: inno_hdmi: Refactor register macros to make checkpatch happy
        commit: 372a927f93fe0477dd1a5f15f11888391f8ef33f
[03/10] drm/rockchip: inno_hdmi: Remove unnecessary parentheses to make checkpatch happy
        commit: 7431c5462c7f20b7f111c9957a007b8de5b8a76a
[04/10] drm/rockchip: inno_hdmi: Rename function inno_hdmi_reset to inno_hdmi_init_hw
        commit: 55137487bdee89189873e437452a077bb591f33a
[05/10] drm/rockchip: inno_hdmi: Move ddc/i2c configuration and HOTPLUG unmute to inno_hdmi_init_hw
        commit: 52ac749b4505339a321b9695fe9d2977294c98da
[06/10] drm/rockchip: inno_hdmi: Use sleep_range instead of udelay
        commit: 1749267beee76bfd8108f5071afb870903c83dab
[07/10] drm/rockchip: inno_hdmi: switch i2c registration to devm functions
        commit: 078bb17c7bbfe5bb119943fb7a9ef4f9a8c8c543
[08/10] drm/rockchip: inno_hdmi: Simpify clk get/enable by devm_clk_get_enabled api
        commit: 6a1b9229ecf11f409edd9392c96bded1672ea5f3


I've picked up the rockchip-specific cleanup, but the actual bridge-
conversion needs additional eyes.

Also comparing the recipients of this thread, I think your missing some
bridge maintainers/reviewers.

scripts/get_maintainer.pl drivers/gpu/drm/bridge lists:

Andrzej Hajda <andrzej.hajda@intel.com> (maintainer:DRM DRIVERS FOR BRIDGE CHIPS)
Neil Armstrong <neil.armstrong@linaro.org> (maintainer:DRM DRIVERS FOR BRIDGE CHIPS)
Robert Foss <rfoss@kernel.org> (maintainer:DRM DRIVERS FOR BRIDGE CHIPS)
Laurent Pinchart <Laurent.pinchart@ideasonboard.com> (reviewer:DRM DRIVERS FOR BRIDGE CHIPS)
Jonas Karlman <jonas@kwiboo.se> (reviewer:DRM DRIVERS FOR BRIDGE CHIPS)
Jernej Skrabec <jernej.skrabec@gmail.com> (reviewer:DRM DRIVERS FOR BRIDGE CHIPS)

and not all of them are in the recipient list.

Best regards,
-- 
Heiko Stuebner <heiko@sntech.de>