It was possible to create a uncompileable config, because of missing
"Depends on" statements in the new Kconfig of the TUXEDO platform driver.

For reference:
https://lore.kernel.org/all/a1d9134f-0567-4a53-a1e7-a55cd6b189a9@infradead.org/

Signed-off-by: Werner Sembach <wse@tuxedocomputers.com>
---
 drivers/platform/x86/tuxedo/nbxx/Kconfig | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/drivers/platform/x86/tuxedo/nbxx/Kconfig b/drivers/platform/x86/tuxedo/nbxx/Kconfig
index 1701374a039d2..9eecbe8127df7 100644
--- a/drivers/platform/x86/tuxedo/nbxx/Kconfig
+++ b/drivers/platform/x86/tuxedo/nbxx/Kconfig
@@ -7,6 +7,8 @@
 
 config TUXEDO_NBXX_ACPI_TUXI
 	tristate "TUXEDO NBxx ACPI TUXI Platform Driver"
+	depends on ACPI_WMI
+	depends on HID
 	help
 	  This driver implements the ACPI TUXI device found on some TUXEDO
 	  notebooks. This enables the control of built-in fans via HWMON.
-- 
2.43.0

On Mon, 12 May 2025, Werner Sembach wrote:

> It was possible to create a uncompileable config, because of missing
> "Depends on" statements in the new Kconfig of the TUXEDO platform driver.
> 
> For reference:
> https://lore.kernel.org/all/a1d9134f-0567-4a53-a1e7-a55cd6b189a9@infradead.org/

Please add a Reported-by tag and you can put that URL into Link: tag.

> Signed-off-by: Werner Sembach <wse@tuxedocomputers.com>
> ---
>  drivers/platform/x86/tuxedo/nbxx/Kconfig | 2 ++
>  1 file changed, 2 insertions(+)
> 
> diff --git a/drivers/platform/x86/tuxedo/nbxx/Kconfig b/drivers/platform/x86/tuxedo/nbxx/Kconfig
> index 1701374a039d2..9eecbe8127df7 100644
> --- a/drivers/platform/x86/tuxedo/nbxx/Kconfig
> +++ b/drivers/platform/x86/tuxedo/nbxx/Kconfig

Eh, what's this path? There's only nb04/.

> @@ -7,6 +7,8 @@
>  
>  config TUXEDO_NBXX_ACPI_TUXI
>  	tristate "TUXEDO NBxx ACPI TUXI Platform Driver"
> +	depends on ACPI_WMI
> +	depends on HID
>  	help
>  	  This driver implements the ACPI TUXI device found on some TUXEDO
>  	  notebooks. This enables the control of built-in fans via HWMON.
> 

-- 
 i.

Am 12.05.25 um 12:57 schrieb Ilpo Järvinen:
> On Mon, 12 May 2025, Werner Sembach wrote:
>
>> It was possible to create a uncompileable config, because of missing
>> "Depends on" statements in the new Kconfig of the TUXEDO platform driver.
>>
>> For reference:
>> https://lore.kernel.org/all/a1d9134f-0567-4a53-a1e7-a55cd6b189a9@infradead.org/
> Please add a Reported-by tag and you can put that URL into Link: tag.
Ok
>
>> Signed-off-by: Werner Sembach <wse@tuxedocomputers.com>
>> ---
>>   drivers/platform/x86/tuxedo/nbxx/Kconfig | 2 ++
>>   1 file changed, 2 insertions(+)
>>
>> diff --git a/drivers/platform/x86/tuxedo/nbxx/Kconfig b/drivers/platform/x86/tuxedo/nbxx/Kconfig
>> index 1701374a039d2..9eecbe8127df7 100644
>> --- a/drivers/platform/x86/tuxedo/nbxx/Kconfig
>> +++ b/drivers/platform/x86/tuxedo/nbxx/Kconfig
> Eh, what's this path? There's only nb04/.
Sorry brainfail was on the wrong branch, just looks almost the same
>
>> @@ -7,6 +7,8 @@
>>   
>>   config TUXEDO_NBXX_ACPI_TUXI
>>   	tristate "TUXEDO NBxx ACPI TUXI Platform Driver"
>> +	depends on ACPI_WMI
>> +	depends on HID
>>   	help
>>   	  This driver implements the ACPI TUXI device found on some TUXEDO
>>   	  notebooks. This enables the control of built-in fans via HWMON.
>>