[PATCH] misc: ti_fpc202: Switch to of_fwnode_handle()

Jiri Slaby (SUSE) posted 1 patch 7 months, 1 week ago
There is a newer version of this series
drivers/misc/ti_fpc202.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
[PATCH] misc: ti_fpc202: Switch to of_fwnode_handle()
Posted by Jiri Slaby (SUSE) 7 months, 1 week ago
of_node_to_fwnode() is an irqdomain's reimplementation of the
"officially" defined of_fwnode_handle(). The former is in the process of
being removed, so use the latter instead.

Signed-off-by: Jiri Slaby (SUSE) <jirislaby@kernel.org>
Fixes: 1e5c9b1efa1c ("misc: add FPC202 dual port controller driver")
Cc: Romain Gantois <romain.gantois@bootlin.com>
Cc: Arnd Bergmann <arnd@arndb.de>
Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Cc: Wolfram Sang <wsa+renesas@sang-engineering.com>
---
 drivers/misc/ti_fpc202.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/misc/ti_fpc202.c b/drivers/misc/ti_fpc202.c
index b9c9ee4bfc4e..cc597682b89c 100644
--- a/drivers/misc/ti_fpc202.c
+++ b/drivers/misc/ti_fpc202.c
@@ -284,7 +284,7 @@ static int fpc202_probe_port(struct fpc202_priv *priv, struct device_node *i2c_h
 
 	desc.chan_id = port_id;
 	desc.parent = dev;
-	desc.bus_handle = of_node_to_fwnode(i2c_handle);
+	desc.bus_handle = of_fwnode_handle(i2c_handle);
 	desc.num_aliases = FPC202_ALIASES_PER_PORT;
 
 	fpc202_fill_alias_table(priv->client, aliases, port_id);
-- 
2.49.0
Re: [PATCH] misc: ti_fpc202: Switch to of_fwnode_handle()
Posted by Romain Gantois 7 months, 1 week ago
Hello Jiri,

On Monday, 12 May 2025 10:58:52 CEST Jiri Slaby (SUSE) wrote:
> of_node_to_fwnode() is an irqdomain's reimplementation of the
> "officially" defined of_fwnode_handle(). The former is in the process of
> being removed, so use the latter instead.
> 
> Signed-off-by: Jiri Slaby (SUSE) <jirislaby@kernel.org>
> Fixes: 1e5c9b1efa1c ("misc: add FPC202 dual port controller driver")
> Cc: Romain Gantois <romain.gantois@bootlin.com>
> Cc: Arnd Bergmann <arnd@arndb.de>
> Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
> Cc: Wolfram Sang <wsa+renesas@sang-engineering.com>
> ---
>  drivers/misc/ti_fpc202.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/misc/ti_fpc202.c b/drivers/misc/ti_fpc202.c
> index b9c9ee4bfc4e..cc597682b89c 100644
> --- a/drivers/misc/ti_fpc202.c
> +++ b/drivers/misc/ti_fpc202.c
> @@ -284,7 +284,7 @@ static int fpc202_probe_port(struct fpc202_priv *priv,
> struct device_node *i2c_h
> 
>  	desc.chan_id = port_id;
>  	desc.parent = dev;
> -	desc.bus_handle = of_node_to_fwnode(i2c_handle);
> +	desc.bus_handle = of_fwnode_handle(i2c_handle);
>  	desc.num_aliases = FPC202_ALIASES_PER_PORT;
> 
>  	fpc202_fill_alias_table(priv->client, aliases, port_id);

Looks good to me.

Reviewed-by: Romain Gantois <romain.gantois@bootlin.com>