net: enetc: fix implicit declaration of function FIELD_PREP

[PATCH net-next] net: enetc: fix implicit declaration of function FIELD_PREP

Posted by Wei Fang 7 months, 1 week ago

The kernel test robot reported the following error:

drivers/net/ethernet/freescale/enetc/ntmp.c: In function 'ntmp_fill_request_hdr':
drivers/net/ethernet/freescale/enetc/ntmp.c:203:38: error: implicit
declaration of function 'FIELD_PREP' [-Wimplicit-function-declaration]
203 |         cbd->req_hdr.access_method = FIELD_PREP(NTMP_ACCESS_METHOD,
    |                                      ^~~~~~~~~~

Therefore, add "bitfield.h" to ntmp_private.h to fix this issue.

Fixes: 4701073c3deb ("net: enetc: add initial netc-lib driver to support NTMP")
Reported-by: kernel test robot <lkp@intel.com>
Closes: https://lore.kernel.org/oe-kbuild-all/202505101047.NTMcerZE-lkp@intel.com/
Signed-off-by: Wei Fang <wei.fang@nxp.com>
---
 drivers/net/ethernet/freescale/enetc/ntmp_private.h | 1 +
 1 file changed, 1 insertion(+)

diff --git a/drivers/net/ethernet/freescale/enetc/ntmp_private.h b/drivers/net/ethernet/freescale/enetc/ntmp_private.h
index 685b388e7ddf..34394e40fddd 100644
--- a/drivers/net/ethernet/freescale/enetc/ntmp_private.h
+++ b/drivers/net/ethernet/freescale/enetc/ntmp_private.h
@@ -7,6 +7,7 @@
 #ifndef __NTMP_PRIVATE_H
 #define __NTMP_PRIVATE_H
 
+#include <linux/bitfield.h>
 #include <linux/fsl/ntmp.h>
 
 #define NTMP_EID_REQ_LEN	8
-- 
2.34.1

Re: [PATCH net-next] net: enetc: fix implicit declaration of function FIELD_PREP

Posted by Vladimir Oltean 7 months, 1 week ago

On Mon, May 12, 2025 at 02:17:01PM +0800, Wei Fang wrote:
> The kernel test robot reported the following error:
> 
> drivers/net/ethernet/freescale/enetc/ntmp.c: In function 'ntmp_fill_request_hdr':
> drivers/net/ethernet/freescale/enetc/ntmp.c:203:38: error: implicit
> declaration of function 'FIELD_PREP' [-Wimplicit-function-declaration]
> 203 |         cbd->req_hdr.access_method = FIELD_PREP(NTMP_ACCESS_METHOD,
>     |                                      ^~~~~~~~~~
> 
> Therefore, add "bitfield.h" to ntmp_private.h to fix this issue.
> 
> Fixes: 4701073c3deb ("net: enetc: add initial netc-lib driver to support NTMP")
> Reported-by: kernel test robot <lkp@intel.com>
> Closes: https://lore.kernel.org/oe-kbuild-all/202505101047.NTMcerZE-lkp@intel.com/
> Signed-off-by: Wei Fang <wei.fang@nxp.com>
> ---

Reviewed-by: Vladimir Oltean <vladimir.oltean@nxp.com>