[PATCH] io_uring/uring_cmd: fix hybrid polling initialization issue

hexue posted 1 patch 7 months, 1 week ago
io_uring/uring_cmd.c | 5 +++++
1 file changed, 5 insertions(+)
[PATCH] io_uring/uring_cmd: fix hybrid polling initialization issue
Posted by hexue 7 months, 1 week ago
Modify the defect that the timer is not initialized during IO transfer
when passthrough is used with hybrid polling to ensure that the program
can run normally.

Fixes: 01ee194d1aba ("io_uring: add support for hybrid IOPOLL")
Signed-off-by: hexue <xue01.he@samsung.com>
---
 io_uring/uring_cmd.c | 5 +++++
 1 file changed, 5 insertions(+)

diff --git a/io_uring/uring_cmd.c b/io_uring/uring_cmd.c
index a9ea7d29cdd9..430ed620ddfe 100644
--- a/io_uring/uring_cmd.c
+++ b/io_uring/uring_cmd.c
@@ -254,6 +254,11 @@ int io_uring_cmd(struct io_kiocb *req, unsigned int issue_flags)
 			return -EOPNOTSUPP;
 		issue_flags |= IO_URING_F_IOPOLL;
 		req->iopoll_completed = 0;
+		if (ctx->flags & IORING_SETUP_HYBRID_IOPOLL) {
+			/* make sure every req only blocks once */
+			req->flags &= ~REQ_F_IOPOLL_STATE;
+			req->iopoll_start = ktime_get_ns();
+		}
 	}
 
 	ret = file->f_op->uring_cmd(ioucmd, issue_flags);
-- 
2.43.0
Re: [PATCH] io_uring/uring_cmd: fix hybrid polling initialization issue
Posted by Jens Axboe 7 months, 1 week ago
On Mon, 12 May 2025 13:20:25 +0800, hexue wrote:
> Modify the defect that the timer is not initialized during IO transfer
> when passthrough is used with hybrid polling to ensure that the program
> can run normally.
> 
> 

Applied, thanks!

[1/1] io_uring/uring_cmd: fix hybrid polling initialization issue
      commit: 63166b815dc163b2e46426cecf707dc5923d6d13

Best regards,
-- 
Jens Axboe
Re: [PATCH] io_uring/uring_cmd: fix hybrid polling initialization issue
Posted by Kanchan Joshi/Kanchan Joshi 7 months, 1 week ago
On 5/12/2025 10:50 AM, hexue wrote:
> Modify the defect that the timer is not initialized during IO transfer
> when passthrough is used with hybrid polling to ensure that the program
> can run normally.
> 
> Fixes: 01ee194d1aba ("io_uring: add support for hybrid IOPOLL")
> Signed-off-by: hexue<xue01.he@samsung.com>

So without this patch, liburing passthrough test 
(io_uring_passthrough.t) gets stuck.
With this patch, I do not see the issue and test runs to completion.

This may need stable tag though
Cc: stable@vger.kernel.org # 6.13+

With that,
Reviewed and Tested by: Kanchan Joshi <joshi.k@samsung.com>