Add the download mode support for IPQ5018

[PATCH 0/2] Add the download mode support for IPQ5018

Posted by George Moussalem via B4 Relay 9 months ago

Enable support for download mode to collect the RAM dumps in case of
system crashes, to perform post mortem analysis.

Signed-off-by: George Moussalem <george.moussalem@outlook.com>
---
George Moussalem (2):
      dt-bindings: mfd: qcom,tcsr: Add compatible for ipq5018
      arm64: dts: qcom: ipq5018: enable the download mode support

 Documentation/devicetree/bindings/mfd/qcom,tcsr.yaml | 1 +
 arch/arm64/boot/dts/qcom/ipq5018.dtsi                | 6 ++++++
 2 files changed, 7 insertions(+)
---
base-commit: edef457004774e598fc4c1b7d1d4f0bcd9d0bb30
change-id: 20250512-ipq5018-syscon-1e349e0b224f

Best regards,
-- 
George Moussalem <george.moussalem@outlook.com>

Re: (subset) [PATCH 0/2] Add the download mode support for IPQ5018

Posted by Bjorn Andersson 9 months ago

On Mon, 12 May 2025 18:36:45 +0400, George Moussalem wrote:
> Enable support for download mode to collect the RAM dumps in case of
> system crashes, to perform post mortem analysis.
> 
> 

Applied, thanks!

[2/2] arm64: dts: qcom: ipq5018: enable the download mode support
      commit: 43fefd6c71291b5793e7c4052b6e3e54d1d87715

Best regards,
-- 
Bjorn Andersson <andersson@kernel.org>

Re: (subset) [PATCH 0/2] Add the download mode support for IPQ5018

Posted by Rob Herring 9 months ago

On Wed, May 14, 2025 at 10:03:45PM +0100, Bjorn Andersson wrote:
> 
> On Mon, 12 May 2025 18:36:45 +0400, George Moussalem wrote:
> > Enable support for download mode to collect the RAM dumps in case of
> > system crashes, to perform post mortem analysis.
> > 
> > 
> 
> Applied, thanks!
> 
> [2/2] arm64: dts: qcom: ipq5018: enable the download mode support
>       commit: 43fefd6c71291b5793e7c4052b6e3e54d1d87715

You should really either wait a bit for the binding to be applied or 
just take the binding patch when it is trivial. Then we're not getting 
temporary warnings added which seems to happen a lot on QCom platforms.

Rob

Re: (subset) [PATCH 0/2] Add the download mode support for IPQ5018

Posted by Lee Jones 8 months, 4 weeks ago

On Wed, 14 May 2025, Rob Herring wrote:

> On Wed, May 14, 2025 at 10:03:45PM +0100, Bjorn Andersson wrote:
> > 
> > On Mon, 12 May 2025 18:36:45 +0400, George Moussalem wrote:
> > > Enable support for download mode to collect the RAM dumps in case of
> > > system crashes, to perform post mortem analysis.
> > > 
> > > 
> > 
> > Applied, thanks!
> > 
> > [2/2] arm64: dts: qcom: ipq5018: enable the download mode support
> >       commit: 43fefd6c71291b5793e7c4052b6e3e54d1d87715
> 
> You should really either wait a bit for the binding to be applied or 
> just take the binding patch when it is trivial. Then we're not getting 
> temporary warnings added which seems to happen a lot on QCom platforms.

First option is fine, but please don't apply the bindings, since it'll
cause annoying conflicts.

-- 
Lee Jones [李琼斯]