On Mon, May 12, 2025 at 07:33:22PM +0200, Frank Wunderlich wrote:
> Am 12. Mai 2025 18:21:45 MESZ schrieb Conor Dooley <conor@kernel.org>:
> >On Sun, May 11, 2025 at 04:19:17PM +0200, Frank Wunderlich wrote:
> >> From: Frank Wunderlich <frank-w@public-files.de>
> >>
> >> Update binding for mt7988 which has 3 gmac and 2 reg items.
> >>
> >> Signed-off-by: Frank Wunderlich <frank-w@public-files.de>
> >> ---
> >> Documentation/devicetree/bindings/net/mediatek,net.yaml | 9 +++++++--
> >> 1 file changed, 7 insertions(+), 2 deletions(-)
> >>
> >> diff --git a/Documentation/devicetree/bindings/net/mediatek,net.yaml b/Documentation/devicetree/bindings/net/mediatek,net.yaml
> >> index 9e02fd80af83..5d249da02c3a 100644
> >> --- a/Documentation/devicetree/bindings/net/mediatek,net.yaml
> >> +++ b/Documentation/devicetree/bindings/net/mediatek,net.yaml
> >> @@ -28,7 +28,8 @@ properties:
> >> - ralink,rt5350-eth
> >>
> >> reg:
> >> - maxItems: 1
> >> + minItems: 1
> >> + maxItems: 2
> >
> >This should become an items list, with an explanation of what each of
> >the reg items represents.
>
> I would change to this
>
> reg:
> items:
> - description: Register for accessing the MACs.
> - description: SoC internal SRAM used for DMA operations.
> minItems: 1
>
> Would this be OK this way?
Ye, that looks good.
>
> >>
> >> clocks:
> >> minItems: 2
> >> @@ -381,8 +382,12 @@ allOf:
> >> - const: xgp2
> >> - const: xgp3
> >>
> >> + reg:
> >> + minItems: 2
> >> + maxItems: 2
You also shouldn't need to set maxItems here, since the list has 2 items
total.
> >> +
> >> patternProperties:
> >> - "^mac@[0-1]$":
> >> + "^mac@[0-2]$":
> >> type: object
> >> unevaluatedProperties: false
> >> allOf:
> >> --
> >> 2.43.0
> >>
>
> Hi Conor
>
> Thank you for review.
> regards Frank