[PATCH v3 0/2] rockchip: Enable Ethernet controller on Radxa E20C

Jonas Karlman posted 2 patches 7 months, 1 week ago
.../boot/dts/rockchip/rk3528-radxa-e20c.dts   |  30 +++++
arch/arm64/boot/dts/rockchip/rk3528.dtsi      | 105 ++++++++++++++++++
2 files changed, 135 insertions(+)
[PATCH v3 0/2] rockchip: Enable Ethernet controller on Radxa E20C
Posted by Jonas Karlman 7 months, 1 week ago
The Rockchip RK3528 has two Ethernet controllers, one 100/10 MAC to be
used with the integrated PHY and a second 1000/100/10 MAC to be used
with an external Ethernet PHY.

This series add device tree nodes for the Ethernet controllers found in
RK3528 and enable the LAN interface on Radxa E20C.

This include a gmac0 node for the 100/10 MAC and its related integrated
PHY node that only have recived limited testing. I have no board that
expose an Ethernet port for the gmac0 and the integrated PHY. However,
the PHY can be identified on addr 0x2 as 0044.1400 and in vendor kernel
this relate to the Rockchip RK630 PHY. A proper PHY driver will be
needed to support any real use of gmac0.

Changes in v3:
- Rebase on top of latest mmind/for-next

Changes in v2:
- Split from the "Add GMAC support for RK3528" driver series [1]
- Add ethernet-phy@2 for the integrated PHY
- Rebase on top of the "Support I2C controllers in RK3528" series [2]

[1] https://lore.kernel.org/r/20250309232622.1498084-1-jonas@kwiboo.se
[2] https://lore.kernel.org/r/20250309070603.35254-1-ziyao@disroot.org

Jonas Karlman (2):
  arm64: dts: rockchip: Add GMAC nodes for RK3528
  arm64: dts: rockchip: Enable Ethernet controller on Radxa E20C

 .../boot/dts/rockchip/rk3528-radxa-e20c.dts   |  30 +++++
 arch/arm64/boot/dts/rockchip/rk3528.dtsi      | 105 ++++++++++++++++++
 2 files changed, 135 insertions(+)

-- 
2.49.0
Re: [PATCH v3 0/2] rockchip: Enable Ethernet controller on Radxa E20C
Posted by Heiko Stuebner 7 months, 1 week ago
On Fri, 09 May 2025 20:23:56 +0000, Jonas Karlman wrote:
> The Rockchip RK3528 has two Ethernet controllers, one 100/10 MAC to be
> used with the integrated PHY and a second 1000/100/10 MAC to be used
> with an external Ethernet PHY.
> 
> This series add device tree nodes for the Ethernet controllers found in
> RK3528 and enable the LAN interface on Radxa E20C.
> 
> [...]

Applied, thanks!

[1/2] arm64: dts: rockchip: Add GMAC nodes for RK3528
      commit: 5eb28f461a1b368a57994cc3b3f2ba3154c00bb8
[2/2] arm64: dts: rockchip: Enable Ethernet controller on Radxa E20C
      commit: 10b9ef4a514b25dea6eac24f25e3027866526800

Best regards,
-- 
Heiko Stuebner <heiko@sntech.de>
Re: [PATCH v3 0/2] rockchip: Enable Ethernet controller on Radxa E20C
Posted by Yao Zi 7 months, 1 week ago
On Fri, May 09, 2025 at 08:23:56PM +0000, Jonas Karlman wrote:
> The Rockchip RK3528 has two Ethernet controllers, one 100/10 MAC to be
> used with the integrated PHY and a second 1000/100/10 MAC to be used
> with an external Ethernet PHY.
> 
> This series add device tree nodes for the Ethernet controllers found in
> RK3528 and enable the LAN interface on Radxa E20C.
> 
> This include a gmac0 node for the 100/10 MAC and its related integrated
> PHY node that only have recived limited testing. I have no board that
> expose an Ethernet port for the gmac0 and the integrated PHY. However,
> the PHY can be identified on addr 0x2 as 0044.1400 and in vendor kernel
> this relate to the Rockchip RK630 PHY. A proper PHY driver will be
> needed to support any real use of gmac0.
> 
> Changes in v3:
> - Rebase on top of latest mmind/for-next
> 
> Changes in v2:
> - Split from the "Add GMAC support for RK3528" driver series [1]
> - Add ethernet-phy@2 for the integrated PHY
> - Rebase on top of the "Support I2C controllers in RK3528" series [2]
> 
> [1] https://lore.kernel.org/r/20250309232622.1498084-1-jonas@kwiboo.se
> [2] https://lore.kernel.org/r/20250309070603.35254-1-ziyao@disroot.org
> 
> Jonas Karlman (2):
>   arm64: dts: rockchip: Add GMAC nodes for RK3528
>   arm64: dts: rockchip: Enable Ethernet controller on Radxa E20C
> 
>  .../boot/dts/rockchip/rk3528-radxa-e20c.dts   |  30 +++++
>  arch/arm64/boot/dts/rockchip/rk3528.dtsi      | 105 ++++++++++++++++++
>  2 files changed, 135 insertions(+)

On my Radxa E20C board, iperf3 shows the interface could run at roughly
1Gbps with this series,

# iperf3 -c 192.168.114.51
Connecting to host 192.168.114.51, port 5201
[  5] local 192.168.114.50 port 41894 connected to 192.168.114.51 port 5201
[ ID] Interval           Transfer     Bitrate         Retr  Cwnd
[  5]   0.00-1.00   sec   113 MBytes   948 Mbits/sec    0    380 KByes
[  5]   1.00-2.00   sec   112 MBytes   944 Mbits/sec    0    399 KBytes
[  5]   2.00-3.00   sec   112 MBytes   940 Mbits/sec    0    399 KBytes
[  5]   3.00-4.00   sec   112 MBytes   942 Mbits/sec    0    399 KBytes
[  5]   4.00-5.00   sec   112 MBytes   944 Mbits/sec    0    399 KBytes
[  5]   5.00-6.00   sec   112 MBytes   940 Mbits/sec    0    399 KBytes
[  5]   6.00-7.00   sec   112 MBytes   940 Mbits/sec    0    399 KBytes
[  5]   7.00-8.00   sec   112 MBytes   944 Mbits/sec    0    399 KBytes
[  5]   8.00-9.00   sec   112 MBytes   941 Mbits/sec    0    399 KBytes
[  5]   9.00-10.00  sec   112 MBytes   941 Mbits/sec    0    399 KBytes
- - - - - - - - - - - - - - - - - - - - - - - - -
[ ID] Interval           Transfer     Bitrate         Retr
[  5]   0.00-10.00  sec  1.10 GBytes   942 Mbits/sec    0            sender
[  5]   0.00-10.00  sec  1.10 GBytes   941 Mbits/sec                  receiver

iperf Done.

Tested-by: Yao Zi <ziyao@disroot.org>

Thanks for your work!

> -- 
> 2.49.0
>
Re: [PATCH v3 0/2] rockchip: Enable Ethernet controller on Radxa E20C
Posted by Heiko Stübner 7 months, 1 week ago
Am Freitag, 9. Mai 2025, 22:23:56 Mitteleuropäische Sommerzeit schrieb Jonas Karlman:
> The Rockchip RK3528 has two Ethernet controllers, one 100/10 MAC to be
> used with the integrated PHY and a second 1000/100/10 MAC to be used
> with an external Ethernet PHY.
> 
> This series add device tree nodes for the Ethernet controllers found in
> RK3528 and enable the LAN interface on Radxa E20C.
> 
> This include a gmac0 node for the 100/10 MAC and its related integrated
> PHY node that only have recived limited testing. I have no board that
> expose an Ethernet port for the gmac0 and the integrated PHY. However,
> the PHY can be identified on addr 0x2 as 0044.1400 and in vendor kernel
> this relate to the Rockchip RK630 PHY. A proper PHY driver will be
> needed to support any real use of gmac0.
> 
> Changes in v3:
> - Rebase on top of latest mmind/for-next
> 
> Changes in v2:
> - Split from the "Add GMAC support for RK3528" driver series [1]

split from ... was that series merged already?

The linked lore-thread only talks about the series needing to be reposted.


Heiko

> - Add ethernet-phy@2 for the integrated PHY
> - Rebase on top of the "Support I2C controllers in RK3528" series [2]
> 
> [1] https://lore.kernel.org/r/20250309232622.1498084-1-jonas@kwiboo.se
> [2] https://lore.kernel.org/r/20250309070603.35254-1-ziyao@disroot.org
> 
> Jonas Karlman (2):
>   arm64: dts: rockchip: Add GMAC nodes for RK3528
>   arm64: dts: rockchip: Enable Ethernet controller on Radxa E20C
> 
>  .../boot/dts/rockchip/rk3528-radxa-e20c.dts   |  30 +++++
>  arch/arm64/boot/dts/rockchip/rk3528.dtsi      | 105 ++++++++++++++++++
>  2 files changed, 135 insertions(+)
> 
> 
Re: [PATCH v3 0/2] rockchip: Enable Ethernet controller on Radxa E20C
Posted by Jonas Karlman 7 months, 1 week ago
Hi Heiko,

On 2025-05-09 23:40, Heiko Stübner wrote:
> Am Freitag, 9. Mai 2025, 22:23:56 Mitteleuropäische Sommerzeit schrieb Jonas Karlman:
>> The Rockchip RK3528 has two Ethernet controllers, one 100/10 MAC to be
>> used with the integrated PHY and a second 1000/100/10 MAC to be used
>> with an external Ethernet PHY.
>>
>> This series add device tree nodes for the Ethernet controllers found in
>> RK3528 and enable the LAN interface on Radxa E20C.
>>
>> This include a gmac0 node for the 100/10 MAC and its related integrated
>> PHY node that only have recived limited testing. I have no board that
>> expose an Ethernet port for the gmac0 and the integrated PHY. However,
>> the PHY can be identified on addr 0x2 as 0044.1400 and in vendor kernel
>> this relate to the Rockchip RK630 PHY. A proper PHY driver will be
>> needed to support any real use of gmac0.
>>
>> Changes in v3:
>> - Rebase on top of latest mmind/for-next
>>
>> Changes in v2:
>> - Split from the "Add GMAC support for RK3528" driver series [1]
> 
> split from ... was that series merged already?

Yes, sorry for not being more clear, the dt-bindings and driver has been
merged and is already included in v6.15-rc1.

https://lore.kernel.org/r/174291544076.609648.8594782943472190694.git-patchwork-notify@kernel.org

Regards,
Jonas

> 
> The linked lore-thread only talks about the series needing to be reposted.
> 
> 
> Heiko
> 
>> - Add ethernet-phy@2 for the integrated PHY
>> - Rebase on top of the "Support I2C controllers in RK3528" series [2]
>>
>> [1] https://lore.kernel.org/r/20250309232622.1498084-1-jonas@kwiboo.se
>> [2] https://lore.kernel.org/r/20250309070603.35254-1-ziyao@disroot.org
>>
>> Jonas Karlman (2):
>>   arm64: dts: rockchip: Add GMAC nodes for RK3528
>>   arm64: dts: rockchip: Enable Ethernet controller on Radxa E20C
>>
>>  .../boot/dts/rockchip/rk3528-radxa-e20c.dts   |  30 +++++
>>  arch/arm64/boot/dts/rockchip/rk3528.dtsi      | 105 ++++++++++++++++++
>>  2 files changed, 135 insertions(+)