[PATCH] arm64: dts: rockchip: drop wrong spdif clock from edp1 on rk3588

Heiko Stuebner posted 1 patch 7 months, 1 week ago
arch/arm64/boot/dts/rockchip/rk3588-extra.dtsi | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
[PATCH] arm64: dts: rockchip: drop wrong spdif clock from edp1 on rk3588
Posted by Heiko Stuebner 7 months, 1 week ago
As described, the analogix-dp controller on rk3588 only supports 2 clocks
and the edp0 node handles that correctly.

The edp1 node on the other hand seems to have a dangling 3rd clock called
spdif, that probably only exists in the vendor-tree.

As that is not handled at all, remove it for now so that we adhere to the
binding.

Fixes: a481bb0b1ad9 ("arm64: dts: rockchip: Add eDP1 dt node for rk3588")
Signed-off-by: Heiko Stuebner <heiko@sntech.de>
---
 arch/arm64/boot/dts/rockchip/rk3588-extra.dtsi | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/arch/arm64/boot/dts/rockchip/rk3588-extra.dtsi b/arch/arm64/boot/dts/rockchip/rk3588-extra.dtsi
index 9d81d3b9444e..90414486e466 100644
--- a/arch/arm64/boot/dts/rockchip/rk3588-extra.dtsi
+++ b/arch/arm64/boot/dts/rockchip/rk3588-extra.dtsi
@@ -255,8 +255,8 @@ hdmi1_out: port@1 {
 	edp1: edp@fded0000 {
 		compatible = "rockchip,rk3588-edp";
 		reg = <0x0 0xfded0000 0x0 0x1000>;
-		clocks = <&cru CLK_EDP1_24M>, <&cru PCLK_EDP1>, <&cru CLK_EDP1_200M>;
-		clock-names = "dp", "pclk", "spdif";
+		clocks = <&cru CLK_EDP1_24M>, <&cru PCLK_EDP1>;
+		clock-names = "dp", "pclk";
 		interrupts = <GIC_SPI 164 IRQ_TYPE_LEVEL_HIGH 0>;
 		phys = <&hdptxphy1>;
 		phy-names = "dp";
-- 
2.47.2
Re: [PATCH] arm64: dts: rockchip: drop wrong spdif clock from edp1 on rk3588
Posted by Heiko Stuebner 7 months, 1 week ago
On Fri, 09 May 2025 17:23:29 +0200, Heiko Stuebner wrote:
> As described, the analogix-dp controller on rk3588 only supports 2 clocks
> and the edp0 node handles that correctly.
> 
> The edp1 node on the other hand seems to have a dangling 3rd clock called
> spdif, that probably only exists in the vendor-tree.
> 
> As that is not handled at all, remove it for now so that we adhere to the
> binding.
> 
> [...]

Applied, thanks!

[1/1] arm64: dts: rockchip: drop wrong spdif clock from edp1 on rk3588
      commit: 30f98e934a094b4a2de79ffdb877360c4289b8d6

Best regards,
-- 
Heiko Stuebner <heiko@sntech.de>