pinctrl: meson: Drop unused aml_pctl_find_group_by_name()

[PATCH] pinctrl: meson: Drop unused aml_pctl_find_group_by_name()

Posted by Krzysztof Kozlowski 7 months, 1 week ago

aml_pctl_find_group_by_name() is not used anywhere, as reported by W=1
clang build:

  pinctrl-amlogic-a4.c:600:2: error: unused function 'aml_pctl_find_group_by_name' [-Werror,-Wunused-function]

Fixes: 6e9be3abb78c ("pinctrl: Add driver support for Amlogic SoCs")
Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
---
 drivers/pinctrl/meson/pinctrl-amlogic-a4.c | 14 --------------
 1 file changed, 14 deletions(-)

diff --git a/drivers/pinctrl/meson/pinctrl-amlogic-a4.c b/drivers/pinctrl/meson/pinctrl-amlogic-a4.c
index a76f266b4b94..385cc619df13 100644
--- a/drivers/pinctrl/meson/pinctrl-amlogic-a4.c
+++ b/drivers/pinctrl/meson/pinctrl-amlogic-a4.c
@@ -596,20 +596,6 @@ static int aml_get_group_pins(struct pinctrl_dev *pctldev,
 	return 0;
 }
 
-static inline const struct aml_pctl_group *
-	aml_pctl_find_group_by_name(const struct aml_pinctrl *info,
-				    const char *name)
-{
-	int i;
-
-	for (i = 0; i < info->ngroups; i++) {
-		if (!strcmp(info->groups[i].name, name))
-			return &info->groups[i];
-	}
-
-	return NULL;
-}
-
 static void aml_pin_dbg_show(struct pinctrl_dev *pcdev, struct seq_file *s,
 			     unsigned int offset)
 {
-- 
2.45.2

Re: [PATCH] pinctrl: meson: Drop unused aml_pctl_find_group_by_name()

Posted by Linus Walleij 7 months, 1 week ago

On Fri, May 9, 2025 at 5:01 PM Krzysztof Kozlowski
<krzysztof.kozlowski@linaro.org> wrote:

> aml_pctl_find_group_by_name() is not used anywhere, as reported by W=1
> clang build:
>
>   pinctrl-amlogic-a4.c:600:2: error: unused function 'aml_pctl_find_group_by_name' [-Werror,-Wunused-function]
>
> Fixes: 6e9be3abb78c ("pinctrl: Add driver support for Amlogic SoCs")
> Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>

Patch applied!

Yours,
Linus Walleij

Re: [PATCH] pinctrl: meson: Drop unused aml_pctl_find_group_by_name()

Posted by Xianwei Zhao 7 months, 1 week ago

Reviewed-by: Xianwei Zhao <xianwei.zhao@amlogic.com>

On 2025/5/9 23:01, Krzysztof Kozlowski wrote:
> [ EXTERNAL EMAIL ]
> 
> aml_pctl_find_group_by_name() is not used anywhere, as reported by W=1
> clang build:
> 
>    pinctrl-amlogic-a4.c:600:2: error: unused function 'aml_pctl_find_group_by_name' [-Werror,-Wunused-function]
> 
> Fixes: 6e9be3abb78c ("pinctrl: Add driver support for Amlogic SoCs")
> Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
> ---
>   drivers/pinctrl/meson/pinctrl-amlogic-a4.c | 14 --------------
>   1 file changed, 14 deletions(-)
> 
> diff --git a/drivers/pinctrl/meson/pinctrl-amlogic-a4.c b/drivers/pinctrl/meson/pinctrl-amlogic-a4.c
> index a76f266b4b94..385cc619df13 100644
> --- a/drivers/pinctrl/meson/pinctrl-amlogic-a4.c
> +++ b/drivers/pinctrl/meson/pinctrl-amlogic-a4.c
> @@ -596,20 +596,6 @@ static int aml_get_group_pins(struct pinctrl_dev *pctldev,
>          return 0;
>   }
> 
> -static inline const struct aml_pctl_group *
> -       aml_pctl_find_group_by_name(const struct aml_pinctrl *info,
> -                                   const char *name)
> -{
> -       int i;
> -
> -       for (i = 0; i < info->ngroups; i++) {
> -               if (!strcmp(info->groups[i].name, name))
> -                       return &info->groups[i];
> -       }
> -
> -       return NULL;
> -}
> -
>   static void aml_pin_dbg_show(struct pinctrl_dev *pcdev, struct seq_file *s,
>                               unsigned int offset)
>   {
> --
> 2.45.2
>

Re: [PATCH] pinctrl: meson: Drop unused aml_pctl_find_group_by_name()

Posted by Martin Blumenstingl 7 months, 1 week ago

On Fri, May 9, 2025 at 5:01 PM Krzysztof Kozlowski
<krzysztof.kozlowski@linaro.org> wrote:
>
> aml_pctl_find_group_by_name() is not used anywhere, as reported by W=1
> clang build:
>
>   pinctrl-amlogic-a4.c:600:2: error: unused function 'aml_pctl_find_group_by_name' [-Werror,-Wunused-function]
>
> Fixes: 6e9be3abb78c ("pinctrl: Add driver support for Amlogic SoCs")
> Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
Reviewed-by: Martin Blumenstingl <martin.blumenstingl@googlemail.com>