[PATCH 1/2] nvmem: rmem: select CONFIG_CRC32

srini@kernel.org posted 2 patches 7 months, 1 week ago
[PATCH 1/2] nvmem: rmem: select CONFIG_CRC32
Posted by srini@kernel.org 7 months, 1 week ago
From: Arnd Bergmann <arnd@arndb.de>

The newly added crc checking leads to a link failure if CRC32
itself is disabled:

x86_64-linux-ld: vmlinux.o: in function `rmem_eyeq5_checksum':
rmem.c:(.text+0x52341b): undefined reference to `crc32_le_arch'

Fixes: 7e606c311f70 ("nvmem: rmem: add CRC validation for Mobileye EyeQ5 NVMEM")
Signed-off-by: Arnd Bergmann <arnd@arndb.de>
Signed-off-by: Srinivas Kandagatla <srini@kernel.org>
---
 drivers/nvmem/Kconfig | 1 +
 1 file changed, 1 insertion(+)

diff --git a/drivers/nvmem/Kconfig b/drivers/nvmem/Kconfig
index 8671b7c974b9..eceb3cdb421f 100644
--- a/drivers/nvmem/Kconfig
+++ b/drivers/nvmem/Kconfig
@@ -260,6 +260,7 @@ config NVMEM_RCAR_EFUSE
 config NVMEM_RMEM
 	tristate "Reserved Memory Based Driver Support"
 	depends on HAS_IOMEM
+	select CRC32
 	help
 	  This driver maps reserved memory into an nvmem device. It might be
 	  useful to expose information left by firmware in memory.
-- 
2.43.0
Re: [PATCH 1/2] nvmem: rmem: select CONFIG_CRC32
Posted by Greg KH 6 months, 4 weeks ago
On Fri, May 09, 2025 at 01:24:06PM +0100, srini@kernel.org wrote:
> From: Arnd Bergmann <arnd@arndb.de>
> 
> The newly added crc checking leads to a link failure if CRC32
> itself is disabled:
> 
> x86_64-linux-ld: vmlinux.o: in function `rmem_eyeq5_checksum':
> rmem.c:(.text+0x52341b): undefined reference to `crc32_le_arch'
> 
> Fixes: 7e606c311f70 ("nvmem: rmem: add CRC validation for Mobileye EyeQ5 NVMEM")

You forgot to cc: stable :(