[PATCH 0/3] Add RADXA ROCK 5T support

Nicolas Frattaroli posted 3 patches 7 months, 1 week ago
There is a newer version of this series
.../devicetree/bindings/arm/rockchip.yaml          |    5 +
arch/arm64/boot/dts/rockchip/Makefile              |    1 +
.../boot/dts/rockchip/rk3588-rock-5b-5bp-5t.dtsi   | 1012 ++++++++++++++++++++
arch/arm64/boot/dts/rockchip/rk3588-rock-5b.dtsi   | 1012 +-------------------
arch/arm64/boot/dts/rockchip/rk3588-rock-5t.dts    |  105 ++
5 files changed, 1131 insertions(+), 1004 deletions(-)
[PATCH 0/3] Add RADXA ROCK 5T support
Posted by Nicolas Frattaroli 7 months, 1 week ago
This is a small series, depending on Sebastian Reichel's ROCK 5B+
series[1], to also add support for the ROCK 5T.

The ROCK 5T is quite similar to the ROCK 5B+ and the ROCK 5B, so to
share as much DT boilerplate between them as we can, this series
reorganises things a bit and then adds the ROCK 5T .dts.

Link: https://lore.kernel.org/linux-rockchip/20250508-rock5bp-for-upstream-v2-0-677033cc1ac2@kernel.org/T/ [1]
Signed-off-by: Nicolas Frattaroli <nicolas.frattaroli@collabora.com>
---
Nicolas Frattaroli (3):
      dt-bindings: arm: rockchip: add RADXA ROCK 5T
      arm64: dts: rockchip: reorganise common rock5* nodes
      arm64: dts: rockchip: add ROCK 5T device tree

 .../devicetree/bindings/arm/rockchip.yaml          |    5 +
 arch/arm64/boot/dts/rockchip/Makefile              |    1 +
 .../boot/dts/rockchip/rk3588-rock-5b-5bp-5t.dtsi   | 1012 ++++++++++++++++++++
 arch/arm64/boot/dts/rockchip/rk3588-rock-5b.dtsi   | 1012 +-------------------
 arch/arm64/boot/dts/rockchip/rk3588-rock-5t.dts    |  105 ++
 5 files changed, 1131 insertions(+), 1004 deletions(-)
---
base-commit: 19c541fe872387798a25df947f56a26212aa9a97
change-id: 20250509-add-rock5t-fde5927de36b
prerequisite-message-id: <20250508-rock5bp-for-upstream-v2-0-677033cc1ac2@kernel.org>
prerequisite-patch-id: 02bf159533bb53d2cb1b6c8c7caf1d3fcfbfa4ea
prerequisite-patch-id: fc153d1d48f19d63520086a6eaadfec2db960470
prerequisite-patch-id: f445b893edf31ccf3311e146a53e5d24861c2475
prerequisite-patch-id: 5dc410a438ad5a7aa8962e380d2733782f5d7d18
prerequisite-patch-id: c70ae0e30be2a3385d2f2a09f474ff2b76293843

Best regards,
-- 
Nicolas Frattaroli <nicolas.frattaroli@collabora.com>
Re: [PATCH 0/3] Add RADXA ROCK 5T support
Posted by Rob Herring (Arm) 7 months, 1 week ago
On Fri, 09 May 2025 14:31:40 +0200, Nicolas Frattaroli wrote:
> This is a small series, depending on Sebastian Reichel's ROCK 5B+
> series[1], to also add support for the ROCK 5T.
> 
> The ROCK 5T is quite similar to the ROCK 5B+ and the ROCK 5B, so to
> share as much DT boilerplate between them as we can, this series
> reorganises things a bit and then adds the ROCK 5T .dts.
> 
> Link: https://lore.kernel.org/linux-rockchip/20250508-rock5bp-for-upstream-v2-0-677033cc1ac2@kernel.org/T/ [1]
> Signed-off-by: Nicolas Frattaroli <nicolas.frattaroli@collabora.com>
> ---
> Nicolas Frattaroli (3):
>       dt-bindings: arm: rockchip: add RADXA ROCK 5T
>       arm64: dts: rockchip: reorganise common rock5* nodes
>       arm64: dts: rockchip: add ROCK 5T device tree
> 
>  .../devicetree/bindings/arm/rockchip.yaml          |    5 +
>  arch/arm64/boot/dts/rockchip/Makefile              |    1 +
>  .../boot/dts/rockchip/rk3588-rock-5b-5bp-5t.dtsi   | 1012 ++++++++++++++++++++
>  arch/arm64/boot/dts/rockchip/rk3588-rock-5b.dtsi   | 1012 +-------------------
>  arch/arm64/boot/dts/rockchip/rk3588-rock-5t.dts    |  105 ++
>  5 files changed, 1131 insertions(+), 1004 deletions(-)
> ---
> base-commit: 19c541fe872387798a25df947f56a26212aa9a97
> change-id: 20250509-add-rock5t-fde5927de36b
> prerequisite-message-id: <20250508-rock5bp-for-upstream-v2-0-677033cc1ac2@kernel.org>
> prerequisite-patch-id: 02bf159533bb53d2cb1b6c8c7caf1d3fcfbfa4ea
> prerequisite-patch-id: fc153d1d48f19d63520086a6eaadfec2db960470
> prerequisite-patch-id: f445b893edf31ccf3311e146a53e5d24861c2475
> prerequisite-patch-id: 5dc410a438ad5a7aa8962e380d2733782f5d7d18
> prerequisite-patch-id: c70ae0e30be2a3385d2f2a09f474ff2b76293843
> 
> Best regards,
> --
> Nicolas Frattaroli <nicolas.frattaroli@collabora.com>
> 
> 
> 


My bot found new DTB warnings on the .dts files added or changed in this
series.

Some warnings may be from an existing SoC .dtsi. Or perhaps the warnings
are fixed by another series. Ultimately, it is up to the platform
maintainer whether these warnings are acceptable or not. No need to reply
unless the platform maintainer has comments.

If you already ran DT checks and didn't see these error(s), then
make sure dt-schema is up to date:

  pip3 install dtschema --upgrade


This patch series was applied (using b4) to base:
 Base: using specified base-commit 19c541fe872387798a25df947f56a26212aa9a97
 Deps: looking for dependencies matching 5 patch-ids
 Deps: Applying prerequisite patch: [PATCH v2 1/5] arm64: dts: rockchip: move rock 5b to include file
 Deps: Applying prerequisite patch: [PATCH v2 2/5] arm64: dts: rockchip: move rock 5b to include file
 Deps: Applying prerequisite patch: [PATCH v2 3/5] dt-bindings: arm: rockchip: Add Radxa ROCK 5B+
 Deps: Applying prerequisite patch: [PATCH v2 4/5] arm64: dts: rockchip: add Rock 5B+
 Deps: Applying prerequisite patch: [PATCH v2 5/5] arm64: dts: rockchip: add USB-C support for ROCK 5B+

If this is not the correct base, please add 'base-commit' tag
(or use b4 which does this automatically)

New warnings running 'make CHECK_DTBS=y for arch/arm64/boot/dts/rockchip/' for 20250509-add-rock5t-v1-0-cff1de74eced@collabora.com:

arch/arm64/boot/dts/rockchip/rk3588-rock-5b-plus.dtb: edp@fded0000 (rockchip,rk3588-edp): clock-names:2: 'grf' was expected
	from schema $id: http://devicetree.org/schemas/display/rockchip/rockchip,analogix-dp.yaml#
arch/arm64/boot/dts/rockchip/rk3588-rock-5t.dtb: edp@fded0000 (rockchip,rk3588-edp): clock-names:2: 'grf' was expected
	from schema $id: http://devicetree.org/schemas/display/rockchip/rockchip,analogix-dp.yaml#
Re: [PATCH 0/3] Add RADXA ROCK 5T support
Posted by Heiko Stübner 7 months, 1 week ago
Am Freitag, 9. Mai 2025, 16:17:07 Mitteleuropäische Sommerzeit schrieb Rob Herring (Arm):
> 
> On Fri, 09 May 2025 14:31:40 +0200, Nicolas Frattaroli wrote:
> > This is a small series, depending on Sebastian Reichel's ROCK 5B+
> > series[1], to also add support for the ROCK 5T.
> > 
> > The ROCK 5T is quite similar to the ROCK 5B+ and the ROCK 5B, so to
> > share as much DT boilerplate between them as we can, this series
> > reorganises things a bit and then adds the ROCK 5T .dts.
> > 
> > Link: https://lore.kernel.org/linux-rockchip/20250508-rock5bp-for-upstream-v2-0-677033cc1ac2@kernel.org/T/ [1]
> > Signed-off-by: Nicolas Frattaroli <nicolas.frattaroli@collabora.com>
> > ---
> > Nicolas Frattaroli (3):
> >       dt-bindings: arm: rockchip: add RADXA ROCK 5T
> >       arm64: dts: rockchip: reorganise common rock5* nodes
> >       arm64: dts: rockchip: add ROCK 5T device tree
> > 
> >  .../devicetree/bindings/arm/rockchip.yaml          |    5 +
> >  arch/arm64/boot/dts/rockchip/Makefile              |    1 +
> >  .../boot/dts/rockchip/rk3588-rock-5b-5bp-5t.dtsi   | 1012 ++++++++++++++++++++
> >  arch/arm64/boot/dts/rockchip/rk3588-rock-5b.dtsi   | 1012 +-------------------
> >  arch/arm64/boot/dts/rockchip/rk3588-rock-5t.dts    |  105 ++
> >  5 files changed, 1131 insertions(+), 1004 deletions(-)
> > ---
> > base-commit: 19c541fe872387798a25df947f56a26212aa9a97
> > change-id: 20250509-add-rock5t-fde5927de36b
> > prerequisite-message-id: <20250508-rock5bp-for-upstream-v2-0-677033cc1ac2@kernel.org>
> > prerequisite-patch-id: 02bf159533bb53d2cb1b6c8c7caf1d3fcfbfa4ea
> > prerequisite-patch-id: fc153d1d48f19d63520086a6eaadfec2db960470
> > prerequisite-patch-id: f445b893edf31ccf3311e146a53e5d24861c2475
> > prerequisite-patch-id: 5dc410a438ad5a7aa8962e380d2733782f5d7d18
> > prerequisite-patch-id: c70ae0e30be2a3385d2f2a09f474ff2b76293843
> > 
> > Best regards,
> > --
> > Nicolas Frattaroli <nicolas.frattaroli@collabora.com>
> > 
> > 
> > 
> 
> 
> My bot found new DTB warnings on the .dts files added or changed in this
> series.
> 
> Some warnings may be from an existing SoC .dtsi. Or perhaps the warnings
> are fixed by another series. Ultimately, it is up to the platform
> maintainer whether these warnings are acceptable or not. No need to reply
> unless the platform maintainer has comments.
> 
> If you already ran DT checks and didn't see these error(s), then
> make sure dt-schema is up to date:
> 
>   pip3 install dtschema --upgrade
> 
> 
> This patch series was applied (using b4) to base:
>  Base: using specified base-commit 19c541fe872387798a25df947f56a26212aa9a97
>  Deps: looking for dependencies matching 5 patch-ids
>  Deps: Applying prerequisite patch: [PATCH v2 1/5] arm64: dts: rockchip: move rock 5b to include file
>  Deps: Applying prerequisite patch: [PATCH v2 2/5] arm64: dts: rockchip: move rock 5b to include file
>  Deps: Applying prerequisite patch: [PATCH v2 3/5] dt-bindings: arm: rockchip: Add Radxa ROCK 5B+
>  Deps: Applying prerequisite patch: [PATCH v2 4/5] arm64: dts: rockchip: add Rock 5B+
>  Deps: Applying prerequisite patch: [PATCH v2 5/5] arm64: dts: rockchip: add USB-C support for ROCK 5B+
> 
> If this is not the correct base, please add 'base-commit' tag
> (or use b4 which does this automatically)
> 
> New warnings running 'make CHECK_DTBS=y for arch/arm64/boot/dts/rockchip/' for 20250509-add-rock5t-v1-0-cff1de74eced@collabora.com:
> 
> arch/arm64/boot/dts/rockchip/rk3588-rock-5b-plus.dtb: edp@fded0000 (rockchip,rk3588-edp): clock-names:2: 'grf' was expected
> 	from schema $id: http://devicetree.org/schemas/display/rockchip/rockchip,analogix-dp.yaml#
> arch/arm64/boot/dts/rockchip/rk3588-rock-5t.dtb: edp@fded0000 (rockchip,rk3588-edp): clock-names:2: 'grf' was expected
> 	from schema $id: http://devicetree.org/schemas/display/rockchip/rockchip,analogix-dp.yaml#

Fixed that in
https://lore.kernel.org/all/20250509152329.2004073-1-heiko@sntech.de/

(edp0 node was correct, edp1 node contained a clock named spdif, that
probably came from the vendor-tree)