Minor namespace code simplication

[PATCH v2 0/2] Minor namespace code simplication

Posted by Joel Savitz 9 months ago

The two patches are independent of each other. The first patch removes
unnecssary NULL guards from free_nsproxy() and create_new_namespaces()
in line with other usage of the put_*_ns() call sites. The second patch
slightly reduces the size of the kernel when CONFIG_CGROUPS is not
selected.

Joel Savitz (2):
  kernel/nsproxy: remove unnecessary guards
  include/cgroup: separate {get,put}_cgroup_ns no-op case

Changes from v1:
- now removing the guards instead of adding them where missing since
  checking that all calls in the NULL case were already no-ops
- added second patch

 include/linux/cgroup.h | 26 ++++++++++++++------------
 kernel/nsproxy.c       | 30 ++++++++++--------------------
 2 files changed, 24 insertions(+), 32 deletions(-)

-- 
2.45.2

Re: [PATCH v2 0/2] Minor namespace code simplication

Posted by Christian Brauner 9 months ago

On Thu, 08 May 2025 14:49:28 -0400, Joel Savitz wrote:
> The two patches are independent of each other. The first patch removes
> unnecssary NULL guards from free_nsproxy() and create_new_namespaces()
> in line with other usage of the put_*_ns() call sites. The second patch
> slightly reduces the size of the kernel when CONFIG_CGROUPS is not
> selected.
> 
> Joel Savitz (2):
>   kernel/nsproxy: remove unnecessary guards
>   include/cgroup: separate {get,put}_cgroup_ns no-op case
> 
> [...]

Applied to the vfs-6.16.misc branch of the vfs/vfs.git tree.
Patches in the vfs-6.16.misc branch should appear in linux-next soon.

Please report any outstanding bugs that were missed during review in a
new review to the original patch series allowing us to drop it.

It's encouraged to provide Acked-bys and Reviewed-bys even though the
patch has now been applied. If possible patch trailers will be updated.

Note that commit hashes shown below are subject to change due to rebase,
trailer updates or similar. If in doubt, please check the listed branch.

tree:   https://git.kernel.org/pub/scm/linux/kernel/git/vfs/vfs.git
branch: vfs-6.16.misc

[1/2] kernel/nsproxy: remove unnecessary guards
      https://git.kernel.org/vfs/vfs/c/5caa2d89b7f1
[2/2] include/cgroup: separate {get,put}_cgroup_ns no-op case
      https://git.kernel.org/vfs/vfs/c/79fb8d8d93e4