[PATCH 1/5] PCI: pci_ids: add INTEL_HDA_WCL

Peter Ujfalusi posted 5 patches 9 months ago
There is a newer version of this series
[PATCH 1/5] PCI: pci_ids: add INTEL_HDA_WCL
Posted by Peter Ujfalusi 9 months ago
Add PCI id for Wildcat Lake audio.

Signed-off-by: Peter Ujfalusi <peter.ujfalusi@linux.intel.com>
Reviewed-by: Kai Vehmanen <kai.vehmanen@linux.intel.com>
Reviewed-by: Bard Liao <yung-chuan.liao@linux.intel.com>
Reviewed-by: Guennadi Liakhovetski <guennadi.liakhovetski@linux.intel.com>
Reviewed-by: Ranjani Sridharan <ranjani.sridharan@linux.intel.com>
---
 include/linux/pci_ids.h | 1 +
 1 file changed, 1 insertion(+)

diff --git a/include/linux/pci_ids.h b/include/linux/pci_ids.h
index 981ed45cc45e..e2d71b6fdd84 100644
--- a/include/linux/pci_ids.h
+++ b/include/linux/pci_ids.h
@@ -3049,6 +3049,7 @@
 #define PCI_DEVICE_ID_INTEL_HDA_DG1	0x490d
 #define PCI_DEVICE_ID_INTEL_HDA_EHL_0	0x4b55
 #define PCI_DEVICE_ID_INTEL_HDA_EHL_3	0x4b58
+#define PCI_DEVICE_ID_INTEL_HDA_WCL	0x4d28
 #define PCI_DEVICE_ID_INTEL_HDA_JSL_N	0x4dc8
 #define PCI_DEVICE_ID_INTEL_HDA_DG2_0	0x4f90
 #define PCI_DEVICE_ID_INTEL_HDA_DG2_1	0x4f91
-- 
2.49.0
Re: [PATCH 1/5] PCI: pci_ids: add INTEL_HDA_WCL
Posted by Krzysztof Wilczyński 8 months, 4 weeks ago
Hello,

Just a few small nitpicks.

Consider an update to the subject to match the history, e.g.,

  PCI: Add Intel Wildcat Lake audio Device ID

> Add PCI id for Wildcat Lake audio.

Also, for consistency with other such commits:

  Add Wildcat Lake (WCL) audio Device ID.

> Signed-off-by: Peter Ujfalusi <peter.ujfalusi@linux.intel.com>
> Reviewed-by: Kai Vehmanen <kai.vehmanen@linux.intel.com>
> Reviewed-by: Bard Liao <yung-chuan.liao@linux.intel.com>
> Reviewed-by: Guennadi Liakhovetski <guennadi.liakhovetski@linux.intel.com>
> Reviewed-by: Ranjani Sridharan <ranjani.sridharan@linux.intel.com>

Acked-by: Krzysztof Wilczyński <kwilczynski@kernel.org>

Thank you!

	Krzysztof
Re: [PATCH 1/5] PCI: pci_ids: add INTEL_HDA_WCL
Posted by Péter Ujfalusi 8 months, 3 weeks ago

On 15/05/2025 20:03, Krzysztof Wilczyński wrote:
> Hello,
> 
> Just a few small nitpicks.
> 
> Consider an update to the subject to match the history, e.g.,
> 
>   PCI: Add Intel Wildcat Lake audio Device ID

I have looked up the history and used the previous audio IP ID addition
commit as template:

a1f7b7ff0e10 ("PCI: pci_ids: add INTEL_HDA_PTL_H")

PCI: pci_ids: add INTEL_HDA_PTL_H

Add Intel PTL-H audio Device ID.

I will update and stick with the suggested suggestion for the future.
>> Add PCI id for Wildcat Lake audio.
> 
> Also, for consistency with other such commits:
> 
>   Add Wildcat Lake (WCL) audio Device ID.
> 
>> Signed-off-by: Peter Ujfalusi <peter.ujfalusi@linux.intel.com>
>> Reviewed-by: Kai Vehmanen <kai.vehmanen@linux.intel.com>
>> Reviewed-by: Bard Liao <yung-chuan.liao@linux.intel.com>
>> Reviewed-by: Guennadi Liakhovetski <guennadi.liakhovetski@linux.intel.com>
>> Reviewed-by: Ranjani Sridharan <ranjani.sridharan@linux.intel.com>
> 
> Acked-by: Krzysztof Wilczyński <kwilczynski@kernel.org>
> 
> Thank you!
> 
> 	Krzysztof

-- 
Péter