This series introduces support for the QST QMC5883L 3-axis magnetometer, a magnetic sensor with I2C interface. The implementation follows standard IIO conventions and includes: Patch 1/5: dt-bindings: vendor-prefixes - Adds 'qst' prefix for QST Corporation Patch 2/5: dt-bindings: iio: magnetometer - Adds QMC5883L bindings - Adds compatible string and required properties - Includes example device tree node Patch 3/5: iio: magnetometer - Base driver implementation - Basic register access via regmap - X/Y/Z axis and temperature readings - Triggered buffer support - Initialization and core functionality Patch 4/5: Extended sysfs attributes and configuration - ODR (10-200Hz) and FSR (±2G/±8G) control - Mode selection (standby/continuous) - Oversampling ratio configuration (512-64) - Status monitoring (DRDY/OVL flags) - Available scale and sampling frequency attributes Patch 5/5: Advanced features and power management - Mount matrix support for orientation compensation - Power management (suspend/resume) - Control register features (soft reset, pointer rollover) The driver has been tested on a Raspberry Pi 5 and all features have been verified. Signed-off-by: Brajesh Patil <brajeshpatil11@gmail.com>
On Thu, 8 May 2025 13:08:22 +0100 Brajesh Patil <brajeshpatil11@gmail.com> wrote: > This series introduces support for the QST QMC5883L 3-axis magnetometer, > a magnetic sensor with I2C interface. > > The implementation follows standard IIO conventions and includes: > > Patch 1/5: dt-bindings: vendor-prefixes > - Adds 'qst' prefix for QST Corporation Make sure patch 1 also goes to linux-iio@vger.kernel.org as otherwise I won't necessarily pick it up with the rest of the series. Also I think the threading is broken. If you are struggling with an email setup, the b4 tool can be used to send via a web gateway with the correct formatting etc. Jonathan > > Patch 2/5: dt-bindings: iio: magnetometer - Adds QMC5883L bindings > - Adds compatible string and required properties > - Includes example device tree node > > Patch 3/5: iio: magnetometer - Base driver implementation > - Basic register access via regmap > - X/Y/Z axis and temperature readings > - Triggered buffer support > - Initialization and core functionality > > Patch 4/5: Extended sysfs attributes and configuration > - ODR (10-200Hz) and FSR (±2G/±8G) control > - Mode selection (standby/continuous) > - Oversampling ratio configuration (512-64) > - Status monitoring (DRDY/OVL flags) > - Available scale and sampling frequency attributes > > Patch 5/5: Advanced features and power management > - Mount matrix support for orientation compensation > - Power management (suspend/resume) > - Control register features (soft reset, pointer rollover) > > The driver has been tested on a Raspberry Pi 5 and all features have been verified. > > Signed-off-by: Brajesh Patil <brajeshpatil11@gmail.com>
On 5/8/25 7:08 AM, Brajesh Patil wrote: > This series introduces support for the QST QMC5883L 3-axis magnetometer, > a magnetic sensor with I2C interface. > > The implementation follows standard IIO conventions and includes: > > Patch 1/5: dt-bindings: vendor-prefixes > - Adds 'qst' prefix for QST Corporation > > Patch 2/5: dt-bindings: iio: magnetometer - Adds QMC5883L bindings > - Adds compatible string and required properties > - Includes example device tree node > > Patch 3/5: iio: magnetometer - Base driver implementation > - Basic register access via regmap > - X/Y/Z axis and temperature readings > - Triggered buffer support > - Initialization and core functionality > > Patch 4/5: Extended sysfs attributes and configuration > - ODR (10-200Hz) and FSR (±2G/±8G) control > - Mode selection (standby/continuous) > - Oversampling ratio configuration (512-64) > - Status monitoring (DRDY/OVL flags) > - Available scale and sampling frequency attributes > > Patch 5/5: Advanced features and power management > - Mount matrix support for orientation compensation > - Power management (suspend/resume) > - Control register features (soft reset, pointer rollover) This sort of information should be in the descriptions of the individual patches, not in the cover letter. > > The driver has been tested on a Raspberry Pi 5 and all features have been verified. This info is good to have in the cover letter. Even better though would be to explain a bit about the actual methodology of how you tested it. Also, a v2 should have a link to v1 and describe the changes made since then. It look like v2 was sent the same day as v1. Generally, you should wait a week (or at least a few days) to give others time to review before sending a new version. > > Signed-off-by: Brajesh Patil <brajeshpatil11@gmail.com>
© 2016 - 2025 Red Hat, Inc.