[v4] PCI: dwc: tegra194: Broaden architecture dependency

[PATCH V4] PCI: dwc: tegra194: Broaden architecture dependency

Posted by Vidya Sagar 7 months, 1 week ago

Replace ARCH_TEGRA_194_SOC dependency with a more generic ARCH_TEGRA
check for the Tegra194 PCIe controller, allowing it to be built on
Tegra platforms beyond Tegra194. Additionally, ensure compatibility
by requiring ARM64 or COMPILE_TEST.

Link: https://patchwork.kernel.org/project/linux-pci/patch/20250128044244.2766334-1-vidyas@nvidia.com/
Signed-off-by: Vidya Sagar <vidyas@nvidia.com>
---
v4:
* Split the Tegra194 driver and phy driver changes

v3:
* Addressed warning from kernel test robot

v2:
* Addressed review comments from Niklas Cassel and Manivannan Sadhasivam

 drivers/pci/controller/dwc/Kconfig | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/drivers/pci/controller/dwc/Kconfig b/drivers/pci/controller/dwc/Kconfig
index d9f0386396ed..815b6e0d6a0c 100644
--- a/drivers/pci/controller/dwc/Kconfig
+++ b/drivers/pci/controller/dwc/Kconfig
@@ -226,7 +226,7 @@ config PCIE_TEGRA194
 
 config PCIE_TEGRA194_HOST
 	tristate "NVIDIA Tegra194 (and later) PCIe controller (host mode)"
-	depends on ARCH_TEGRA_194_SOC || COMPILE_TEST
+	depends on ARCH_TEGRA && (ARM64 || COMPILE_TEST)
 	depends on PCI_MSI
 	select PCIE_DW_HOST
 	select PHY_TEGRA194_P2U
@@ -241,7 +241,7 @@ config PCIE_TEGRA194_HOST
 
 config PCIE_TEGRA194_EP
 	tristate "NVIDIA Tegra194 (and later) PCIe controller (endpoint mode)"
-	depends on ARCH_TEGRA_194_SOC || COMPILE_TEST
+	depends on ARCH_TEGRA && (ARM64 || COMPILE_TEST)
 	depends on PCI_ENDPOINT
 	select PCIE_DW_EP
 	select PHY_TEGRA194_P2U
-- 
2.25.1

Re: [PATCH V4] PCI: dwc: tegra194: Broaden architecture dependency

Posted by Vinod Koul 7 months ago

On Thu, 08 May 2025 10:49:22 +0530, Vidya Sagar wrote:
> Replace ARCH_TEGRA_194_SOC dependency with a more generic ARCH_TEGRA
> check for the Tegra194 PCIe controller, allowing it to be built on
> Tegra platforms beyond Tegra194. Additionally, ensure compatibility
> by requiring ARM64 or COMPILE_TEST.
> 
> 

Applied, thanks!

[1/1] PCI: dwc: tegra194: Broaden architecture dependency
      (no commit info)
[1/1] phy: tegra: p2u: Broaden architecture dependency
      commit: 0c22287319741b4e7c7beaedac1f14fbe01a03b9

Best regards,
-- 
~Vinod

Re: [PATCH V4] PCI: dwc: tegra194: Broaden architecture dependency

Posted by Niklas Cassel 7 months ago

Hello Vinod, Krzysztof,

On Wed, May 14, 2025 at 12:38:01PM +0100, Vinod Koul wrote:
> 
> On Thu, 08 May 2025 10:49:22 +0530, Vidya Sagar wrote:
> > Replace ARCH_TEGRA_194_SOC dependency with a more generic ARCH_TEGRA
> > check for the Tegra194 PCIe controller, allowing it to be built on
> > Tegra platforms beyond Tegra194. Additionally, ensure compatibility
> > by requiring ARM64 or COMPILE_TEST.
> > 
> > 
> 
> Applied, thanks!
> 
> [1/1] PCI: dwc: tegra194: Broaden architecture dependency
>       (no commit info)
> [1/1] phy: tegra: p2u: Broaden architecture dependency
>       commit: 0c22287319741b4e7c7beaedac1f14fbe01a03b9
> 
> Best regards,
> -- 

I see that Vinod has queued patch 1/2.

Please don't forget that this series requires coordination.

There are many ways to solve it.

1) One tree takes both patches.

2) PHY tree puts the PHY patch on an immutable branch with just that
commit, and PCI merges that branch, so the same SHA1 of the PHY patch
is in both trees.

3) Send PHY patch for the upcoming merge window. Send PCI patch for
merge window + 1.

Kind regards,
Niklas

Re: [PATCH V4] PCI: dwc: tegra194: Broaden architecture dependency

Posted by Vinod Koul 7 months ago

On 14-05-25, 15:02, Niklas Cassel wrote:
> Hello Vinod, Krzysztof,
> 
> On Wed, May 14, 2025 at 12:38:01PM +0100, Vinod Koul wrote:
> > 
> > On Thu, 08 May 2025 10:49:22 +0530, Vidya Sagar wrote:
> > > Replace ARCH_TEGRA_194_SOC dependency with a more generic ARCH_TEGRA
> > > check for the Tegra194 PCIe controller, allowing it to be built on
> > > Tegra platforms beyond Tegra194. Additionally, ensure compatibility
> > > by requiring ARM64 or COMPILE_TEST.
> > > 
> > > 
> > 
> > Applied, thanks!
> > 
> > [1/1] PCI: dwc: tegra194: Broaden architecture dependency
> >       (no commit info)
> > [1/1] phy: tegra: p2u: Broaden architecture dependency
> >       commit: 0c22287319741b4e7c7beaedac1f14fbe01a03b9
> > 
> > Best regards,
> > -- 
> 
> I see that Vinod has queued patch 1/2.
> 
> Please don't forget that this series requires coordination.
> 
> There are many ways to solve it.
> 
> 1) One tree takes both patches.
> 
> 2) PHY tree puts the PHY patch on an immutable branch with just that
> commit, and PCI merges that branch, so the same SHA1 of the PHY patch
> is in both trees.
> 
> 3) Send PHY patch for the upcoming merge window. Send PCI patch for
> merge window + 1.

1, 3 works for me, for 2 pls let me know, I need to prep a branch with
this patch and tag on it...

BR

-- 
~Vinod

Re: [PATCH V4] PCI: dwc: tegra194: Broaden architecture dependency

Posted by Manivannan Sadhasivam 7 months ago

On Wed, May 14, 2025 at 02:17:26PM +0100, Vinod Koul wrote:
> On 14-05-25, 15:02, Niklas Cassel wrote:
> > Hello Vinod, Krzysztof,
> > 
> > On Wed, May 14, 2025 at 12:38:01PM +0100, Vinod Koul wrote:
> > > 
> > > On Thu, 08 May 2025 10:49:22 +0530, Vidya Sagar wrote:
> > > > Replace ARCH_TEGRA_194_SOC dependency with a more generic ARCH_TEGRA
> > > > check for the Tegra194 PCIe controller, allowing it to be built on
> > > > Tegra platforms beyond Tegra194. Additionally, ensure compatibility
> > > > by requiring ARM64 or COMPILE_TEST.
> > > > 
> > > > 
> > > 
> > > Applied, thanks!
> > > 
> > > [1/1] PCI: dwc: tegra194: Broaden architecture dependency
> > >       (no commit info)
> > > [1/1] phy: tegra: p2u: Broaden architecture dependency
> > >       commit: 0c22287319741b4e7c7beaedac1f14fbe01a03b9
> > > 
> > > Best regards,
> > > -- 
> > 
> > I see that Vinod has queued patch 1/2.
> > 
> > Please don't forget that this series requires coordination.
> > 
> > There are many ways to solve it.
> > 
> > 1) One tree takes both patches.
> > 
> > 2) PHY tree puts the PHY patch on an immutable branch with just that
> > commit, and PCI merges that branch, so the same SHA1 of the PHY patch
> > is in both trees.
> > 
> > 3) Send PHY patch for the upcoming merge window. Send PCI patch for
> > merge window + 1.
> 
> 1, 3 works for me, for 2 pls let me know, I need to prep a branch with
> this patch and tag on it...
> 

Feel free to take the patch 1 through PHY tree with:

Acked-by: Manivannan Sadhasivam <manivannan.sadhasivam@linaro.org>

I believe there should be no conflict with the PCI tree.

- Mani

-- 
மணிவண்ணன் சதாசிவம்

Re: [PATCH V4] PCI: dwc: tegra194: Broaden architecture dependency

Posted by Krzysztof Wilczyński 7 months, 1 week ago

Hello,

> Replace ARCH_TEGRA_194_SOC dependency with a more generic ARCH_TEGRA
> check for the Tegra194 PCIe controller, allowing it to be built on
> Tegra platforms beyond Tegra194. Additionally, ensure compatibility
> by requiring ARM64 or COMPILE_TEST.

Looks good!  With that,

Acked-by: Krzysztof Wilczyński <kwilczynski@kernel.org>

Thank you!

	Krzysztof

Re: [PATCH V4] PCI: dwc: tegra194: Broaden architecture dependency

Posted by Niklas Cassel 7 months, 1 week ago

On Thu, May 08, 2025 at 10:49:22AM +0530, Vidya Sagar wrote:
> Replace ARCH_TEGRA_194_SOC dependency with a more generic ARCH_TEGRA
> check for the Tegra194 PCIe controller, allowing it to be built on
> Tegra platforms beyond Tegra194. Additionally, ensure compatibility
> by requiring ARM64 or COMPILE_TEST.
> 
> Link: https://patchwork.kernel.org/project/linux-pci/patch/20250128044244.2766334-1-vidyas@nvidia.com/
> Signed-off-by: Vidya Sagar <vidyas@nvidia.com>
> ---

Looks good to me, but there will need coordination between the
PHY and PCI maintainers for this to not cause a kernel test bot
build failure, if the PCI patch is merged before the PHY patch.

Reviewed-by: Niklas Cassel <cassel@kernel.org>

Re: [PATCH V4] PCI: dwc: tegra194: Broaden architecture dependency

Posted by Thierry Reding 7 months, 1 week ago

On Thu, May 08, 2025 at 02:17:24PM +0200, Niklas Cassel wrote:
> On Thu, May 08, 2025 at 10:49:22AM +0530, Vidya Sagar wrote:
> > Replace ARCH_TEGRA_194_SOC dependency with a more generic ARCH_TEGRA
> > check for the Tegra194 PCIe controller, allowing it to be built on
> > Tegra platforms beyond Tegra194. Additionally, ensure compatibility
> > by requiring ARM64 or COMPILE_TEST.
> > 
> > Link: https://patchwork.kernel.org/project/linux-pci/patch/20250128044244.2766334-1-vidyas@nvidia.com/
> > Signed-off-by: Vidya Sagar <vidyas@nvidia.com>
> > ---
> 
> Looks good to me, but there will need coordination between the
> PHY and PCI maintainers for this to not cause a kernel test bot
> build failure, if the PCI patch is merged before the PHY patch.
> 
> Reviewed-by: Niklas Cassel <cassel@kernel.org>

Either the PCI or PHY maintainers would need to provide an Acked-by so
these can go through the same tree.

Alternatively, since these are only platform-related Kconfig changes, I
could pick this up into the Tegra tree if I get Acked-bys from both
subsystems.

Either way is fine, and in case it helps:

Acked-by: Thierry Reding <treding@nvidia.com>

Re: [PATCH V4] PCI: dwc: tegra194: Broaden architecture dependency

Posted by Krzysztof Wilczyński 7 months, 1 week ago

Hello,

[...]
> Alternatively, since these are only platform-related Kconfig changes, I
> could pick this up into the Tegra tree if I get Acked-bys from both
> subsystems.

No objections!  Go ahead, and thank you! :)

	Krzysztof