[PATCH] dt-bindings: iio: light: apds9160: add missing type definition

Dario Binacchi posted 1 patch 7 months, 1 week ago
Documentation/devicetree/bindings/iio/light/brcm,apds9160.yaml | 1 +
1 file changed, 1 insertion(+)
[PATCH] dt-bindings: iio: light: apds9160: add missing type definition
Posted by Dario Binacchi 7 months, 1 week ago
Fix the following warning:

 Documentation/devicetree/bindings/iio/light/brcm,apds9160.yaml: ps-cancellation-current-picoamp: missing type definition

raised by command:

 make dt_binding_check  DT_SCHEMA_FILES=fsl.yaml

Fixes: be464661e7532 ("dt-bindings: iio: light: Add APDS9160 binding")
Signed-off-by: Dario Binacchi <dario.binacchi@amarulasolutions.com>
---

 Documentation/devicetree/bindings/iio/light/brcm,apds9160.yaml | 1 +
 1 file changed, 1 insertion(+)

diff --git a/Documentation/devicetree/bindings/iio/light/brcm,apds9160.yaml b/Documentation/devicetree/bindings/iio/light/brcm,apds9160.yaml
index bb1cc4404a55..f9c35c29fe04 100644
--- a/Documentation/devicetree/bindings/iio/light/brcm,apds9160.yaml
+++ b/Documentation/devicetree/bindings/iio/light/brcm,apds9160.yaml
@@ -37,6 +37,7 @@ properties:
     maximum: 63
 
   ps-cancellation-current-picoamp:
+    $ref: /schemas/types.yaml#/definitions/uint32
     description:
       Proximity sensor crosstalk cancellation current in picoampere.
       This parameter adjusts the current in steps of 2400 pA up to 276000 pA.
-- 
2.43.0

base-commit: 0d8d44db295ccad20052d6301ef49ff01fb8ae2d
branch: fix-brcm,apds9160.yaml
Re: [PATCH] dt-bindings: iio: light: apds9160: add missing type definition
Posted by Rob Herring 7 months, 1 week ago
On Wed, May 07, 2025 at 03:51:38PM +0200, Dario Binacchi wrote:
> Fix the following warning:
> 
>  Documentation/devicetree/bindings/iio/light/brcm,apds9160.yaml: ps-cancellation-current-picoamp: missing type definition
> 
> raised by command:
> 
>  make dt_binding_check  DT_SCHEMA_FILES=fsl.yaml
> 
> Fixes: be464661e7532 ("dt-bindings: iio: light: Add APDS9160 binding")
> Signed-off-by: Dario Binacchi <dario.binacchi@amarulasolutions.com>
> ---
> 
>  Documentation/devicetree/bindings/iio/light/brcm,apds9160.yaml | 1 +
>  1 file changed, 1 insertion(+)

Not needed. Fixed in the latest dtschema.

Rob
Re: [PATCH] dt-bindings: iio: light: apds9160: add missing type definition
Posted by Rob Herring (Arm) 7 months, 1 week ago
On Wed, 07 May 2025 15:51:38 +0200, Dario Binacchi wrote:
> Fix the following warning:
> 
>  Documentation/devicetree/bindings/iio/light/brcm,apds9160.yaml: ps-cancellation-current-picoamp: missing type definition
> 
> raised by command:
> 
>  make dt_binding_check  DT_SCHEMA_FILES=fsl.yaml
> 
> Fixes: be464661e7532 ("dt-bindings: iio: light: Add APDS9160 binding")
> Signed-off-by: Dario Binacchi <dario.binacchi@amarulasolutions.com>
> ---
> 
>  Documentation/devicetree/bindings/iio/light/brcm,apds9160.yaml | 1 +
>  1 file changed, 1 insertion(+)
> 

My bot found errors running 'make dt_binding_check' on your patch:

yamllint warnings/errors:

dtschema/dtc warnings/errors:
/builds/robherring/dt-review-ci/linux/Documentation/devicetree/bindings/iio/light/brcm,apds9160.example.dtb: light-sensor@53 (brcm,apds9160): ps-cancellation-current-picoamp: 62400 is not of type 'array'
	from schema $id: http://devicetree.org/schemas/property-units.yaml#

doc reference errors (make refcheckdocs):

See https://patchwork.ozlabs.org/project/devicetree-bindings/patch/20250507135147.1328639-1-dario.binacchi@amarulasolutions.com

The base for the series is generally the latest rc1. A different dependency
should be noted in *this* patch.

If you already ran 'make dt_binding_check' and didn't see the above
error(s), then make sure 'yamllint' is installed and dt-schema is up to
date:

pip3 install dtschema --upgrade

Please check and re-submit after running the above command yourself. Note
that DT_SCHEMA_FILES can be set to your schema file to speed up checking
your schema. However, it must be unset to test all examples with your schema.