[PATCH 5/8] dt-bindings: arm: qcom: Add bindings for qam8775p SOM

Wasim Nazir posted 8 patches 7 months, 1 week ago
[PATCH 5/8] dt-bindings: arm: qcom: Add bindings for qam8775p SOM
Posted by Wasim Nazir 7 months, 1 week ago
Add devicetree bindings for QAM8775p SOM which is based on sa8775p SOC.
QAM8775p SOM have sa8775p SOC, PMICs and DDR and it is stacked on
ride/ride-r3 boards.

Signed-off-by: Wasim Nazir <quic_wasimn@quicinc.com>
---
 Documentation/devicetree/bindings/arm/qcom.yaml | 1 +
 1 file changed, 1 insertion(+)

diff --git a/Documentation/devicetree/bindings/arm/qcom.yaml b/Documentation/devicetree/bindings/arm/qcom.yaml
index 96420c02a800..671f2d571260 100644
--- a/Documentation/devicetree/bindings/arm/qcom.yaml
+++ b/Documentation/devicetree/bindings/arm/qcom.yaml
@@ -958,6 +958,7 @@ properties:
           - enum:
               - qcom,sa8775p-ride
               - qcom,sa8775p-ride-r3
+          - const: qcom,qam8775p-som
           - const: qcom,sa8775p

       - items:
--
2.49.0
Re: [PATCH 5/8] dt-bindings: arm: qcom: Add bindings for qam8775p SOM
Posted by Krzysztof Kozlowski 7 months, 1 week ago
On 07/05/2025 08:51, Wasim Nazir wrote:
> Add devicetree bindings for QAM8775p SOM which is based on sa8775p SOC.

You do not add new bindings. You instead change existing ones without
explanation why making that change.



Best regards,
Krzysztof
Re: [PATCH 5/8] dt-bindings: arm: qcom: Add bindings for qam8775p SOM
Posted by Wasim Nazir 7 months ago
On Wed, May 07, 2025 at 09:00:18AM +0200, Krzysztof Kozlowski wrote:
> On 07/05/2025 08:51, Wasim Nazir wrote:
> > Add devicetree bindings for QAM8775p SOM which is based on sa8775p SOC.
> 
> You do not add new bindings. You instead change existing ones without
> explanation why making that change.
> 

I understand your concern. We thought of adding it to define the SOM HW
which was not done earlier.
I will drop all the SOM bindings and maintain only SOM DT structure on
IQ9 target (qcs9100), which we need it to add memory-map updates.

Also, I will drop similar change from IQ-9075-evk series [1] for maintaining
similar dt-bindings for IQ9 (qcs9100 & qcs9075) series of targets.

[1]
https://lore.kernel.org/all/20250429054906.113317-1-quic_wasimn@quicinc.com/

> 
> 
> Best regards,
> Krzysztof

Regards,
Wasim