[PATCH 1/2] dt-bindings: add imx95-libra-rdk-fpsc

Yannic Moog posted 2 patches 7 months, 1 week ago
There is a newer version of this series
[PATCH 1/2] dt-bindings: add imx95-libra-rdk-fpsc
Posted by Yannic Moog 7 months, 1 week ago
imx95-libra-rdk-fpsc is a development board based on the phyCORE-i.MX 95
Plus FPSC SoM. Add its description and binding.

Signed-off-by: Yannic Moog <y.moog@phytec.de>
---
 Documentation/devicetree/bindings/arm/fsl.yaml | 7 +++++++
 1 file changed, 7 insertions(+)

diff --git a/Documentation/devicetree/bindings/arm/fsl.yaml b/Documentation/devicetree/bindings/arm/fsl.yaml
index 447054b52ea391f69d11409d51751a88bb8b539a..783550c61cd7e9aa12ffe78bfaa74478c19e0797 100644
--- a/Documentation/devicetree/bindings/arm/fsl.yaml
+++ b/Documentation/devicetree/bindings/arm/fsl.yaml
@@ -1366,6 +1366,13 @@ properties:
               - fsl,imx95-19x19-evk       # i.MX95 19x19 EVK Board
           - const: fsl,imx95
 
+      - description: PHYTEC i.MX 95 FPSC based Boards
+        items:
+          - enum:
+            - phytec,imx95-libra-rdk-fpsc     # Libra-i.MX 95 FPSC
+          - const: phytec,imx95-phycore-fpsc  # phyCORE-i.MX 95 FPSC
+          - const: fsl,imx95
+
       - description: i.MXRT1050 based Boards
         items:
           - enum:

-- 
2.43.0
Re: [PATCH 1/2] dt-bindings: add imx95-libra-rdk-fpsc
Posted by Conor Dooley 7 months, 1 week ago
On Wed, May 07, 2025 at 03:13:12PM +0200, Yannic Moog wrote:
> imx95-libra-rdk-fpsc is a development board based on the phyCORE-i.MX 95
> Plus FPSC SoM. Add its description and binding.
> 
> Signed-off-by: Yannic Moog <y.moog@phytec.de>
> ---
>  Documentation/devicetree/bindings/arm/fsl.yaml | 7 +++++++
>  1 file changed, 7 insertions(+)
> 
> diff --git a/Documentation/devicetree/bindings/arm/fsl.yaml b/Documentation/devicetree/bindings/arm/fsl.yaml
> index 447054b52ea391f69d11409d51751a88bb8b539a..783550c61cd7e9aa12ffe78bfaa74478c19e0797 100644
> --- a/Documentation/devicetree/bindings/arm/fsl.yaml
> +++ b/Documentation/devicetree/bindings/arm/fsl.yaml
> @@ -1366,6 +1366,13 @@ properties:
>                - fsl,imx95-19x19-evk       # i.MX95 19x19 EVK Board
>            - const: fsl,imx95
>  
> +      - description: PHYTEC i.MX 95 FPSC based Boards
> +        items:
> +          - enum:
> +            - phytec,imx95-libra-rdk-fpsc     # Libra-i.MX 95 FPSC
> +          - const: phytec,imx95-phycore-fpsc  # phyCORE-i.MX 95 FPSC
> +          - const: fsl,imx95

Acked-by: Conor Dooley <conor.dooley@microchip.com>
Re: [PATCH 1/2] dt-bindings: add imx95-libra-rdk-fpsc
Posted by Krzysztof Kozlowski 7 months, 1 week ago
On 08/05/2025 16:57, Conor Dooley wrote:
> On Wed, May 07, 2025 at 03:13:12PM +0200, Yannic Moog wrote:
>> imx95-libra-rdk-fpsc is a development board based on the phyCORE-i.MX 95
>> Plus FPSC SoM. Add its description and binding.
>>
>> Signed-off-by: Yannic Moog <y.moog@phytec.de>
>> ---
>>  Documentation/devicetree/bindings/arm/fsl.yaml | 7 +++++++
>>  1 file changed, 7 insertions(+)
>>
>> diff --git a/Documentation/devicetree/bindings/arm/fsl.yaml b/Documentation/devicetree/bindings/arm/fsl.yaml
>> index 447054b52ea391f69d11409d51751a88bb8b539a..783550c61cd7e9aa12ffe78bfaa74478c19e0797 100644
>> --- a/Documentation/devicetree/bindings/arm/fsl.yaml
>> +++ b/Documentation/devicetree/bindings/arm/fsl.yaml
>> @@ -1366,6 +1366,13 @@ properties:
>>                - fsl,imx95-19x19-evk       # i.MX95 19x19 EVK Board
>>            - const: fsl,imx95
>>  
>> +      - description: PHYTEC i.MX 95 FPSC based Boards
>> +        items:
>> +          - enum:
>> +            - phytec,imx95-libra-rdk-fpsc     # Libra-i.MX 95 FPSC
>> +          - const: phytec,imx95-phycore-fpsc  # phyCORE-i.MX 95 FPSC
>> +          - const: fsl,imx95
> 
> Acked-by: Conor Dooley <conor.dooley@microchip.com>


Yes, but this still needs indentation fixes.

Best regards,
Krzysztof
Re: [PATCH 1/2] dt-bindings: add imx95-libra-rdk-fpsc
Posted by Conor Dooley 7 months, 1 week ago
On Thu, May 08, 2025 at 04:59:08PM +0200, Krzysztof Kozlowski wrote:
> On 08/05/2025 16:57, Conor Dooley wrote:
> > On Wed, May 07, 2025 at 03:13:12PM +0200, Yannic Moog wrote:
> >> imx95-libra-rdk-fpsc is a development board based on the phyCORE-i.MX 95
> >> Plus FPSC SoM. Add its description and binding.
> >>
> >> Signed-off-by: Yannic Moog <y.moog@phytec.de>
> >> ---
> >>  Documentation/devicetree/bindings/arm/fsl.yaml | 7 +++++++
> >>  1 file changed, 7 insertions(+)
> >>
> >> diff --git a/Documentation/devicetree/bindings/arm/fsl.yaml b/Documentation/devicetree/bindings/arm/fsl.yaml
> >> index 447054b52ea391f69d11409d51751a88bb8b539a..783550c61cd7e9aa12ffe78bfaa74478c19e0797 100644
> >> --- a/Documentation/devicetree/bindings/arm/fsl.yaml
> >> +++ b/Documentation/devicetree/bindings/arm/fsl.yaml
> >> @@ -1366,6 +1366,13 @@ properties:
> >>                - fsl,imx95-19x19-evk       # i.MX95 19x19 EVK Board
> >>            - const: fsl,imx95
> >>  
> >> +      - description: PHYTEC i.MX 95 FPSC based Boards
> >> +        items:
> >> +          - enum:
> >> +            - phytec,imx95-libra-rdk-fpsc     # Libra-i.MX 95 FPSC
> >> +          - const: phytec,imx95-phycore-fpsc  # phyCORE-i.MX 95 FPSC
> >> +          - const: fsl,imx95
> > 
> > Acked-by: Conor Dooley <conor.dooley@microchip.com>
> 
> 
> Yes, but this still needs indentation fixes.

Oh true, I didn't notice that the bot was actually warning here, not
borked.
Re: [PATCH 1/2] dt-bindings: add imx95-libra-rdk-fpsc
Posted by Rob Herring (Arm) 7 months, 1 week ago
On Wed, 07 May 2025 15:13:12 +0200, Yannic Moog wrote:
> imx95-libra-rdk-fpsc is a development board based on the phyCORE-i.MX 95
> Plus FPSC SoM. Add its description and binding.
> 
> Signed-off-by: Yannic Moog <y.moog@phytec.de>
> ---
>  Documentation/devicetree/bindings/arm/fsl.yaml | 7 +++++++
>  1 file changed, 7 insertions(+)
> 

My bot found errors running 'make dt_binding_check' on your patch:

yamllint warnings/errors:
./Documentation/devicetree/bindings/arm/fsl.yaml:1372:13: [warning] wrong indentation: expected 14 but found 12 (indentation)

dtschema/dtc warnings/errors:

doc reference errors (make refcheckdocs):

See https://patchwork.ozlabs.org/project/devicetree-bindings/patch/20250507-wip-y-moog-phytec-de-imx95-libra-v1-1-4b73843ad4cd@phytec.de

The base for the series is generally the latest rc1. A different dependency
should be noted in *this* patch.

If you already ran 'make dt_binding_check' and didn't see the above
error(s), then make sure 'yamllint' is installed and dt-schema is up to
date:

pip3 install dtschema --upgrade

Please check and re-submit after running the above command yourself. Note
that DT_SCHEMA_FILES can be set to your schema file to speed up checking
your schema. However, it must be unset to test all examples with your schema.