LoongArch: Fix include order

[PATCH core/entry] LoongArch: Fix include order

Posted by Charlie Jenkins 7 months, 1 week ago

Reorder some introduced include headers to keep alphabetical order.

Signed-off-by: Charlie Jenkins <charlie@rivosinc.com>
Fixes: 7ace1602abf2 ("LoongArch: entry: Migrate ret_from_fork() to C")
---
This is a very minor fix to a patch previously applied to the core/entry
tip.
---
 arch/loongarch/kernel/process.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/arch/loongarch/kernel/process.c b/arch/loongarch/kernel/process.c
index 98bc60d7c550fcc0225e8452f81a7d6cd7888015..3582f591bab286c30127e715c47d485f74d5e2ca 100644
--- a/arch/loongarch/kernel/process.c
+++ b/arch/loongarch/kernel/process.c
@@ -13,8 +13,8 @@
 #include <linux/cpu.h>
 #include <linux/init.h>
 #include <linux/kernel.h>
-#include <linux/errno.h>
 #include <linux/entry-common.h>
+#include <linux/errno.h>
 #include <linux/sched.h>
 #include <linux/sched/debug.h>
 #include <linux/sched/task.h>
@@ -34,8 +34,8 @@
 #include <linux/prctl.h>
 #include <linux/nmi.h>
 
-#include <asm/asm-prototypes.h>
 #include <asm/asm.h>
+#include <asm/asm-prototypes.h>
 #include <asm/bootinfo.h>
 #include <asm/cpu.h>
 #include <asm/elf.h>

---
base-commit: e43b8bb56e537bfc8d9076793091e7679020fc9c
change-id: 20250506-loongarch_include_order-bbf509faca15
-- 
- Charlie

Re: [PATCH core/entry] LoongArch: Fix include order

Posted by Huacai Chen 7 months, 1 week ago

Hi, Charlie,

On Wed, May 7, 2025 at 3:11 PM Charlie Jenkins <charlie@rivosinc.com> wrote:
>
> Reorder some introduced include headers to keep alphabetical order.
>
> Signed-off-by: Charlie Jenkins <charlie@rivosinc.com>
> Fixes: 7ace1602abf2 ("LoongArch: entry: Migrate ret_from_fork() to C")
> ---
> This is a very minor fix to a patch previously applied to the core/entry
> tip.
If possible, I prefer it to be squashed to the original patch.

Huacai

> ---
>  arch/loongarch/kernel/process.c | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/arch/loongarch/kernel/process.c b/arch/loongarch/kernel/process.c
> index 98bc60d7c550fcc0225e8452f81a7d6cd7888015..3582f591bab286c30127e715c47d485f74d5e2ca 100644
> --- a/arch/loongarch/kernel/process.c
> +++ b/arch/loongarch/kernel/process.c
> @@ -13,8 +13,8 @@
>  #include <linux/cpu.h>
>  #include <linux/init.h>
>  #include <linux/kernel.h>
> -#include <linux/errno.h>
>  #include <linux/entry-common.h>
> +#include <linux/errno.h>
>  #include <linux/sched.h>
>  #include <linux/sched/debug.h>
>  #include <linux/sched/task.h>
> @@ -34,8 +34,8 @@
>  #include <linux/prctl.h>
>  #include <linux/nmi.h>
>
> -#include <asm/asm-prototypes.h>
>  #include <asm/asm.h>
> +#include <asm/asm-prototypes.h>
>  #include <asm/bootinfo.h>
>  #include <asm/cpu.h>
>  #include <asm/elf.h>
>
> ---
> base-commit: e43b8bb56e537bfc8d9076793091e7679020fc9c
> change-id: 20250506-loongarch_include_order-bbf509faca15
> --
> - Charlie
>

Re: [PATCH core/entry] LoongArch: Fix include order

Posted by Thomas Gleixner 7 months, 1 week ago

On Wed, May 07 2025 at 15:26, Huacai Chen wrote:
> On Wed, May 7, 2025 at 3:11 PM Charlie Jenkins <charlie@rivosinc.com> wrote:
>>
>> Reorder some introduced include headers to keep alphabetical order.
>>
>> Signed-off-by: Charlie Jenkins <charlie@rivosinc.com>
>> Fixes: 7ace1602abf2 ("LoongArch: entry: Migrate ret_from_fork() to C")
>> ---
>> This is a very minor fix to a patch previously applied to the core/entry
>> tip.
> If possible, I prefer it to be squashed to the original patch.

The branch is immutable. It's fine to have it on top.

[tip: core/entry] LoongArch: entry: Fix include order

Posted by tip-bot2 for Charlie Jenkins 7 months, 1 week ago

The following commit has been merged into the core/entry branch of tip:

Commit-ID:     8278fd6006a02e3352d5230927c4576f53fb3b06
Gitweb:        https://git.kernel.org/tip/8278fd6006a02e3352d5230927c4576f53fb3b06
Author:        Charlie Jenkins <charlie@rivosinc.com>
AuthorDate:    Wed, 07 May 2025 00:11:30 -07:00
Committer:     Thomas Gleixner <tglx@linutronix.de>
CommitterDate: Wed, 07 May 2025 11:05:57 +02:00

LoongArch: entry: Fix include order

Reorder some introduced include headers to keep alphabetical order.

Fixes: 7ace1602abf2 ("LoongArch: entry: Migrate ret_from_fork() to C")
Signed-off-by: Charlie Jenkins <charlie@rivosinc.com>
Signed-off-by: Thomas Gleixner <tglx@linutronix.de>
Link: https://lore.kernel.org/all/20250507-loongarch_include_order-v1-1-e8aada6a3da8@rivosinc.com
---
 arch/loongarch/kernel/process.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/arch/loongarch/kernel/process.c b/arch/loongarch/kernel/process.c
index 98bc60d..3582f59 100644
--- a/arch/loongarch/kernel/process.c
+++ b/arch/loongarch/kernel/process.c
@@ -13,8 +13,8 @@
 #include <linux/cpu.h>
 #include <linux/init.h>
 #include <linux/kernel.h>
-#include <linux/errno.h>
 #include <linux/entry-common.h>
+#include <linux/errno.h>
 #include <linux/sched.h>
 #include <linux/sched/debug.h>
 #include <linux/sched/task.h>
@@ -34,8 +34,8 @@
 #include <linux/prctl.h>
 #include <linux/nmi.h>
 
-#include <asm/asm-prototypes.h>
 #include <asm/asm.h>
+#include <asm/asm-prototypes.h>
 #include <asm/bootinfo.h>
 #include <asm/cpu.h>
 #include <asm/elf.h>