[PATCH] dt-bindings: serial: Convert socionext,milbeaut-usio-uart to DT schema

Rob Herring (Arm) posted 1 patch 7 months, 1 week ago
There is a newer version of this series
.../bindings/serial/milbeaut-uart.txt         | 21 -------
.../serial/socionext,milbeaut-usio-uart.yaml  | 56 +++++++++++++++++++
2 files changed, 56 insertions(+), 21 deletions(-)
delete mode 100644 Documentation/devicetree/bindings/serial/milbeaut-uart.txt
create mode 100644 Documentation/devicetree/bindings/serial/socionext,milbeaut-usio-uart.yaml
[PATCH] dt-bindings: serial: Convert socionext,milbeaut-usio-uart to DT schema
Posted by Rob Herring (Arm) 7 months, 1 week ago
Convert the Socionext Milbeaut UART binding to DT schema. It is a
straight-forward conversion.

Signed-off-by: Rob Herring (Arm) <robh@kernel.org>
---
 .../bindings/serial/milbeaut-uart.txt         | 21 -------
 .../serial/socionext,milbeaut-usio-uart.yaml  | 56 +++++++++++++++++++
 2 files changed, 56 insertions(+), 21 deletions(-)
 delete mode 100644 Documentation/devicetree/bindings/serial/milbeaut-uart.txt
 create mode 100644 Documentation/devicetree/bindings/serial/socionext,milbeaut-usio-uart.yaml

diff --git a/Documentation/devicetree/bindings/serial/milbeaut-uart.txt b/Documentation/devicetree/bindings/serial/milbeaut-uart.txt
deleted file mode 100644
index 3d2fb1a7ba94..000000000000
--- a/Documentation/devicetree/bindings/serial/milbeaut-uart.txt
+++ /dev/null
@@ -1,21 +0,0 @@
-Socionext Milbeaut UART controller
-
-Required properties:
-- compatible: should be "socionext,milbeaut-usio-uart".
-- reg: offset and length of the register set for the device.
-- interrupts: two interrupts specifier.
-- interrupt-names: should be "rx", "tx".
-- clocks: phandle to the input clock.
-
-Optional properties:
-- auto-flow-control: flow control enable.
-
-Example:
-	usio1: usio_uart@1e700010 {
-		compatible = "socionext,milbeaut-usio-uart";
-		reg = <0x1e700010 0x10>;
-		interrupts = <0 141 0x4>, <0 149 0x4>;
-		interrupt-names = "rx", "tx";
-		clocks = <&clk 2>;
-		auto-flow-control;
-	};
diff --git a/Documentation/devicetree/bindings/serial/socionext,milbeaut-usio-uart.yaml b/Documentation/devicetree/bindings/serial/socionext,milbeaut-usio-uart.yaml
new file mode 100644
index 000000000000..37db6459b67a
--- /dev/null
+++ b/Documentation/devicetree/bindings/serial/socionext,milbeaut-usio-uart.yaml
@@ -0,0 +1,56 @@
+# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause)
+%YAML 1.2
+---
+$id: http://devicetree.org/schemas/socionext,milbeaut-usio-uart.yaml#
+$schema: http://devicetree.org/meta-schemas/core.yaml#
+
+title: Socionext Milbeaut UART controller
+
+maintainers:
+  - Sugaya Taichi <sugaya.taichi@socionext.com>
+
+allOf:
+  - $ref: /schemas/serial/serial.yaml#
+
+properties:
+  compatible:
+    const: socionext,milbeaut-usio-uart
+
+  reg:
+    maxItems: 1
+
+  interrupts:
+    items:
+      - description: RX interrupt specifier
+      - description: TX interrupt specifier
+
+  interrupt-names:
+    items:
+      - const: rx
+      - const: tx
+
+  clocks:
+    maxItems: 1
+
+  auto-flow-control:
+    description: Enable automatic flow control.
+    type: boolean
+
+required:
+  - compatible
+  - reg
+  - interrupts
+  - interrupt-names
+
+unevaluatedProperties: false
+
+examples:
+  - |
+    serial@1e700010 {
+        compatible = "socionext,milbeaut-usio-uart";
+        reg = <0x1e700010 0x10>;
+        interrupts = <0 141 0x4>, <0 149 0x4>;
+        interrupt-names = "rx", "tx";
+        clocks = <&clk 2>;
+        auto-flow-control;
+    };
-- 
2.47.2
Re: [PATCH] dt-bindings: serial: Convert socionext,milbeaut-usio-uart to DT schema
Posted by Rob Herring 7 months, 1 week ago
On Tue, May 6, 2025 at 5:00 PM Rob Herring (Arm) <robh@kernel.org> wrote:
>
> Convert the Socionext Milbeaut UART binding to DT schema. It is a
> straight-forward conversion.
>
> Signed-off-by: Rob Herring (Arm) <robh@kernel.org>
> ---
>  .../bindings/serial/milbeaut-uart.txt         | 21 -------
>  .../serial/socionext,milbeaut-usio-uart.yaml  | 56 +++++++++++++++++++
>  2 files changed, 56 insertions(+), 21 deletions(-)
>  delete mode 100644 Documentation/devicetree/bindings/serial/milbeaut-uart.txt
>  create mode 100644 Documentation/devicetree/bindings/serial/socionext,milbeaut-usio-uart.yaml
>
> diff --git a/Documentation/devicetree/bindings/serial/milbeaut-uart.txt b/Documentation/devicetree/bindings/serial/milbeaut-uart.txt
> deleted file mode 100644
> index 3d2fb1a7ba94..000000000000
> --- a/Documentation/devicetree/bindings/serial/milbeaut-uart.txt
> +++ /dev/null
> @@ -1,21 +0,0 @@
> -Socionext Milbeaut UART controller
> -
> -Required properties:
> -- compatible: should be "socionext,milbeaut-usio-uart".
> -- reg: offset and length of the register set for the device.
> -- interrupts: two interrupts specifier.
> -- interrupt-names: should be "rx", "tx".
> -- clocks: phandle to the input clock.
> -
> -Optional properties:
> -- auto-flow-control: flow control enable.
> -
> -Example:
> -       usio1: usio_uart@1e700010 {
> -               compatible = "socionext,milbeaut-usio-uart";
> -               reg = <0x1e700010 0x10>;
> -               interrupts = <0 141 0x4>, <0 149 0x4>;
> -               interrupt-names = "rx", "tx";
> -               clocks = <&clk 2>;
> -               auto-flow-control;
> -       };
> diff --git a/Documentation/devicetree/bindings/serial/socionext,milbeaut-usio-uart.yaml b/Documentation/devicetree/bindings/serial/socionext,milbeaut-usio-uart.yaml
> new file mode 100644
> index 000000000000..37db6459b67a
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/serial/socionext,milbeaut-usio-uart.yaml
> @@ -0,0 +1,56 @@
> +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause)
> +%YAML 1.2
> +---
> +$id: http://devicetree.org/schemas/socionext,milbeaut-usio-uart.yaml#

This is missing 'serial' in the path, so a v2 is coming.

The tooling didn't catch this as it doesn't know what the root
directory (bindings) is until a reference is used and the reference
checking happened to miss this case. I've now fixed that.

Rob
Re: [PATCH] dt-bindings: serial: Convert socionext,milbeaut-usio-uart to DT schema
Posted by Thierry Reding 7 months, 1 week ago
On Tue, May 06, 2025 at 05:00:37PM -0500, Rob Herring (Arm) wrote:
> Convert the Socionext Milbeaut UART binding to DT schema. It is a
> straight-forward conversion.
> 
> Signed-off-by: Rob Herring (Arm) <robh@kernel.org>
> ---
>  .../bindings/serial/milbeaut-uart.txt         | 21 -------
>  .../serial/socionext,milbeaut-usio-uart.yaml  | 56 +++++++++++++++++++
>  2 files changed, 56 insertions(+), 21 deletions(-)
>  delete mode 100644 Documentation/devicetree/bindings/serial/milbeaut-uart.txt
>  create mode 100644 Documentation/devicetree/bindings/serial/socionext,milbeaut-usio-uart.yaml

Reviewed-by: Thierry Reding <treding@nvidia.com>