[v2] media: platform: cros-ec: Add Dirks to the match table

[PATCH] [v2] media: platform: cros-ec: Add Dirks to the match table

Posted by Kells Ping 7 months, 1 week ago

The Google Dirks device uses the same approach as the Google Brask
which enables the HDMI CEC via the cros-ec-cec driver.

---

Changes in v2: update ports
native driver cec is port 0.
bitbang driver cec is port 1.

Signed-off-by: Kells Ping <kells.ping@quanta.corp-partner.google.com>
---
 drivers/media/cec/platform/cros-ec/cros-ec-cec.c | 3 +++
 1 file changed, 3 insertions(+)

diff --git a/drivers/media/cec/platform/cros-ec/cros-ec-cec.c b/drivers/media/cec/platform/cros-ec/cros-ec-cec.c
index 12b73ea0f31d..81b4524c69f4 100644
--- a/drivers/media/cec/platform/cros-ec/cros-ec-cec.c
+++ b/drivers/media/cec/platform/cros-ec/cros-ec-cec.c
@@ -298,6 +298,7 @@ struct cec_dmi_match {
 static const char *const port_b_conns[] = { "Port B", NULL };
 static const char *const port_db_conns[] = { "Port D", "Port B", NULL };
 static const char *const port_ba_conns[] = { "Port B", "Port A", NULL };
+static const char *const port_ab_conns[] = { "Port A", "Port B", NULL };
 static const char *const port_d_conns[] = { "Port D", NULL };
 
 static const struct cec_dmi_match cec_dmi_match_table[] = {
@@ -329,6 +330,8 @@ static const struct cec_dmi_match cec_dmi_match_table[] = {
 	{ "Google", "Dexi", "0000:00:02.0", port_db_conns },
 	/* Google Dita */
 	{ "Google", "Dita", "0000:00:02.0", port_db_conns },
+	/* Google Dirks */
+	{ "Google", "Dirks", "0000:00:02.0", port_ab_conns },
 };
 
 static struct device *cros_ec_cec_find_hdmi_dev(struct device *dev,
-- 
2.34.1

Re: [PATCH] [v2] media: platform: cros-ec: Add Dirks to the match table

Posted by Hans Verkuil 7 months, 1 week ago

Hi Kells,

On 5/6/25 10:43, Kells Ping wrote:
> The Google Dirks device uses the same approach as the Google Brask
> which enables the HDMI CEC via the cros-ec-cec driver.

The v1 patch has already been merged here:

https://gitlab.freedesktop.org/linux-media/media-committers

Can you post a v3 with just the diff between v1 and v2?

Regards,

	Hans

> 
> ---
> 
> Changes in v2: update ports
> native driver cec is port 0.
> bitbang driver cec is port 1.
> 
> Signed-off-by: Kells Ping <kells.ping@quanta.corp-partner.google.com>
> ---
>  drivers/media/cec/platform/cros-ec/cros-ec-cec.c | 3 +++
>  1 file changed, 3 insertions(+)
> 
> diff --git a/drivers/media/cec/platform/cros-ec/cros-ec-cec.c b/drivers/media/cec/platform/cros-ec/cros-ec-cec.c
> index 12b73ea0f31d..81b4524c69f4 100644
> --- a/drivers/media/cec/platform/cros-ec/cros-ec-cec.c
> +++ b/drivers/media/cec/platform/cros-ec/cros-ec-cec.c
> @@ -298,6 +298,7 @@ struct cec_dmi_match {
>  static const char *const port_b_conns[] = { "Port B", NULL };
>  static const char *const port_db_conns[] = { "Port D", "Port B", NULL };
>  static const char *const port_ba_conns[] = { "Port B", "Port A", NULL };
> +static const char *const port_ab_conns[] = { "Port A", "Port B", NULL };
>  static const char *const port_d_conns[] = { "Port D", NULL };
>  
>  static const struct cec_dmi_match cec_dmi_match_table[] = {
> @@ -329,6 +330,8 @@ static const struct cec_dmi_match cec_dmi_match_table[] = {
>  	{ "Google", "Dexi", "0000:00:02.0", port_db_conns },
>  	/* Google Dita */
>  	{ "Google", "Dita", "0000:00:02.0", port_db_conns },
> +	/* Google Dirks */
> +	{ "Google", "Dirks", "0000:00:02.0", port_ab_conns },
>  };
>  
>  static struct device *cros_ec_cec_find_hdmi_dev(struct device *dev,