[v1] watchdog: apple: set max_hw_heartbeat_ms instead of max_timeout

[PATCH] watchdog: apple: set max_hw_heartbeat_ms instead of max_timeout

Florian Klink posted 1 patch 7 months, 1 week ago

Diff against v2
Download mbox

There is a newer version of this series

drivers/watchdog/apple_wdt.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

Expand all Fold all

[PATCH] watchdog: apple: set max_hw_heartbeat_ms instead of max_timeout

Posted by Florian Klink 7 months, 1 week ago

The hardware only supports timeouts slightly below 3mins, but by using
max_hw_heartbeat_ms we can let the kernel take care of supporting larger
timeouts than that requested from userspace.

Signed-off-by: Florian Klink <flokli@flokli.de>
---
 drivers/watchdog/apple_wdt.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/watchdog/apple_wdt.c b/drivers/watchdog/apple_wdt.c
index 95d9e37df41c..6088a7554312 100644
--- a/drivers/watchdog/apple_wdt.c
+++ b/drivers/watchdog/apple_wdt.c
@@ -177,7 +177,7 @@ static int apple_wdt_probe(struct platform_device *pdev)
 
 	wdt->wdd.ops = &apple_wdt_ops;
 	wdt->wdd.info = &apple_wdt_info;
-	wdt->wdd.max_timeout = U32_MAX / wdt->clk_rate;
+	wdt->wdd.max_hw_heartbeat_ms = U32_MAX / wdt->clk_rate * 1000;
 	wdt->wdd.timeout = APPLE_WDT_TIMEOUT_DEFAULT;
 
 	wdt_ctrl = readl_relaxed(wdt->regs + APPLE_WDT_WD1_CTRL);
-- 
2.49.0

Re: [PATCH] watchdog: apple: set max_hw_heartbeat_ms instead of max_timeout

Posted by Guenter Roeck 7 months, 1 week ago

On 5/6/25 05:01, Florian Klink wrote:
> The hardware only supports timeouts slightly below 3mins, but by using
> max_hw_heartbeat_ms we can let the kernel take care of supporting larger
> timeouts than that requested from userspace.
> 
> Signed-off-by: Florian Klink <flokli@flokli.de>

Reviewed-by: Guenter Roeck <linux@roeck-us.net>