[PATCH v2 1/2] arch: arm: dts: nvidia: tegra20,30: Rename the apbdma nodename to match with common dma-controller binding

Charan Pedumuru posted 2 patches 7 months, 2 weeks ago
There is a newer version of this series
[PATCH v2 1/2] arch: arm: dts: nvidia: tegra20,30: Rename the apbdma nodename to match with common dma-controller binding
Posted by Charan Pedumuru 7 months, 2 weeks ago
Rename the apbdma nodename from "dma@" to "dma-controller@" to align with
linux common dma-controller binding.

Signed-off-by: Charan Pedumuru <charan.pedumuru@gmail.com>
---
 arch/arm/boot/dts/nvidia/tegra20.dtsi | 2 +-
 arch/arm/boot/dts/nvidia/tegra30.dtsi | 2 +-
 2 files changed, 2 insertions(+), 2 deletions(-)

diff --git a/arch/arm/boot/dts/nvidia/tegra20.dtsi b/arch/arm/boot/dts/nvidia/tegra20.dtsi
index 8da75ccc44025bf2978141082332b78bf94c38a9..882adb7f2f26392db2be386b0a936453fc839049 100644
--- a/arch/arm/boot/dts/nvidia/tegra20.dtsi
+++ b/arch/arm/boot/dts/nvidia/tegra20.dtsi
@@ -284,7 +284,7 @@ flow-controller@60007000 {
 		reg = <0x60007000 0x1000>;
 	};
 
-	apbdma: dma@6000a000 {
+	apbdma: dma-controller@6000a000 {
 		compatible = "nvidia,tegra20-apbdma";
 		reg = <0x6000a000 0x1200>;
 		interrupts = <GIC_SPI 104 IRQ_TYPE_LEVEL_HIGH>,
diff --git a/arch/arm/boot/dts/nvidia/tegra30.dtsi b/arch/arm/boot/dts/nvidia/tegra30.dtsi
index f866fa7b55a509a0f66d3e49456565df0d74a678..2a4d93db81347e3e1dd942e6c10a1ff5683402e7 100644
--- a/arch/arm/boot/dts/nvidia/tegra30.dtsi
+++ b/arch/arm/boot/dts/nvidia/tegra30.dtsi
@@ -431,7 +431,7 @@ flow-controller@60007000 {
 		reg = <0x60007000 0x1000>;
 	};
 
-	apbdma: dma@6000a000 {
+	apbdma: dma-controller@6000a000 {
 		compatible = "nvidia,tegra30-apbdma", "nvidia,tegra20-apbdma";
 		reg = <0x6000a000 0x1400>;
 		interrupts = <GIC_SPI 104 IRQ_TYPE_LEVEL_HIGH>,

-- 
2.43.0
Re: [PATCH v2 1/2] arch: arm: dts: nvidia: tegra20,30: Rename the apbdma nodename to match with common dma-controller binding
Posted by Krzysztof Kozlowski 7 months, 2 weeks ago
On 06/05/2025 09:07, Charan Pedumuru wrote:
> Rename the apbdma nodename from "dma@" to "dma-controller@" to align with
> linux common dma-controller binding.
> 
> Signed-off-by: Charan Pedumuru <charan.pedumuru@gmail.com>
if there is going to be resend, then subject: drop arch

Please use subject prefixes matching the subsystem. You can get them for
example with `git log --oneline -- DIRECTORY_OR_FILE` on the directory
your patch is touching. For bindings, the preferred subjects are
explained here:
https://www.kernel.org/doc/html/latest/devicetree/bindings/submitting-patches.html#i-for-patch-submitters

Reviewed-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>

Best regards,
Krzysztof
Re: [PATCH v2 1/2] arch: arm: dts: nvidia: tegra20,30: Rename the apbdma nodename to match with common dma-controller binding
Posted by Charan Pedumuru 7 months, 2 weeks ago

On 06-05-2025 12:57, Krzysztof Kozlowski wrote:
> On 06/05/2025 09:07, Charan Pedumuru wrote:
>> Rename the apbdma nodename from "dma@" to "dma-controller@" to align with
>> linux common dma-controller binding.
>>
>> Signed-off-by: Charan Pedumuru <charan.pedumuru@gmail.com>
> if there is going to be resend, then subject: drop arch

Sure.

> 
> Please use subject prefixes matching the subsystem. You can get them for
> example with `git log --oneline -- DIRECTORY_OR_FILE` on the directory
> your patch is touching. For bindings, the preferred subjects are
> explained here:
> https://www.kernel.org/doc/html/latest/devicetree/bindings/submitting-patches.html#i-for-patch-submitters
> 
> Reviewed-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
> 
> Best regards,
> Krzysztof

-- 
Best Regards,
Charan.