[PATCH v3 0/2] Add support for the DFRobot SEN0322 oxygen sensor

Tóth János via B4 Relay posted 2 patches 7 months, 1 week ago
There is a newer version of this series
.../devicetree/bindings/trivial-devices.yaml       |   2 +
MAINTAINERS                                        |   6 +
drivers/iio/chemical/Kconfig                       |  10 ++
drivers/iio/chemical/Makefile                      |   1 +
drivers/iio/chemical/sen0322.c                     | 163 +++++++++++++++++++++
5 files changed, 182 insertions(+)
[PATCH v3 0/2] Add support for the DFRobot SEN0322 oxygen sensor
Posted by Tóth János via B4 Relay 7 months, 1 week ago
This patchset adds a driver and the documentation for the
DFRobot SEN0322 oxygen sensor.

Signed-off-by: Tóth János <gomba007@gmail.com>
---
Changes in v3:
- Refactor based on reviewer's suggestions.
- Link to v2: https://lore.kernel.org/r/20250505-iio-chemical-sen0322-v2-0-217473983b42@gmail.com

Changes in v2:
- Add SEN0322 to trivial-devices.
- Use _RAW and _SCALE instead of fixed-point math.
- Refactor based on reviewer's suggestions.
- Link to v1: https://lore.kernel.org/r/20250428-iio-chemical-sen0322-v1-0-9b18363ffe42@gmail.com

---
Tóth János (2):
      dt-bindings: trivial-devices: Document SEN0322
      iio: chemical: Add driver for SEN0322

 .../devicetree/bindings/trivial-devices.yaml       |   2 +
 MAINTAINERS                                        |   6 +
 drivers/iio/chemical/Kconfig                       |  10 ++
 drivers/iio/chemical/Makefile                      |   1 +
 drivers/iio/chemical/sen0322.c                     | 163 +++++++++++++++++++++
 5 files changed, 182 insertions(+)
---
base-commit: b4432656b36e5cc1d50a1f2dc15357543add530e
change-id: 20250428-iio-chemical-sen0322-cf8fbbbe7546

Best regards,
-- 
Tóth János <gomba007@gmail.com>


Re: [PATCH v3 0/2] Add support for the DFRobot SEN0322 oxygen sensor
Posted by Krzysztof Kozlowski 7 months, 1 week ago
On 06/05/2025 10:53, Tóth János via B4 Relay wrote:
> This patchset adds a driver and the documentation for the
> DFRobot SEN0322 oxygen sensor.
> 
> Signed-off-by: Tóth János <gomba007@gmail.com>
> ---
> Changes in v3:
> - Refactor based on reviewer's suggestions.

What exactly changed? I do not see any changes in the binding but you
decided to drop my review tag.


<form letter>
This is a friendly reminder during the review process.

It looks like you received a tag and forgot to add it.

If you do not know the process, here is a short explanation:
Please add Acked-by/Reviewed-by/Tested-by tags when posting new versions
of patchset, under or above your Signed-off-by tag, unless patch changed
significantly (e.g. new properties added to the DT bindings). Tag is
"received", when provided in a message replied to you on the mailing
list. Tools like b4 can help here. However, there's no need to repost
patches *only* to add the tags. The upstream maintainer will do that for
tags received on the version they apply.

Please read:
https://elixir.bootlin.com/linux/v6.12-rc3/source/Documentation/process/submitting-patches.rst#L577

If a tag was not added on purpose, please state why and what changed.
</form letter>

Best regards,
Krzysztof
Re: [PATCH v3 0/2] Add support for the DFRobot SEN0322 oxygen sensor
Posted by Tóth János 7 months, 1 week ago
Hi!

> What exactly changed? I do not see any changes in the binding but you
> decided to drop my review tag.

Sorry, my bad. I've fixed it in v4.

Regards,
János