[PATCH 1/4] dt-bindings: mfd: mediatek: mt6397: Add #sound-dai-cells property

Julien Massot posted 4 patches 9 months, 1 week ago
There is a newer version of this series
[PATCH 1/4] dt-bindings: mfd: mediatek: mt6397: Add #sound-dai-cells property
Posted by Julien Massot 9 months, 1 week ago
The 'mt6359.dtsi' file already uses the '#sound-dai-cells' property.
Add the corresponding property to the binding to fix the following
dtb-check error:

mediatek/mt8395-radxa-nio-12l.dtb: pmic: '#sound-dai-cells', 'mt6359rtc' do not match any of the regexes: 'pinctrl-[0-9]+'
from schema $id: http://devicetree.org/schemas/mfd/mediatek,mt6397.yaml#

Fixes: 9bc8353be720 ("arm64: dts: mt6359: Add #sound-dai-cells property")
Signed-off-by: Julien Massot <julien.massot@collabora.com>
---
 Documentation/devicetree/bindings/mfd/mediatek,mt6397.yaml | 3 +++
 1 file changed, 3 insertions(+)

diff --git a/Documentation/devicetree/bindings/mfd/mediatek,mt6397.yaml b/Documentation/devicetree/bindings/mfd/mediatek,mt6397.yaml
index 6a89b479d10fad3c8b61cab5a3af1453baca4d1a..86fc1b5db3b075ea0f6e35f58ecbca7956d230c4 100644
--- a/Documentation/devicetree/bindings/mfd/mediatek,mt6397.yaml
+++ b/Documentation/devicetree/bindings/mfd/mediatek,mt6397.yaml
@@ -53,6 +53,9 @@ properties:
   "#interrupt-cells":
     const: 2
 
+  '#sound-dai-cells':
+    const: 1
+
   rtc:
     type: object
     $ref: /schemas/rtc/rtc.yaml#

-- 
2.49.0
Re: [PATCH 1/4] dt-bindings: mfd: mediatek: mt6397: Add #sound-dai-cells property
Posted by Krzysztof Kozlowski 9 months ago
On 05/05/2025 15:23, Julien Massot wrote:
> The 'mt6359.dtsi' file already uses the '#sound-dai-cells' property.
> Add the corresponding property to the binding to fix the following
> dtb-check error:
If this is a DAI, then you miss dai-common reference. If not, you need
to explain it in commit msg.

Best regards,
Krzysztof
Re: [PATCH 1/4] dt-bindings: mfd: mediatek: mt6397: Add #sound-dai-cells property
Posted by Julien Massot 9 months ago
Hi Krzysztof,

On Thu, 2025-05-08 at 08:01 +0200, Krzysztof Kozlowski wrote:
> On 05/05/2025 15:23, Julien Massot wrote:
> > The 'mt6359.dtsi' file already uses the '#sound-dai-cells' property.
> > Add the corresponding property to the binding to fix the following
> > dtb-check error:
> If this is a DAI, then you miss dai-common reference. If not, you need
> to explain it in commit msg.

Thanks for the review, I will add the missing dai-common reference in the v2.

Regards,
Julien
Re: [PATCH 1/4] dt-bindings: mfd: mediatek: mt6397: Add #sound-dai-cells property
Posted by Nícolas F. R. A. Prado 9 months, 1 week ago
On Mon, May 05, 2025 at 03:23:37PM +0200, Julien Massot wrote:
> The 'mt6359.dtsi' file already uses the '#sound-dai-cells' property.
> Add the corresponding property to the binding to fix the following
> dtb-check error:
> 
> mediatek/mt8395-radxa-nio-12l.dtb: pmic: '#sound-dai-cells', 'mt6359rtc' do not match any of the regexes: 'pinctrl-[0-9]+'
> from schema $id: http://devicetree.org/schemas/mfd/mediatek,mt6397.yaml#
> 
> Fixes: 9bc8353be720 ("arm64: dts: mt6359: Add #sound-dai-cells property")
> Signed-off-by: Julien Massot <julien.massot@collabora.com>

Reviewed-by: Nícolas F. R. A. Prado <nfraprado@collabora.com>

Thanks,
Nícolas
Re: [PATCH 1/4] dt-bindings: mfd: mediatek: mt6397: Add #sound-dai-cells property
Posted by AngeloGioacchino Del Regno 9 months, 1 week ago
Il 05/05/25 15:23, Julien Massot ha scritto:
> The 'mt6359.dtsi' file already uses the '#sound-dai-cells' property.
> Add the corresponding property to the binding to fix the following
> dtb-check error:
> 
> mediatek/mt8395-radxa-nio-12l.dtb: pmic: '#sound-dai-cells', 'mt6359rtc' do not match any of the regexes: 'pinctrl-[0-9]+'
> from schema $id: http://devicetree.org/schemas/mfd/mediatek,mt6397.yaml#
> 
> Fixes: 9bc8353be720 ("arm64: dts: mt6359: Add #sound-dai-cells property")
> Signed-off-by: Julien Massot <julien.massot@collabora.com>

Reviewed-by: AngeloGioacchino Del Regno <angelogioacchino.delregno@collabora.com>