[PATCH 00/14] iio: remove bits_per_word = 8 assignments

David Lechner posted 14 patches 7 months, 2 weeks ago
drivers/iio/adc/ad4030.c               | 4 ----
drivers/iio/adc/ti-tsc2046.c           | 1 -
drivers/iio/chemical/bme680_spi.c      | 8 --------
drivers/iio/dac/ad5761.c               | 2 --
drivers/iio/dac/ad5766.c               | 2 --
drivers/iio/dac/ad5791.c               | 2 --
drivers/iio/dac/ltc2688.c              | 2 --
drivers/iio/gyro/adxrs450.c            | 5 -----
drivers/iio/imu/adis.c                 | 9 ---------
drivers/iio/imu/adis_buffer.c          | 3 ---
drivers/iio/magnetometer/hmc5843_spi.c | 1 -
drivers/iio/magnetometer/rm3100-spi.c  | 1 -
drivers/iio/pressure/bmp280-spi.c      | 8 --------
drivers/iio/pressure/ms5611_spi.c      | 1 -
drivers/iio/pressure/zpa2326_spi.c     | 1 -
15 files changed, 50 deletions(-)
[PATCH 00/14] iio: remove bits_per_word = 8 assignments
Posted by David Lechner 7 months, 2 weeks ago
While grepping the IIO subsystem for drivers that set bits_per_word to
unusual values to check for potential bugs, I found it to be a bit of a
nuisance that 2/3s of the matches were setting it to the default value
of 8. So here is a series removing the unnecessary assignments.

---
David Lechner (14):
      iio: adc: ad4030: remove bits_per_word = 8
      iio: adc: ti-tsc2046: remove bits_per_word = 8
      iio: chemical: bme680_spi: remove bits_per_word = 8
      iio: dac: ad5761: remove bits_per_word = 8
      iio: dac: ad5766: remove bits_per_word = 8
      iio: dac: ad5791: remove bits_per_word = 8
      iio: dac: ltc2688: remove bits_per_word = 8
      iio: gyro: adxrs450: remove bits_per_word = 8
      iio: imu: adis: remove bits_per_word = 8
      iio: magnetometer: hmc5843_spi: remove bits_per_word = 8
      iio: magnetometer: rm3100-spi: remove bits_per_word = 8
      iio: pressure: bmp280-spi: remove bits_per_word = 8
      iio: pressure: ms5611_spi: remove bits_per_word = 8
      iio: pressure: zpa2326_spi: remove bits_per_word = 8

 drivers/iio/adc/ad4030.c               | 4 ----
 drivers/iio/adc/ti-tsc2046.c           | 1 -
 drivers/iio/chemical/bme680_spi.c      | 8 --------
 drivers/iio/dac/ad5761.c               | 2 --
 drivers/iio/dac/ad5766.c               | 2 --
 drivers/iio/dac/ad5791.c               | 2 --
 drivers/iio/dac/ltc2688.c              | 2 --
 drivers/iio/gyro/adxrs450.c            | 5 -----
 drivers/iio/imu/adis.c                 | 9 ---------
 drivers/iio/imu/adis_buffer.c          | 3 ---
 drivers/iio/magnetometer/hmc5843_spi.c | 1 -
 drivers/iio/magnetometer/rm3100-spi.c  | 1 -
 drivers/iio/pressure/bmp280-spi.c      | 8 --------
 drivers/iio/pressure/ms5611_spi.c      | 1 -
 drivers/iio/pressure/zpa2326_spi.c     | 1 -
 15 files changed, 50 deletions(-)
---
base-commit: 7e9a82ab5b861d3c33c99a22c1245a5b262ee502
change-id: 20250505-iio-remove-bits_per_word-8-db80654b1c17

Best regards,
-- 
David Lechner <dlechner@baylibre.com>
Re: [PATCH 00/14] iio: remove bits_per_word = 8 assignments
Posted by Nuno Sá 7 months, 1 week ago
On Mon, 2025-05-05 at 14:20 -0500, David Lechner wrote:
> While grepping the IIO subsystem for drivers that set bits_per_word to
> unusual values to check for potential bugs, I found it to be a bit of a
> nuisance that 2/3s of the matches were setting it to the default value
> of 8. So here is a series removing the unnecessary assignments.
> 
> ---

LGTM,

Reviewed-by: Nuno Sá <nuno.sa@analog.com>

> David Lechner (14):
>       iio: adc: ad4030: remove bits_per_word = 8
>       iio: adc: ti-tsc2046: remove bits_per_word = 8
>       iio: chemical: bme680_spi: remove bits_per_word = 8
>       iio: dac: ad5761: remove bits_per_word = 8
>       iio: dac: ad5766: remove bits_per_word = 8
>       iio: dac: ad5791: remove bits_per_word = 8
>       iio: dac: ltc2688: remove bits_per_word = 8
>       iio: gyro: adxrs450: remove bits_per_word = 8
>       iio: imu: adis: remove bits_per_word = 8
>       iio: magnetometer: hmc5843_spi: remove bits_per_word = 8
>       iio: magnetometer: rm3100-spi: remove bits_per_word = 8
>       iio: pressure: bmp280-spi: remove bits_per_word = 8
>       iio: pressure: ms5611_spi: remove bits_per_word = 8
>       iio: pressure: zpa2326_spi: remove bits_per_word = 8
> 
>  drivers/iio/adc/ad4030.c               | 4 ----
>  drivers/iio/adc/ti-tsc2046.c           | 1 -
>  drivers/iio/chemical/bme680_spi.c      | 8 --------
>  drivers/iio/dac/ad5761.c               | 2 --
>  drivers/iio/dac/ad5766.c               | 2 --
>  drivers/iio/dac/ad5791.c               | 2 --
>  drivers/iio/dac/ltc2688.c              | 2 --
>  drivers/iio/gyro/adxrs450.c            | 5 -----
>  drivers/iio/imu/adis.c                 | 9 ---------
>  drivers/iio/imu/adis_buffer.c          | 3 ---
>  drivers/iio/magnetometer/hmc5843_spi.c | 1 -
>  drivers/iio/magnetometer/rm3100-spi.c  | 1 -
>  drivers/iio/pressure/bmp280-spi.c      | 8 --------
>  drivers/iio/pressure/ms5611_spi.c      | 1 -
>  drivers/iio/pressure/zpa2326_spi.c     | 1 -
>  15 files changed, 50 deletions(-)
> ---
> base-commit: 7e9a82ab5b861d3c33c99a22c1245a5b262ee502
> change-id: 20250505-iio-remove-bits_per_word-8-db80654b1c17
> 
> Best regards,

Re: [PATCH 00/14] iio: remove bits_per_word = 8 assignments
Posted by Jonathan Cameron 7 months, 1 week ago
On Wed, 07 May 2025 07:28:12 +0100
Nuno Sá <noname.nuno@gmail.com> wrote:

> On Mon, 2025-05-05 at 14:20 -0500, David Lechner wrote:
> > While grepping the IIO subsystem for drivers that set bits_per_word to
> > unusual values to check for potential bugs, I found it to be a bit of a
> > nuisance that 2/3s of the matches were setting it to the default value
> > of 8. So here is a series removing the unnecessary assignments.
> > 
> > ---  
> 
> LGTM,
> 
> Reviewed-by: Nuno Sá <nuno.sa@analog.com>
Applied.  Still time to comment if we missed anything though as for
now just pushed out for 0-day to poke at.

Thanks,

Jonathan

> 
> > David Lechner (14):
> >       iio: adc: ad4030: remove bits_per_word = 8
> >       iio: adc: ti-tsc2046: remove bits_per_word = 8
> >       iio: chemical: bme680_spi: remove bits_per_word = 8
> >       iio: dac: ad5761: remove bits_per_word = 8
> >       iio: dac: ad5766: remove bits_per_word = 8
> >       iio: dac: ad5791: remove bits_per_word = 8
> >       iio: dac: ltc2688: remove bits_per_word = 8
> >       iio: gyro: adxrs450: remove bits_per_word = 8
> >       iio: imu: adis: remove bits_per_word = 8
> >       iio: magnetometer: hmc5843_spi: remove bits_per_word = 8
> >       iio: magnetometer: rm3100-spi: remove bits_per_word = 8
> >       iio: pressure: bmp280-spi: remove bits_per_word = 8
> >       iio: pressure: ms5611_spi: remove bits_per_word = 8
> >       iio: pressure: zpa2326_spi: remove bits_per_word = 8
> > 
> >  drivers/iio/adc/ad4030.c               | 4 ----
> >  drivers/iio/adc/ti-tsc2046.c           | 1 -
> >  drivers/iio/chemical/bme680_spi.c      | 8 --------
> >  drivers/iio/dac/ad5761.c               | 2 --
> >  drivers/iio/dac/ad5766.c               | 2 --
> >  drivers/iio/dac/ad5791.c               | 2 --
> >  drivers/iio/dac/ltc2688.c              | 2 --
> >  drivers/iio/gyro/adxrs450.c            | 5 -----
> >  drivers/iio/imu/adis.c                 | 9 ---------
> >  drivers/iio/imu/adis_buffer.c          | 3 ---
> >  drivers/iio/magnetometer/hmc5843_spi.c | 1 -
> >  drivers/iio/magnetometer/rm3100-spi.c  | 1 -
> >  drivers/iio/pressure/bmp280-spi.c      | 8 --------
> >  drivers/iio/pressure/ms5611_spi.c      | 1 -
> >  drivers/iio/pressure/zpa2326_spi.c     | 1 -
> >  15 files changed, 50 deletions(-)
> > ---
> > base-commit: 7e9a82ab5b861d3c33c99a22c1245a5b262ee502
> > change-id: 20250505-iio-remove-bits_per_word-8-db80654b1c17
> > 
> > Best regards,  
>