[PATCH for 6.1.y] LoongArch: Fix build error due to backport

Huacai Chen posted 1 patch 9 months, 1 week ago
arch/loongarch/mm/hugetlbpage.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
[PATCH for 6.1.y] LoongArch: Fix build error due to backport
Posted by Huacai Chen 9 months, 1 week ago
In 6.1 there is no pmdp_get() definition, so use *pmd directly, in order
to avoid such build error due to a recently backport:

arch/loongarch/mm/hugetlbpage.c: In function 'huge_pte_offset':                                                                                                                
arch/loongarch/mm/hugetlbpage.c:50:25: error: implicit declaration of
function 'pmdp_get'; did you mean 'ptep_get'?
[-Wimplicit-function-declaration]                          
   50 |         return pmd_none(pmdp_get(pmd)) ? NULL : (pte_t *) pmd;                                                                                                         
      |                         ^~~~~~~~                                                                                                                                       
      |                         ptep_get                            

Signed-off-by: Huacai Chen <chenhuacai@loongson.cn>
---
 arch/loongarch/mm/hugetlbpage.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/arch/loongarch/mm/hugetlbpage.c b/arch/loongarch/mm/hugetlbpage.c
index cf3b8785a921..70b4a51885c2 100644
--- a/arch/loongarch/mm/hugetlbpage.c
+++ b/arch/loongarch/mm/hugetlbpage.c
@@ -47,7 +47,7 @@ pte_t *huge_pte_offset(struct mm_struct *mm, unsigned long addr,
 				pmd = pmd_offset(pud, addr);
 		}
 	}
-	return pmd_none(pmdp_get(pmd)) ? NULL : (pte_t *) pmd;
+	return pmd_none(*pmd) ? NULL : (pte_t *) pmd;
 }
 
 /*
-- 
2.47.1
Re: [PATCH for 6.1.y] LoongArch: Fix build error due to backport
Posted by Greg Kroah-Hartman 9 months, 1 week ago
On Sun, May 04, 2025 at 10:10:54AM +0800, Huacai Chen wrote:
> In 6.1 there is no pmdp_get() definition, so use *pmd directly, in order
> to avoid such build error due to a recently backport:
> 
> arch/loongarch/mm/hugetlbpage.c: In function 'huge_pte_offset':                                                                                                                
> arch/loongarch/mm/hugetlbpage.c:50:25: error: implicit declaration of
> function 'pmdp_get'; did you mean 'ptep_get'?
> [-Wimplicit-function-declaration]                          
>    50 |         return pmd_none(pmdp_get(pmd)) ? NULL : (pte_t *) pmd;                                                                                                         
>       |                         ^~~~~~~~                                                                                                                                       
>       |                         ptep_get                            
> 
> Signed-off-by: Huacai Chen <chenhuacai@loongson.cn>
> ---
>  arch/loongarch/mm/hugetlbpage.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/arch/loongarch/mm/hugetlbpage.c b/arch/loongarch/mm/hugetlbpage.c
> index cf3b8785a921..70b4a51885c2 100644
> --- a/arch/loongarch/mm/hugetlbpage.c
> +++ b/arch/loongarch/mm/hugetlbpage.c
> @@ -47,7 +47,7 @@ pte_t *huge_pte_offset(struct mm_struct *mm, unsigned long addr,
>  				pmd = pmd_offset(pud, addr);
>  		}
>  	}
> -	return pmd_none(pmdp_get(pmd)) ? NULL : (pte_t *) pmd;
> +	return pmd_none(*pmd) ? NULL : (pte_t *) pmd;
>  }
>  
>  /*
> -- 
> 2.47.1
> 
> 

Thanks for the fix!