[PATCH] staging: media: atomisp: fix coding style

Pablo posted 1 patch 9 months, 1 week ago
.../media/atomisp/pci/isp/kernels/vf/vf_1.0/ia_css_vf.host.c   | 3 +--
1 file changed, 1 insertion(+), 2 deletions(-)
[PATCH] staging: media: atomisp: fix coding style
Posted by Pablo 9 months, 1 week ago
Fix a coding style:
"ERROR: that open brace { should be on the previous line"
issue reported in ia_css_vf.host.c:94.

Signed-off-by: Pablo <pablo@pablo.ct.ws>
---
 Hey, this is my first patch, I apreciate any feedback, thanks!
 .../media/atomisp/pci/isp/kernels/vf/vf_1.0/ia_css_vf.host.c   | 3 +--
 1 file changed, 1 insertion(+), 2 deletions(-)

diff --git a/drivers/staging/media/atomisp/pci/isp/kernels/vf/vf_1.0/ia_css_vf.host.c b/drivers/staging/media/atomisp/pci/isp/kernels/vf/vf_1.0/ia_css_vf.host.c
index ece5e3da3..0ce75d9bd 100644
--- a/drivers/staging/media/atomisp/pci/isp/kernels/vf/vf_1.0/ia_css_vf.host.c
+++ b/drivers/staging/media/atomisp/pci/isp/kernels/vf/vf_1.0/ia_css_vf.host.c
@@ -91,8 +91,7 @@ configure_kernel(
 	unsigned int vf_log_ds = 0;
 
 	/* First compute value */
-	if (vf_info)
-	{
+	if (vf_info) {
 		err = sh_css_vf_downscale_log2(out_info, vf_info, &vf_log_ds);
 		if (err)
 			return err;
-- 
2.34.1
Re: [PATCH] staging: media: atomisp: fix coding style
Posted by Hans de Goede 7 months, 1 week ago
On 3-May-25 10:00 PM, Pablo wrote:
> Fix a coding style:
> "ERROR: that open brace { should be on the previous line"
> issue reported in ia_css_vf.host.c:94.
> 
> Signed-off-by: Pablo <pablo@pablo.ct.ws>

Thank you for your patch.

I have merged this in my media-atomisp branch:
https://git.kernel.org/pub/scm/linux/kernel/git/hansg/linux.git/log/?h=media-atomisp

And this patch will be included in my next
pull-request to Mauro (to media subsystem maintainer)

Regards,

Hans



> ---
>  Hey, this is my first patch, I apreciate any feedback, thanks!
>  .../media/atomisp/pci/isp/kernels/vf/vf_1.0/ia_css_vf.host.c   | 3 +--
>  1 file changed, 1 insertion(+), 2 deletions(-)
> 
> diff --git a/drivers/staging/media/atomisp/pci/isp/kernels/vf/vf_1.0/ia_css_vf.host.c b/drivers/staging/media/atomisp/pci/isp/kernels/vf/vf_1.0/ia_css_vf.host.c
> index ece5e3da3..0ce75d9bd 100644
> --- a/drivers/staging/media/atomisp/pci/isp/kernels/vf/vf_1.0/ia_css_vf.host.c
> +++ b/drivers/staging/media/atomisp/pci/isp/kernels/vf/vf_1.0/ia_css_vf.host.c
> @@ -91,8 +91,7 @@ configure_kernel(
>  	unsigned int vf_log_ds = 0;
>  
>  	/* First compute value */
> -	if (vf_info)
> -	{
> +	if (vf_info) {
>  		err = sh_css_vf_downscale_log2(out_info, vf_info, &vf_log_ds);
>  		if (err)
>  			return err;
Re: [PATCH] staging: media: atomisp: fix coding style
Posted by Andy Shevchenko 8 months, 3 weeks ago
On Sat, May 03, 2025 at 05:00:30PM -0300, Pablo wrote:
> Fix a coding style:
> "ERROR: that open brace { should be on the previous line"
> issue reported in ia_css_vf.host.c:94.

Hans, have you taken this change? (I miss it in Linux Next)

-- 
With Best Regards,
Andy Shevchenko