[PATCH RFC 1/4] dt-bindings: input: melfas-mip4: document linux,keycodes property

Kaustabh Chakraborty posted 4 patches 7 months, 2 weeks ago
There is a newer version of this series
[PATCH RFC 1/4] dt-bindings: input: melfas-mip4: document linux,keycodes property
Posted by Kaustabh Chakraborty 7 months, 2 weeks ago
Document the linux,keycodes property. The property values are key codes
which are used in input key events generated by the touchkey device.

Signed-off-by: Kaustabh Chakraborty <kauschluss@disroot.org>
---
 Documentation/devicetree/bindings/input/touchscreen/melfas_mip4.txt | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/Documentation/devicetree/bindings/input/touchscreen/melfas_mip4.txt b/Documentation/devicetree/bindings/input/touchscreen/melfas_mip4.txt
index b2ab5498e51900e887fab4d9b5239cccccec2ea9..16d1031ee017604ac56109dfbebfce6a05491c60 100644
--- a/Documentation/devicetree/bindings/input/touchscreen/melfas_mip4.txt
+++ b/Documentation/devicetree/bindings/input/touchscreen/melfas_mip4.txt
@@ -7,6 +7,7 @@ Required properties:
 
 Optional properties:
 - ce-gpios: GPIO connected to the CE (chip enable) pin of the chip
+- linux,keycodes: array of keycodes to be reported by touchkeys
 
 Example:
 	i2c@00000000 {
@@ -16,5 +17,6 @@ Example:
 			interrupt-parent = <&gpio>;
 			interrupts = <0 IRQ_TYPE_EDGE_FALLING>;
 			ce-gpios = <&gpio 0 GPIO_ACTIVE_HIGH>;
+			linux,keycodes = <KEY_MENU>, <KEY_BACK>;
 		};
 	};

-- 
2.49.0
Re: [PATCH RFC 1/4] dt-bindings: input: melfas-mip4: document linux,keycodes property
Posted by Rob Herring 7 months, 1 week ago
On Sat, May 03, 2025 at 02:38:27PM +0530, Kaustabh Chakraborty wrote:
> Document the linux,keycodes property. The property values are key codes
> which are used in input key events generated by the touchkey device.
> 
> Signed-off-by: Kaustabh Chakraborty <kauschluss@disroot.org>
> ---
>  Documentation/devicetree/bindings/input/touchscreen/melfas_mip4.txt | 2 ++
>  1 file changed, 2 insertions(+)

Convert to DT schema if you want to add to this.

Rob
Re: [PATCH RFC 1/4] dt-bindings: input: melfas-mip4: document linux,keycodes property
Posted by Kaustabh Chakraborty 7 months, 1 week ago
On 2025-05-09 22:06, Rob Herring wrote:
> On Sat, May 03, 2025 at 02:38:27PM +0530, Kaustabh Chakraborty wrote:
>> Document the linux,keycodes property. The property values are key codes
>> which are used in input key events generated by the touchkey device.
>> 
>> Signed-off-by: Kaustabh Chakraborty <kauschluss@disroot.org>
>> ---
>>  Documentation/devicetree/bindings/input/touchscreen/melfas_mip4.txt | 2 ++
>>  1 file changed, 2 insertions(+)
> 
> Convert to DT schema if you want to add to this.

Sure will. Who would be the maintainer of this driver though?
MAINTAINERS says that the driver is 'Supported' but Sangwon's
e-mail is bouncing.

> 
> Rob