perf trace: Show zero value in STRARRAY

[PATCH] perf trace: Show zero value in STRARRAY

Posted by Namhyung Kim 9 months, 1 week ago

The STRARRAY macro is to print values in a pre-defined array.  But
sometimes it hides the value because it's 0.  The value of 0 can have a
meaning in this case so set 'show_zero' field.

For example, it can show CREATE_MAP cmd in the bpf syscall.

Signed-off-by: Namhyung Kim <namhyung@kernel.org>
---
 tools/perf/builtin-trace.c | 6 ++++--
 1 file changed, 4 insertions(+), 2 deletions(-)

diff --git a/tools/perf/builtin-trace.c b/tools/perf/builtin-trace.c
index 83c62c30d914306c..9210ba34002b13c3 100644
--- a/tools/perf/builtin-trace.c
+++ b/tools/perf/builtin-trace.c
@@ -1123,12 +1123,14 @@ static bool syscall_arg__strtoul_btf_type(char *bf __maybe_unused, size_t size _
 #define STRARRAY(name, array) \
 	  { .scnprintf	= SCA_STRARRAY, \
 	    .strtoul	= STUL_STRARRAY, \
-	    .parm	= &strarray__##array, }
+	    .parm	= &strarray__##array, \
+	    .show_zero	= true, }
 
 #define STRARRAY_FLAGS(name, array) \
 	  { .scnprintf	= SCA_STRARRAY_FLAGS, \
 	    .strtoul	= STUL_STRARRAY_FLAGS, \
-	    .parm	= &strarray__##array, }
+	    .parm	= &strarray__##array, \
+	    .show_zero	= true, }
 
 #include "trace/beauty/eventfd.c"
 #include "trace/beauty/futex_op.c"
-- 
2.49.0.906.g1f30a19c02-goog

Re: [PATCH] perf trace: Show zero value in STRARRAY

Posted by Namhyung Kim 7 months, 2 weeks ago

On Fri, 02 May 2025 13:40:56 -0700, Namhyung Kim wrote:
> The STRARRAY macro is to print values in a pre-defined array.  But
> sometimes it hides the value because it's 0.  The value of 0 can have a
> meaning in this case so set 'show_zero' field.
> 
> For example, it can show CREATE_MAP cmd in the bpf syscall.
> 
> 
> [...]
Applied to perf-tools-next, thanks!

Best regards,
Namhyung

Re: [PATCH] perf trace: Show zero value in STRARRAY

Posted by Howard Chu 8 months, 4 weeks ago

Hello Namhyung,

On Fri, May 2, 2025 at 1:40 PM Namhyung Kim <namhyung@kernel.org> wrote:
>
> The STRARRAY macro is to print values in a pre-defined array.  But
> sometimes it hides the value because it's 0.  The value of 0 can have a
> meaning in this case so set 'show_zero' field.
>
> For example, it can show CREATE_MAP cmd in the bpf syscall.
>
> Signed-off-by: Namhyung Kim <namhyung@kernel.org>

Acked-by: Howard Chu <howardchu95@gmail.com>

Thanks,
Howard