platform/mellanox: mlxreg-dpu: add I2C dependency

[PATCH] platform/mellanox: mlxreg-dpu: add I2C dependency

Posted by Arnd Bergmann 9 months, 1 week ago

From: Arnd Bergmann <arnd@arndb.de>

REGMAP_I2C cannot be selected unless I2C is already enabled:

WARNING: unmet direct dependencies detected for REGMAP_I2C
  Depends on [n]: I2C [=n]
  Selected by [y]:
  - MLXREG_DPU [=y] && MELLANOX_PLATFORM [=y]

Fixes: 3e75f2954116 ("platform/mellanox: mlxreg-dpu: Add initial support for Nvidia DPU")
Signed-off-by: Arnd Bergmann <arnd@arndb.de>
---
 drivers/platform/mellanox/Kconfig | 1 +
 1 file changed, 1 insertion(+)

diff --git a/drivers/platform/mellanox/Kconfig b/drivers/platform/mellanox/Kconfig
index 7204b10388ca..e3afbe62c7f6 100644
--- a/drivers/platform/mellanox/Kconfig
+++ b/drivers/platform/mellanox/Kconfig
@@ -29,6 +29,7 @@ config MLX_PLATFORM
 
 config MLXREG_DPU
 	tristate "Nvidia Data Processor Unit platform driver support"
+	depends on I2C
 	select REGMAP_I2C
 	help
 	  This driver provides support for the Nvidia BF3 Data Processor Units,
-- 
2.39.5

Re: [PATCH] platform/mellanox: mlxreg-dpu: add I2C dependency

Posted by Ilpo Järvinen 9 months, 1 week ago

On Fri, 2 May 2025, Arnd Bergmann wrote:

> From: Arnd Bergmann <arnd@arndb.de>
> 
> REGMAP_I2C cannot be selected unless I2C is already enabled:
> 
> WARNING: unmet direct dependencies detected for REGMAP_I2C
>   Depends on [n]: I2C [=n]
>   Selected by [y]:
>   - MLXREG_DPU [=y] && MELLANOX_PLATFORM [=y]
> 
> Fixes: 3e75f2954116 ("platform/mellanox: mlxreg-dpu: Add initial support for Nvidia DPU")
> Signed-off-by: Arnd Bergmann <arnd@arndb.de>
> ---
>  drivers/platform/mellanox/Kconfig | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/drivers/platform/mellanox/Kconfig b/drivers/platform/mellanox/Kconfig
> index 7204b10388ca..e3afbe62c7f6 100644
> --- a/drivers/platform/mellanox/Kconfig
> +++ b/drivers/platform/mellanox/Kconfig
> @@ -29,6 +29,7 @@ config MLX_PLATFORM
>  
>  config MLXREG_DPU
>  	tristate "Nvidia Data Processor Unit platform driver support"
> +	depends on I2C
>  	select REGMAP_I2C
>  	help
>  	  This driver provides support for the Nvidia BF3 Data Processor Units,


This has been long fixed in the review-ilpo-next branch but LKP has been 
slow to build test it so the fix hasn't propagated into fox-next. I just 
pushed the changes into for-next as it seems LKP might not build that at 
all.

-- 
 i.