[PATCH] gpio: blzp1600: remove incorrect pf_match_ptr()

Arnd Bergmann posted 1 patch 9 months, 1 week ago
drivers/gpio/gpio-blzp1600.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
[PATCH] gpio: blzp1600: remove incorrect pf_match_ptr()
Posted by Arnd Bergmann 9 months, 1 week ago
From: Arnd Bergmann <arnd@arndb.de>

The blzp1600_gpio_of_match is defined unconditionally and can always be referenced
by the driver, so don't use of_match_ptr() and avoid this warning:

drivers/gpio/gpio-blzp1600.c:263:34: error: 'blzp1600_gpio_of_match' defined but not used [-Werror=unused-const-variable=]
  263 | static const struct of_device_id blzp1600_gpio_of_match[] = {

Signed-off-by: Arnd Bergmann <arnd@arndb.de>
---
 drivers/gpio/gpio-blzp1600.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/gpio/gpio-blzp1600.c b/drivers/gpio/gpio-blzp1600.c
index 2760a13c0801..055cb296ae54 100644
--- a/drivers/gpio/gpio-blzp1600.c
+++ b/drivers/gpio/gpio-blzp1600.c
@@ -269,7 +269,7 @@ MODULE_DEVICE_TABLE(of, blzp1600_gpio_of_match);
 static struct platform_driver blzp1600_gpio_driver = {
 	.driver		= {
 		.name	= DRIVER_NAME,
-		.of_match_table = of_match_ptr(blzp1600_gpio_of_match),
+		.of_match_table = blzp1600_gpio_of_match,
 	},
 	.probe		= blzp1600_gpio_probe,
 };
-- 
2.39.5
Re: [PATCH] gpio: blzp1600: remove incorrect pf_match_ptr()
Posted by Bartosz Golaszewski 9 months, 1 week ago
From: Bartosz Golaszewski <bartosz.golaszewski@linaro.org>


On Fri, 02 May 2025 22:37:07 +0200, Arnd Bergmann wrote:
> The blzp1600_gpio_of_match is defined unconditionally and can always be referenced
> by the driver, so don't use of_match_ptr() and avoid this warning:
> 
> drivers/gpio/gpio-blzp1600.c:263:34: error: 'blzp1600_gpio_of_match' defined but not used [-Werror=unused-const-variable=]
>   263 | static const struct of_device_id blzp1600_gpio_of_match[] = {
> 
> 
> [...]

Applied, thanks!

[1/1] gpio: blzp1600: remove incorrect pf_match_ptr()
      https://git.kernel.org/brgl/linux/c/3a1e07184d78f52c07f69b40bedbbebbc417e71b

Best regards,
-- 
Bartosz Golaszewski <bartosz.golaszewski@linaro.org>