Rust beta (1.87) and nightly (1.88) lint cleanups

[PATCH 0/5] Rust beta (1.87) and nightly (1.88) lint cleanups

Posted by Miguel Ojeda 9 months, 1 week ago

Now that Rust 1.87.0 is close to release, clean up the new lints that appeared.

It may be that one of the patches is not needed by the time it releases, but
I prefer to not wait much longer since I would like to land this for -rc6 so
that it is clean for release.

In addition, clean some nightly (1.88.0) ones too.

Miguel Ojeda (5):
  objtool/rust: add one more `noreturn` Rust function for Rust 1.87.0
  rust: clean Rust 1.87.0's `clippy::ptr_eq` lints
  rust: clean Rust 1.88.0's `unnecessary_transmutes` lint
  rust: clean Rust 1.88.0's warning about `clippy::disallowed_macros`
    configuration
  rust: clean Rust 1.88.0's `clippy::uninlined_format_args` lint

 .clippy.toml                              |  2 +-
 drivers/gpu/nova-core/gpu.rs              |  2 +-
 init/Kconfig                              |  3 ++
 rust/bindings/lib.rs                      |  1 +
 rust/kernel/alloc/kvec.rs                 |  2 +-
 rust/kernel/list.rs                       | 12 +++---
 rust/kernel/str.rs                        | 46 +++++++++++------------
 rust/macros/kunit.rs                      | 13 ++-----
 rust/macros/module.rs                     | 19 +++-------
 rust/macros/paste.rs                      |  2 +-
 rust/pin-init/internal/src/pinned_drop.rs |  3 +-
 rust/uapi/lib.rs                          |  1 +
 tools/objtool/check.c                     |  1 +
 13 files changed, 49 insertions(+), 58 deletions(-)


base-commit: b4432656b36e5cc1d50a1f2dc15357543add530e
--
2.49.0

Re: [PATCH 0/5] Rust beta (1.87) and nightly (1.88) lint cleanups

Posted by Miguel Ojeda 9 months ago

On Fri, May 2, 2025 at 4:03 PM Miguel Ojeda <ojeda@kernel.org> wrote:
>
> Now that Rust 1.87.0 is close to release, clean up the new lints that appeared.
>
> It may be that one of the patches is not needed by the time it releases, but
> I prefer to not wait much longer since I would like to land this for -rc6 so
> that it is clean for release.
>
> In addition, clean some nightly (1.88.0) ones too.

Applied to `rust-fixes` -- thanks everyone!

    [ Converted to `allow`s since backport was confirmed. - Miguel ]

Cheers,
Miguel

Re: [PATCH 0/5] Rust beta (1.87) and nightly (1.88) lint cleanups

Posted by Alice Ryhl 9 months, 1 week ago

On Fri, May 02, 2025 at 04:02:32PM +0200, Miguel Ojeda wrote:
> Now that Rust 1.87.0 is close to release, clean up the new lints that appeared.
> 
> It may be that one of the patches is not needed by the time it releases, but
> I prefer to not wait much longer since I would like to land this for -rc6 so
> that it is clean for release.
> 
> In addition, clean some nightly (1.88.0) ones too.
> 
> Miguel Ojeda (5):
>   objtool/rust: add one more `noreturn` Rust function for Rust 1.87.0
>   rust: clean Rust 1.87.0's `clippy::ptr_eq` lints
>   rust: clean Rust 1.88.0's `unnecessary_transmutes` lint
>   rust: clean Rust 1.88.0's warning about `clippy::disallowed_macros`
>     configuration
>   rust: clean Rust 1.88.0's `clippy::uninlined_format_args` lint

Reviewed-by: Alice Ryhl <aliceryhl@google.com>