[v1] mux: adgs1408: simplify with spi_get_device_match_data()

[RESEND PATCH] mux: adgs1408: simplify with spi_get_device_match_data()

Posted by Krzysztof Kozlowski 9 months, 1 week ago

Use spi_get_device_match_data() helper to simplify a bit the driver.

Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
---

Resending patch from almost a year ago - there was no response to pings
either.

Is mux subsystem still alive? Shall it be marked as orphaned?


 drivers/mux/adgs1408.c | 4 +---
 1 file changed, 1 insertion(+), 3 deletions(-)

diff --git a/drivers/mux/adgs1408.c b/drivers/mux/adgs1408.c
index 22ed051eb1a4..5386cfedcb06 100644
--- a/drivers/mux/adgs1408.c
+++ b/drivers/mux/adgs1408.c
@@ -59,9 +59,7 @@ static int adgs1408_probe(struct spi_device *spi)
 	s32 idle_state;
 	int ret;
 
-	chip_id = (enum adgs1408_chip_id)device_get_match_data(dev);
-	if (!chip_id)
-		chip_id = spi_get_device_id(spi)->driver_data;
+	chip_id = (enum adgs1408_chip_id)spi_get_device_match_data(spi);
 
 	mux_chip = devm_mux_chip_alloc(dev, 1, 0);
 	if (IS_ERR(mux_chip))
-- 
2.45.2

Re: [RESEND PATCH] mux: adgs1408: simplify with spi_get_device_match_data()

Posted by Nuno Sá 9 months, 1 week ago

On Thu, 2025-05-01 at 19:37 +0200, Krzysztof Kozlowski wrote:
> Use spi_get_device_match_data() helper to simplify a bit the driver.
> 
> Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
> ---
> 

Reviewed-by: Nuno Sá <nuno.sa@analog.com>

> Resending patch from almost a year ago - there was no response to pings
> either.
> 
> Is mux subsystem still alive? Shall it be marked as orphaned?
> 
> 
>  drivers/mux/adgs1408.c | 4 +---
>  1 file changed, 1 insertion(+), 3 deletions(-)
> 
> diff --git a/drivers/mux/adgs1408.c b/drivers/mux/adgs1408.c
> index 22ed051eb1a4..5386cfedcb06 100644
> --- a/drivers/mux/adgs1408.c
> +++ b/drivers/mux/adgs1408.c
> @@ -59,9 +59,7 @@ static int adgs1408_probe(struct spi_device *spi)
>  	s32 idle_state;
>  	int ret;
>  
> -	chip_id = (enum adgs1408_chip_id)device_get_match_data(dev);
> -	if (!chip_id)
> -		chip_id = spi_get_device_id(spi)->driver_data;
> +	chip_id = (enum adgs1408_chip_id)spi_get_device_match_data(spi);
>  
>  	mux_chip = devm_mux_chip_alloc(dev, 1, 0);
>  	if (IS_ERR(mux_chip))