.../bindings/dma/nvidia,tegra20-apbdma.txt | 44 ----------- .../bindings/dma/nvidia,tegra20-apbdma.yaml | 90 ++++++++++++++++++++++ 2 files changed, 90 insertions(+), 44 deletions(-)
Update text binding to YAML.
Changes during conversion:
- Add a fallback for "nvidia,tegra30-apbdma" as it is
compatible with the IP core on "nvidia,tegra20-apbdma".
- Update examples and include appropriate file directives to resolve
errors identified by `dt_binding_check` and `dtbs_check`.
Signed-off-by: Charan Pedumuru <charan.pedumuru@gmail.com>
---
.../bindings/dma/nvidia,tegra20-apbdma.txt | 44 -----------
.../bindings/dma/nvidia,tegra20-apbdma.yaml | 90 ++++++++++++++++++++++
2 files changed, 90 insertions(+), 44 deletions(-)
diff --git a/Documentation/devicetree/bindings/dma/nvidia,tegra20-apbdma.txt b/Documentation/devicetree/bindings/dma/nvidia,tegra20-apbdma.txt
deleted file mode 100644
index 447fb44e7abe..000000000000
--- a/Documentation/devicetree/bindings/dma/nvidia,tegra20-apbdma.txt
+++ /dev/null
@@ -1,44 +0,0 @@
-* NVIDIA Tegra APB DMA controller
-
-Required properties:
-- compatible: Should be "nvidia,<chip>-apbdma"
-- reg: Should contain DMA registers location and length. This should include
- all of the per-channel registers.
-- interrupts: Should contain all of the per-channel DMA interrupts.
-- clocks: Must contain one entry, for the module clock.
- See ../clocks/clock-bindings.txt for details.
-- resets : Must contain an entry for each entry in reset-names.
- See ../reset/reset.txt for details.
-- reset-names : Must include the following entries:
- - dma
-- #dma-cells : Must be <1>. This dictates the length of DMA specifiers in
- client nodes' dmas properties. The specifier represents the DMA request
- select value for the peripheral. For more details, consult the Tegra TRM's
- documentation of the APB DMA channel control register REQ_SEL field.
-
-Examples:
-
-apbdma: dma@6000a000 {
- compatible = "nvidia,tegra20-apbdma";
- reg = <0x6000a000 0x1200>;
- interrupts = < 0 136 0x04
- 0 137 0x04
- 0 138 0x04
- 0 139 0x04
- 0 140 0x04
- 0 141 0x04
- 0 142 0x04
- 0 143 0x04
- 0 144 0x04
- 0 145 0x04
- 0 146 0x04
- 0 147 0x04
- 0 148 0x04
- 0 149 0x04
- 0 150 0x04
- 0 151 0x04 >;
- clocks = <&tegra_car 34>;
- resets = <&tegra_car 34>;
- reset-names = "dma";
- #dma-cells = <1>;
-};
diff --git a/Documentation/devicetree/bindings/dma/nvidia,tegra20-apbdma.yaml b/Documentation/devicetree/bindings/dma/nvidia,tegra20-apbdma.yaml
new file mode 100644
index 000000000000..fc800231b39b
--- /dev/null
+++ b/Documentation/devicetree/bindings/dma/nvidia,tegra20-apbdma.yaml
@@ -0,0 +1,90 @@
+# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause)
+%YAML 1.2
+---
+$id: http://devicetree.org/schemas/dma/nvidia,tegra20-apbdma.yaml#
+$schema: http://devicetree.org/meta-schemas/core.yaml#
+
+title: NVIDIA Tegra APB DMA Controller
+
+description: |
+ The NVIDIA Tegra APB DMA controller is a hardware component that
+ enables direct memory access (DMA) on Tegra systems. It facilitates
+ data transfer between I/O devices and main memory without constant
+ CPU intervention.
+
+maintainers:
+ - Jonathan Hunter <jonathanh@nvidia.com>
+
+properties:
+ compatible:
+ oneOf:
+ - const: nvidia,tegra20-apbdma
+ - items:
+ - const: nvidia,tegra30-apbdma
+ - const: nvidia,tegra20-apbdma
+
+ "#dma-cells":
+ description:
+ Must be <1>. This dictates the length of DMA specifiers
+ in client node's dmas properties.
+ const: 1
+
+ clocks:
+ maxItems: 1
+
+ reg:
+ maxItems: 1
+
+ interrupts:
+ description:
+ Should contain all of the per-channel DMA interrupts in
+ ascending order with respect to the DMA channel index.
+ minItems: 1
+ maxItems: 32
+
+ resets:
+ maxItems: 1
+
+ reset-names:
+ const: dma
+
+required:
+ - compatible
+ - reg
+ - interrupts
+ - clocks
+ - resets
+ - reset-names
+ - "#dma-cells"
+
+additionalProperties: false
+
+examples:
+ - |
+ #include <dt-bindings/interrupt-controller/arm-gic.h>
+ #include <dt-bindings/reset/tegra186-reset.h>
+ dma@6000a000 {
+ compatible = "nvidia,tegra30-apbdma", "nvidia,tegra20-apbdma";
+ reg = <0x6000a000 0x1200>;
+ interrupts = <0 136 0x04>,
+ <0 137 0x04>,
+ <0 138 0x04>,
+ <0 139 0x04>,
+ <0 140 0x04>,
+ <0 141 0x04>,
+ <0 142 0x04>,
+ <0 143 0x04>,
+ <0 144 0x04>,
+ <0 145 0x04>,
+ <0 146 0x04>,
+ <0 147 0x04>,
+ <0 148 0x04>,
+ <0 149 0x04>,
+ <0 150 0x04>,
+ <0 151 0x04>;
+ clocks = <&tegra_car 34>;
+ resets = <&tegra_car 34>;
+ reset-names = "dma";
+ #dma-cells = <1>;
+ };
+...
---
base-commit: 9d9096722447b77662d4237a09909bde7774f22e
change-id: 20250430-nvidea-dma-dc874a2f65f7
Best regards,
--
Charan Pedumuru <charan.pedumuru@gmail.com>On Thu, May 01, 2025 at 01:12:36PM GMT, Charan Pedumuru wrote:
> Update text binding to YAML.
> Changes during conversion:
> - Add a fallback for "nvidia,tegra30-apbdma" as it is
> compatible with the IP core on "nvidia,tegra20-apbdma".
> - Update examples and include appropriate file directives to resolve
> errors identified by `dt_binding_check` and `dtbs_check`.
>
Please use subject prefixes matching the subsystem. You can get them for
example with 'git log --oneline -- DIRECTORY_OR_FILE' on the directory
your patch is touching. For bindings, the preferred subjects are
explained here:
https://www.kernel.org/doc/html/latest/devicetree/bindings/submitting-patches.html#i-for-patch-submitters
Missing final nvidia,tegra20-apbdma prefix.
> Signed-off-by: Charan Pedumuru <charan.pedumuru@gmail.com>
> ---
> .../bindings/dma/nvidia,tegra20-apbdma.txt | 44 -----------
> .../bindings/dma/nvidia,tegra20-apbdma.yaml | 90 ++++++++++++++++++++++
> 2 files changed, 90 insertions(+), 44 deletions(-)
>
...
> +$id: http://devicetree.org/schemas/dma/nvidia,tegra20-apbdma.yaml#
> +$schema: http://devicetree.org/meta-schemas/core.yaml#
> +
> +title: NVIDIA Tegra APB DMA Controller
> +
> +description: |
Do not need '|' unless you need to preserve formatting.
> + The NVIDIA Tegra APB DMA controller is a hardware component that
> + enables direct memory access (DMA) on Tegra systems. It facilitates
> + data transfer between I/O devices and main memory without constant
> + CPU intervention.
> +
> +maintainers:
> + - Jonathan Hunter <jonathanh@nvidia.com>
> +
> +properties:
> + compatible:
> + oneOf:
> + - const: nvidia,tegra20-apbdma
> + - items:
> + - const: nvidia,tegra30-apbdma
> + - const: nvidia,tegra20-apbdma
> +
> + "#dma-cells":
> + description:
> + Must be <1>. This dictates the length of DMA specifiers
> + in client node's dmas properties.
Drop description, you are not telling here anything new except
explaining basically DT syntax.
> + const: 1
> +
> + clocks:
> + maxItems: 1
> +
> + reg:
> + maxItems: 1
reg is the second property. Old binding even had it correct.
> +
> + interrupts:
> + description:
> + Should contain all of the per-channel DMA interrupts in
> + ascending order with respect to the DMA channel index.
> + minItems: 1
> + maxItems: 32
> +
> + resets:
> + maxItems: 1
> +
> + reset-names:
> + const: dma
> +
> +required:
> + - compatible
> + - reg
And here the order is correct...
> + - interrupts
> + - clocks
But here different. Keep the same order as in properties.
> + - resets
> + - reset-names
> + - "#dma-cells"
> +
missing allOf: to dma-controller
> +additionalProperties: false
unevaluatedProperties instead. Just open any other DMA binding.
> +
> +examples:
> + - |
> + #include <dt-bindings/interrupt-controller/arm-gic.h>
You included this...
> + #include <dt-bindings/reset/tegra186-reset.h>
> + dma@6000a000 {
Doesn't look like correct name. Schema requires specific name.
> + compatible = "nvidia,tegra30-apbdma", "nvidia,tegra20-apbdma";
> + reg = <0x6000a000 0x1200>;
> + interrupts = <0 136 0x04>,
... so use it.
Best regards,
Krzysztof
On 02-05-2025 13:28, Krzysztof Kozlowski wrote:
> On Thu, May 01, 2025 at 01:12:36PM GMT, Charan Pedumuru wrote:
>> Update text binding to YAML.
>> Changes during conversion:
>> - Add a fallback for "nvidia,tegra30-apbdma" as it is
>> compatible with the IP core on "nvidia,tegra20-apbdma".
>> - Update examples and include appropriate file directives to resolve
>> errors identified by `dt_binding_check` and `dtbs_check`.
>>
> Please use subject prefixes matching the subsystem. You can get them for
> example with 'git log --oneline -- DIRECTORY_OR_FILE' on the directory
> your patch is touching. For bindings, the preferred subjects are
> explained here:
> https://www.kernel.org/doc/html/latest/devicetree/bindings/submitting-patches.html#i-for-patch-submitters
>
> Missing final nvidia,tegra20-apbdma prefix.
Sure, will update that accordingly.
>
>
>> Signed-off-by: Charan Pedumuru <charan.pedumuru@gmail.com>
>> ---
>> .../bindings/dma/nvidia,tegra20-apbdma.txt | 44 -----------
>> .../bindings/dma/nvidia,tegra20-apbdma.yaml | 90 ++++++++++++++++++++++
>> 2 files changed, 90 insertions(+), 44 deletions(-)
>>
> ...
>
>> +$id: http://devicetree.org/schemas/dma/nvidia,tegra20-apbdma.yaml#
>> +$schema: http://devicetree.org/meta-schemas/core.yaml#
>> +
>> +title: NVIDIA Tegra APB DMA Controller
>> +
>> +description: |
> Do not need '|' unless you need to preserve formatting.
>
>> + The NVIDIA Tegra APB DMA controller is a hardware component that
>> + enables direct memory access (DMA) on Tegra systems. It facilitates
>> + data transfer between I/O devices and main memory without constant
>> + CPU intervention.
>> +
>> +maintainers:
>> + - Jonathan Hunter <jonathanh@nvidia.com>
>> +
>> +properties:
>> + compatible:
>> + oneOf:
>> + - const: nvidia,tegra20-apbdma
>> + - items:
>> + - const: nvidia,tegra30-apbdma
>> + - const: nvidia,tegra20-apbdma
>> +
>> + "#dma-cells":
>> + description:
>> + Must be <1>. This dictates the length of DMA specifiers
>> + in client node's dmas properties.
> Drop description, you are not telling here anything new except
> explaining basically DT syntax.
>
>> + const: 1
>> +
>> + clocks:
>> + maxItems: 1
>> +
>> + reg:
>> + maxItems: 1
> reg is the second property. Old binding even had it correct.
>
>> +
>> + interrupts:
>> + description:
>> + Should contain all of the per-channel DMA interrupts in
>> + ascending order with respect to the DMA channel index.
>> + minItems: 1
>> + maxItems: 32
>> +
>> + resets:
>> + maxItems: 1
>> +
>> + reset-names:
>> + const: dma
>> +
>> +required:
>> + - compatible
>> + - reg
> And here the order is correct...
>
>> + - interrupts
>> + - clocks
> But here different. Keep the same order as in properties.
>
>> + - resets
>> + - reset-names
>> + - "#dma-cells"
>> +
> missing allOf: to dma-controller
The reason, I didn't include dma-controller is the pattern under
$nodename in dma-controller is not matching with the pattern present in
dts files.
So, I excluded it.
>
>> +additionalProperties: false
> unevaluatedProperties instead. Just open any other DMA binding.
sure.
>
>> +
>> +examples:
>> + - |
>> + #include <dt-bindings/interrupt-controller/arm-gic.h>
> You included this...
I checked the other DMA binding from nvidia, they included the same
header file. I can change it to irq.h, if required
>
>> + #include <dt-bindings/reset/tegra186-reset.h>
>> + dma@6000a000 {
> Doesn't look like correct name. Schema requires specific name.
The dt_binding_check is successful when I included allOf to
dma-controller and used dma-controller@600 as node name, but when I was
checking for dtb, the pattern is not matching with the one
inside dma-controller, so I removed allOf and changed the node name in
examples according to the node present inside the dts file.
>
>> + compatible = "nvidia,tegra30-apbdma", "nvidia,tegra20-apbdma";
>> + reg = <0x6000a000 0x1200>;
>> + interrupts = <0 136 0x04>,
> ... so use it.
>
> Best regards,
> Krzysztof
>
--
Best Regards,
Charan.
On 02/05/2025 12:27, Charan Pedumuru wrote: >>> + maxItems: 1 >>> + >>> + reset-names: >>> + const: dma >>> + >>> +required: >>> + - compatible >>> + - reg >> And here the order is correct... >> Fix your email program, because it re-wraps or removes line breaks in each quote. It is making conversation unnecessarily less readable. >>> + - interrupts >>> + - clocks >> But here different. Keep the same order as in properties. >> >>> + - resets >>> + - reset-names >>> + - "#dma-cells" >>> + >> missing allOf: to dma-controller > > > The reason, I didn't include dma-controller is the pattern under > $nodename in dma-controller is not matching with the pattern present in > dts files. > > So, I excluded it. Then the DTS has to be changed. Best regards, Krzysztof
© 2016 - 2026 Red Hat, Inc.