[v1] mfd: simple-mfd-i2c: add QIXIS CPLD support

[PATCH 0/6] mfd: simple-mfd-i2c: add QIXIS CPLD support

Posted by Ioana Ciornei 9 months, 2 weeks ago

The MDIO mux on the LX2160AQDS, LX2162AQDS and LS1028AQDS boards never
worked in mainline. The DT files were submitted initially as-is, and
there is a downstream driver for the QIXIS CPLD device:
https://github.com/nxp-qoriq/linux/blob/lf-6.12.y/drivers/soc/fsl/qixis_ctrl.c

Since the HW works with the already existing
driver/mfd/similar-mfd-i2c.c driver, extend the list of compatible
strings to also cover these 3 new boards, instead of trying to upstream
a duplicate driver.

This patch set also adapts the DT nodes for each of the affected boards
so that we match on the new compatible strings.

The last patch describes the two on-board RGMII PHYs found on the
LX2160AQDS boards which make use of the MDIO bus found behind the CPLD
driven MDIO mux.

Ioana Ciornei (5):
  dt-bindings: mfd: add bindings for QIXIS CPLD
  mfd: simple-mfd-i2c: add compatible string for Layerscape QIXIS CPLD
  arm64: dts: lx2160a-qds: make the QIXIS CPLD use the simple-mfd-i2c.c
    driver
  arm64: dts: lx2162a-qds: make the QIXIS CPLD use the simple-mfd-i2c.c
    driver
  arm64: dts: lx2160a-qds: add the two on-board RGMII PHYs

Vladimir Oltean (1):
  arm64: dts: ls1028a-qds: make the QIXIS CPLD use the simple-mfd-i2c.c
    driver

 .../bindings/mfd/fsl,qixis-i2c.yaml           | 65 +++++++++++++++++++
 .../boot/dts/freescale/fsl-ls1028a-qds.dts    |  9 +--
 .../boot/dts/freescale/fsl-lx2160a-qds.dts    | 28 +++++++-
 .../boot/dts/freescale/fsl-lx2162a-qds.dts    |  8 ++-
 drivers/mfd/simple-mfd-i2c.c                  |  3 +
 5 files changed, 103 insertions(+), 10 deletions(-)
 create mode 100644 Documentation/devicetree/bindings/mfd/fsl,qixis-i2c.yaml

-- 
2.25.1

Re: [PATCH 0/6] mfd: simple-mfd-i2c: add QIXIS CPLD support

Posted by Rob Herring (Arm) 9 months, 1 week ago

On Wed, 30 Apr 2025 18:36:28 +0300, Ioana Ciornei wrote:
> The MDIO mux on the LX2160AQDS, LX2162AQDS and LS1028AQDS boards never
> worked in mainline. The DT files were submitted initially as-is, and
> there is a downstream driver for the QIXIS CPLD device:
> https://github.com/nxp-qoriq/linux/blob/lf-6.12.y/drivers/soc/fsl/qixis_ctrl.c
> 
> Since the HW works with the already existing
> driver/mfd/similar-mfd-i2c.c driver, extend the list of compatible
> strings to also cover these 3 new boards, instead of trying to upstream
> a duplicate driver.
> 
> This patch set also adapts the DT nodes for each of the affected boards
> so that we match on the new compatible strings.
> 
> The last patch describes the two on-board RGMII PHYs found on the
> LX2160AQDS boards which make use of the MDIO bus found behind the CPLD
> driven MDIO mux.
> 
> Ioana Ciornei (5):
>   dt-bindings: mfd: add bindings for QIXIS CPLD
>   mfd: simple-mfd-i2c: add compatible string for Layerscape QIXIS CPLD
>   arm64: dts: lx2160a-qds: make the QIXIS CPLD use the simple-mfd-i2c.c
>     driver
>   arm64: dts: lx2162a-qds: make the QIXIS CPLD use the simple-mfd-i2c.c
>     driver
>   arm64: dts: lx2160a-qds: add the two on-board RGMII PHYs
> 
> Vladimir Oltean (1):
>   arm64: dts: ls1028a-qds: make the QIXIS CPLD use the simple-mfd-i2c.c
>     driver
> 
>  .../bindings/mfd/fsl,qixis-i2c.yaml           | 65 +++++++++++++++++++
>  .../boot/dts/freescale/fsl-ls1028a-qds.dts    |  9 +--
>  .../boot/dts/freescale/fsl-lx2160a-qds.dts    | 28 +++++++-
>  .../boot/dts/freescale/fsl-lx2162a-qds.dts    |  8 ++-
>  drivers/mfd/simple-mfd-i2c.c                  |  3 +
>  5 files changed, 103 insertions(+), 10 deletions(-)
>  create mode 100644 Documentation/devicetree/bindings/mfd/fsl,qixis-i2c.yaml
> 
> --
> 2.25.1
> 
> 
> 


My bot found new DTB warnings on the .dts files added or changed in this
series.

Some warnings may be from an existing SoC .dtsi. Or perhaps the warnings
are fixed by another series. Ultimately, it is up to the platform
maintainer whether these warnings are acceptable or not. No need to reply
unless the platform maintainer has comments.

If you already ran DT checks and didn't see these error(s), then
make sure dt-schema is up to date:

  pip3 install dtschema --upgrade


This patch series was applied (using b4) to base:
 Base: attempting to guess base-commit...
 Base: tags/next-20250429 (exact match)

If this is not the correct base, please add 'base-commit' tag
(or use b4 which does this automatically)

New warnings running 'make CHECK_DTBS=y for arch/arm64/boot/dts/freescale/' for 20250430153634.2971736-1-ioana.ciornei@nxp.com:

arch/arm64/boot/dts/freescale/fsl-lx2160a-qds.dtb: fpga@66 (fsl,lx2160a-qds-qixis-i2c): 'mux-controller@54' does not match any of the regexes: '^pinctrl-[0-9]+$'
	from schema $id: http://devicetree.org/schemas/mfd/fsl,qixis-i2c.yaml#
arch/arm64/boot/dts/freescale/fsl-ls1028a-qds.dtb: fpga@66 (fsl,ls1028a-qds-qixis-i2c): 'mux-controller@54' does not match any of the regexes: '^pinctrl-[0-9]+$'
	from schema $id: http://devicetree.org/schemas/mfd/fsl,qixis-i2c.yaml#
arch/arm64/boot/dts/freescale/fsl-lx2162a-qds.dtb: fpga@66 (fsl,lx2162a-qds-qixis-i2c): 'mux-controller@54' does not match any of the regexes: '^pinctrl-[0-9]+$'
	from schema $id: http://devicetree.org/schemas/mfd/fsl,qixis-i2c.yaml#

Re: [PATCH 0/6] mfd: simple-mfd-i2c: add QIXIS CPLD support

Posted by Ioana Ciornei 9 months, 1 week ago

On Wed, Apr 30, 2025 at 11:15:28PM -0500, Rob Herring (Arm) wrote:
> 
> On Wed, 30 Apr 2025 18:36:28 +0300, Ioana Ciornei wrote:
> > The MDIO mux on the LX2160AQDS, LX2162AQDS and LS1028AQDS boards never
> > worked in mainline. The DT files were submitted initially as-is, and
> > there is a downstream driver for the QIXIS CPLD device:
> > https://github.com/nxp-qoriq/linux/blob/lf-6.12.y/drivers/soc/fsl/qixis_ctrl.c
> > 
> > Since the HW works with the already existing
> > driver/mfd/similar-mfd-i2c.c driver, extend the list of compatible
> > strings to also cover these 3 new boards, instead of trying to upstream
> > a duplicate driver.
> > 
> > This patch set also adapts the DT nodes for each of the affected boards
> > so that we match on the new compatible strings.
> > 
> > The last patch describes the two on-board RGMII PHYs found on the
> > LX2160AQDS boards which make use of the MDIO bus found behind the CPLD
> > driven MDIO mux.
> > 
> > Ioana Ciornei (5):
> >   dt-bindings: mfd: add bindings for QIXIS CPLD
> >   mfd: simple-mfd-i2c: add compatible string for Layerscape QIXIS CPLD
> >   arm64: dts: lx2160a-qds: make the QIXIS CPLD use the simple-mfd-i2c.c
> >     driver
> >   arm64: dts: lx2162a-qds: make the QIXIS CPLD use the simple-mfd-i2c.c
> >     driver
> >   arm64: dts: lx2160a-qds: add the two on-board RGMII PHYs
> > 
> > Vladimir Oltean (1):
> >   arm64: dts: ls1028a-qds: make the QIXIS CPLD use the simple-mfd-i2c.c
> >     driver
> > 
> >  .../bindings/mfd/fsl,qixis-i2c.yaml           | 65 +++++++++++++++++++
> >  .../boot/dts/freescale/fsl-ls1028a-qds.dts    |  9 +--
> >  .../boot/dts/freescale/fsl-lx2160a-qds.dts    | 28 +++++++-
> >  .../boot/dts/freescale/fsl-lx2162a-qds.dts    |  8 ++-
> >  drivers/mfd/simple-mfd-i2c.c                  |  3 +
> >  5 files changed, 103 insertions(+), 10 deletions(-)
> >  create mode 100644 Documentation/devicetree/bindings/mfd/fsl,qixis-i2c.yaml
> > 
> > --
> > 2.25.1
> > 
> > 
> > 
> 
> 
> My bot found new DTB warnings on the .dts files added or changed in this
> series.
> 
> Some warnings may be from an existing SoC .dtsi. Or perhaps the warnings
> are fixed by another series. Ultimately, it is up to the platform
> maintainer whether these warnings are acceptable or not. No need to reply
> unless the platform maintainer has comments.
> 
> If you already ran DT checks and didn't see these error(s), then
> make sure dt-schema is up to date:
> 
>   pip3 install dtschema --upgrade
> 
> 
> This patch series was applied (using b4) to base:
>  Base: attempting to guess base-commit...
>  Base: tags/next-20250429 (exact match)
> 
> If this is not the correct base, please add 'base-commit' tag
> (or use b4 which does this automatically)
> 
> New warnings running 'make CHECK_DTBS=y for arch/arm64/boot/dts/freescale/' for 20250430153634.2971736-1-ioana.ciornei@nxp.com:
> 
> arch/arm64/boot/dts/freescale/fsl-lx2160a-qds.dtb: fpga@66 (fsl,lx2160a-qds-qixis-i2c): 'mux-controller@54' does not match any of the regexes: '^pinctrl-[0-9]+$'
> 	from schema $id: http://devicetree.org/schemas/mfd/fsl,qixis-i2c.yaml
> arch/arm64/boot/dts/freescale/fsl-ls1028a-qds.dtb: fpga@66 (fsl,ls1028a-qds-qixis-i2c): 'mux-controller@54' does not match any of the regexes: '^pinctrl-[0-9]+$'
> 	from schema $id: http://devicetree.org/schemas/mfd/fsl,qixis-i2c.yaml
> arch/arm64/boot/dts/freescale/fsl-lx2162a-qds.dtb: fpga@66 (fsl,lx2162a-qds-qixis-i2c): 'mux-controller@54' does not match any of the regexes: '^pinctrl-[0-9]+$'
> 	from schema $id: http://devicetree.org/schemas/mfd/fsl,qixis-i2c.yaml

Sorry for this, my bad. I only run dt_binding_check and didn't see any
errors because the example was not the correct one.

I will fix this in v2.

Ioana