The Tiger Lake pinctrl driver is also used by some Alder Lake platforms
that reuse the same GPIO IP blocks.

Update the Kconfig help texts for both drivers to document supported
platforms and clarify when CONFIG_PINCTRL_TIGERLAKE may be required.

Supported platforms:
  - Tiger Lake (all variants)
  - Alder Lake-P

Reported-by: Guido Trentalancia <guido2022@trentalancia.com>
Link: https://bugzilla.kernel.org/show_bug.cgi?id=220056
Signed-off-by: Ariel Simulevski <ariel@simulevski.at>
---
 drivers/pinctrl/intel/Kconfig | 9 +++++++++
 1 file changed, 9 insertions(+)

diff --git a/drivers/pinctrl/intel/Kconfig b/drivers/pinctrl/intel/Kconfig
index 248c2e558ff3..f1114828457d 100644
--- a/drivers/pinctrl/intel/Kconfig
+++ b/drivers/pinctrl/intel/Kconfig
@@ -54,6 +54,9 @@ config PINCTRL_ALDERLAKE
 	  This pinctrl driver provides an interface that allows configuring
 	  of Intel Alder Lake PCH pins and using them as GPIOs.
 
+	  Some platforms may reuse GPIO IP blocks from earlier generations
+	  and require CONFIG_PINCTRL_TIGERLAKE instead.
+
 config PINCTRL_BROXTON
 	tristate "Intel Broxton pinctrl and GPIO driver"
 	select PINCTRL_INTEL
@@ -161,5 +164,11 @@ config PINCTRL_TIGERLAKE
 	  This pinctrl driver provides an interface that allows configuring
 	  of Intel Tiger Lake PCH pins and using them as GPIOs.
 
+	  Also used on some Alder Lake platforms that share compatible GPIO IP.
+
+	  Supported platforms:
+	    - Tiger Lake (all variants)
+	    - Alder Lake-P
+
 source "drivers/pinctrl/intel/Kconfig.tng"
 endmenu
-- 
2.49.0

On Wed, Apr 30, 2025 at 6:32 PM Ariel Simulevski <ariel@simulevski.at> wrote:

Technically this is a v2 of the previous patch, but it has been
changed a lot, so for _this_ time it's okay to have it still v1. Also
note when v2 or any new version of patch is required the changelog
must be provided (after the cutter '---' line below).

> The Tiger Lake pinctrl driver is also used by some Alder Lake platforms
> that reuse the same GPIO IP blocks.
>
> Update the Kconfig help texts for both drivers to document supported
> platforms

> and clarify when CONFIG_PINCTRL_TIGERLAKE may be required.

This should be done in the same way....

> Supported platforms:
>   - Tiger Lake (all variants)

Have you checked this (that's all versions of Tiger Lake are in this driver)?

>   - Alder Lake-P

> +         Some platforms may reuse GPIO IP blocks from earlier generations
> +         and require CONFIG_PINCTRL_TIGERLAKE instead.

Just list the supported platforms:
- Alder Lake-N
- Alder Lake-S

And I believe some of Raptor Lake:s are also require this driver.

> +         Also used on some Alder Lake platforms that share compatible GPIO IP.

No need to have this text, it's obvious from the below list.

> +         Supported platforms:
> +           - Tiger Lake (all variants)
> +           - Alder Lake-P

...

With that, waiting for v2.

-- 
With Best Regards,
Andy Shevchenko

On Wed, Apr 30, 2025 at 9:14 PM Andy Shevchenko
<andy.shevchenko@gmail.com> wrote:
> On Wed, Apr 30, 2025 at 6:32 PM Ariel Simulevski <ariel@simulevski.at> wrote:
>
> Technically this is a v2 of the previous patch, but it has been
> changed a lot, so for _this_ time it's okay to have it still v1. Also
> note when v2 or any new version of patch is required the changelog
> must be provided (after the cutter '---' line below).

On top of that, you forgot to include (all) maintainers of the
respective code. I recommend using my "smart" script [1] for sending
patches to the Linux kernel subsystems.

...

> With that, waiting for v2.


[1]: https://github.com/andy-shev/home-bin-tools/blob/master/ge2maintainer.sh

-- 
With Best Regards,
Andy Shevchenko