[PATCH] crypto: rng - fix documentation for crypto_rng_alg()

Ovidiu Panait posted 1 patch 9 months, 1 week ago
include/crypto/rng.h | 8 +++-----
1 file changed, 3 insertions(+), 5 deletions(-)
[PATCH] crypto: rng - fix documentation for crypto_rng_alg()
Posted by Ovidiu Panait 9 months, 1 week ago
Current documentation states that crypto_rng_alg() returns the cra_name of
the rng algorithm, but it actually returns a 'struct rng_alg' pointer from
a RNG handle.

Update documentation to reflect this.

Signed-off-by: Ovidiu Panait <ovidiu.panait.oss@gmail.com>
---
 include/crypto/rng.h | 8 +++-----
 1 file changed, 3 insertions(+), 5 deletions(-)

diff --git a/include/crypto/rng.h b/include/crypto/rng.h
index 5ac4388f50e1..f8224cc390f8 100644
--- a/include/crypto/rng.h
+++ b/include/crypto/rng.h
@@ -102,12 +102,10 @@ static inline struct rng_alg *__crypto_rng_alg(struct crypto_alg *alg)
 }
 
 /**
- * crypto_rng_alg - obtain name of RNG
- * @tfm: cipher handle
- *
- * Return the generic name (cra_name) of the initialized random number generator
+ * crypto_rng_alg() - obtain 'struct rng_alg' pointer from RNG handle
+ * @tfm: RNG handle
  *
- * Return: generic name string
+ * Return: Pointer to 'struct rng_alg', derived from @tfm RNG handle
  */
 static inline struct rng_alg *crypto_rng_alg(struct crypto_rng *tfm)
 {
-- 
2.48.1
Re: [PATCH] crypto: rng - fix documentation for crypto_rng_alg()
Posted by Herbert Xu 9 months, 1 week ago
On Wed, Apr 30, 2025 at 02:59:53PM +0300, Ovidiu Panait wrote:
> Current documentation states that crypto_rng_alg() returns the cra_name of
> the rng algorithm, but it actually returns a 'struct rng_alg' pointer from
> a RNG handle.
> 
> Update documentation to reflect this.
> 
> Signed-off-by: Ovidiu Panait <ovidiu.panait.oss@gmail.com>
> ---
>  include/crypto/rng.h | 8 +++-----
>  1 file changed, 3 insertions(+), 5 deletions(-)

Patch applied.  Thanks.
-- 
Email: Herbert Xu <herbert@gondor.apana.org.au>
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt