[PATCH v2 1/2] dt-bindings: arm: rockchip: Add rk3399 industry evaluation board

Chaoyi Chen posted 2 patches 9 months, 2 weeks ago
There is a newer version of this series
[PATCH v2 1/2] dt-bindings: arm: rockchip: Add rk3399 industry evaluation board
Posted by Chaoyi Chen 9 months, 2 weeks ago
From: Chaoyi Chen <chaoyi.chen@rock-chips.com>

Add devicetree binding for the rk3399 industry evaluation board.

Signed-off-by: Chaoyi Chen <chaoyi.chen@rock-chips.com>
---

(no changes since v1)

 Documentation/devicetree/bindings/arm/rockchip.yaml | 5 +++++
 1 file changed, 5 insertions(+)

diff --git a/Documentation/devicetree/bindings/arm/rockchip.yaml b/Documentation/devicetree/bindings/arm/rockchip.yaml
index 650fb833d96e..684d48ba20fc 100644
--- a/Documentation/devicetree/bindings/arm/rockchip.yaml
+++ b/Documentation/devicetree/bindings/arm/rockchip.yaml
@@ -1047,6 +1047,11 @@ properties:
           - const: rockchip,rk3399-evb
           - const: rockchip,rk3399

+      - description: Rockchip RK3399 Industry Evaluation board
+        items:
+          - const: rockchip,rk3399-evb-ind
+          - const: rockchip,rk3399
+
       - description: Rockchip RK3399 Sapphire standalone
         items:
           - const: rockchip,rk3399-sapphire
--
2.49.0
Re: [PATCH v2 1/2] dt-bindings: arm: rockchip: Add rk3399 industry evaluation board
Posted by Rob Herring (Arm) 9 months, 2 weeks ago
On Wed, 30 Apr 2025 15:48:47 +0800, Chaoyi Chen wrote:
> From: Chaoyi Chen <chaoyi.chen@rock-chips.com>
> 
> Add devicetree binding for the rk3399 industry evaluation board.
> 
> Signed-off-by: Chaoyi Chen <chaoyi.chen@rock-chips.com>
> ---
> 
> (no changes since v1)
> 
>  Documentation/devicetree/bindings/arm/rockchip.yaml | 5 +++++
>  1 file changed, 5 insertions(+)
> 


Please add Acked-by/Reviewed-by tags when posting new versions. However,
there's no need to repost patches *only* to add the tags. The upstream
maintainer will do that for acks received on the version they apply.

If a tag was not added on purpose, please state why and what changed.

Missing tags:

Acked-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
Re: [PATCH v2 1/2] dt-bindings: arm: rockchip: Add rk3399 industry evaluation board
Posted by Quentin Schulz 9 months, 2 weeks ago
Hi Rob,

On 4/30/25 4:36 PM, Rob Herring (Arm) wrote:
> 
> On Wed, 30 Apr 2025 15:48:47 +0800, Chaoyi Chen wrote:
>> From: Chaoyi Chen <chaoyi.chen@rock-chips.com>
>>
>> Add devicetree binding for the rk3399 industry evaluation board.
>>
>> Signed-off-by: Chaoyi Chen <chaoyi.chen@rock-chips.com>
>> ---
>>
>> (no changes since v1)
>>
>>   Documentation/devicetree/bindings/arm/rockchip.yaml | 5 +++++
>>   1 file changed, 5 insertions(+)
>>
> 
> 
> Please add Acked-by/Reviewed-by tags when posting new versions. However,
> there's no need to repost patches *only* to add the tags. The upstream
> maintainer will do that for acks received on the version they apply.
> 
> If a tag was not added on purpose, please state why and what changed.
> 
> Missing tags:
> 
> Acked-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
> 

To be fair, the Acked-by was given on the v1[1] after the v2[2] was 
sent, we cannot expect Chaoyi Chen to travel back in time :)

[1] 
https://lore.kernel.org/linux-rockchip/20250430-light-chital-of-cookies-b8f2ab@kuoka/ 
10:22 UTC
[2] 
https://lore.kernel.org/linux-rockchip/20250430074848.539-2-kernel@airkyi.com/ 
7:48 UTC

Cheers,
Quentin
Re: [PATCH v2 1/2] dt-bindings: arm: rockchip: Add rk3399 industry evaluation board
Posted by Rob Herring 9 months, 1 week ago
On Wed, Apr 30, 2025 at 04:48:35PM +0200, Quentin Schulz wrote:
> Hi Rob,
> 
> On 4/30/25 4:36 PM, Rob Herring (Arm) wrote:
> > 
> > On Wed, 30 Apr 2025 15:48:47 +0800, Chaoyi Chen wrote:
> > > From: Chaoyi Chen <chaoyi.chen@rock-chips.com>
> > > 
> > > Add devicetree binding for the rk3399 industry evaluation board.
> > > 
> > > Signed-off-by: Chaoyi Chen <chaoyi.chen@rock-chips.com>
> > > ---
> > > 
> > > (no changes since v1)
> > > 
> > >   Documentation/devicetree/bindings/arm/rockchip.yaml | 5 +++++
> > >   1 file changed, 5 insertions(+)
> > > 
> > 
> > 
> > Please add Acked-by/Reviewed-by tags when posting new versions. However,
> > there's no need to repost patches *only* to add the tags. The upstream
> > maintainer will do that for acks received on the version they apply.
> > 
> > If a tag was not added on purpose, please state why and what changed.
> > 
> > Missing tags:
> > 
> > Acked-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
> > 
> 
> To be fair, the Acked-by was given on the v1[1] after the v2[2] was sent, we
> cannot expect Chaoyi Chen to travel back in time :)

Usually a sign of sending new versions too quickly...

But I just send this semi-automated email so we capture the ack and I 
can clear it out of my inbox.

Rob