nvme: select tls config when tcp tls is enabled

[PATCH] nvme: select tls config when tcp tls is enabled

Posted by Alistair Francis 9 months, 2 weeks ago

Ensure that TLS support is enabled in the kernel when
NVME_TCP_TLSS is enabled. This allows TLS secure channels to be
used out of the box.

Fixes: be8e82caa68 ("nvme-tcp: enable TLS handshake upcall")
Signed-off-by: Alistair Francis <alistair.francis@wdc.com>
---
 drivers/nvme/host/Kconfig | 1 +
 1 file changed, 1 insertion(+)

diff --git a/drivers/nvme/host/Kconfig b/drivers/nvme/host/Kconfig
index d47dfa80fb95..4d64b6935bb9 100644
--- a/drivers/nvme/host/Kconfig
+++ b/drivers/nvme/host/Kconfig
@@ -102,6 +102,7 @@ config NVME_TCP_TLS
 	depends on NVME_TCP
 	select NET_HANDSHAKE
 	select KEYS
+	select TLS
 	help
 	  Enables TLS encryption for NVMe TCP using the netlink handshake API.
 
-- 
2.49.0

Re: [PATCH] nvme: select tls config when tcp tls is enabled

Posted by Hannes Reinecke 9 months, 2 weeks ago

On 4/30/25 00:40, Alistair Francis wrote:
> Ensure that TLS support is enabled in the kernel when
> NVME_TCP_TLSS is enabled. This allows TLS secure channels to be
> used out of the box.
> 
> Fixes: be8e82caa68 ("nvme-tcp: enable TLS handshake upcall")
> Signed-off-by: Alistair Francis <alistair.francis@wdc.com>
> ---
>   drivers/nvme/host/Kconfig | 1 +
>   1 file changed, 1 insertion(+)
> 
> diff --git a/drivers/nvme/host/Kconfig b/drivers/nvme/host/Kconfig
> index d47dfa80fb95..4d64b6935bb9 100644
> --- a/drivers/nvme/host/Kconfig
> +++ b/drivers/nvme/host/Kconfig
> @@ -102,6 +102,7 @@ config NVME_TCP_TLS
>   	depends on NVME_TCP
>   	select NET_HANDSHAKE
>   	select KEYS
> +	select TLS
>   	help
>   	  Enables TLS encryption for NVMe TCP using the netlink handshake API.
>   
I would have folded it into the previous patch.

Otherwise:

Reviewed-by: Hannes Reinecke <hare@suse.de>

Cheers,

Hannes
-- 
Dr. Hannes Reinecke                  Kernel Storage Architect
hare@suse.de                                +49 911 74053 688
SUSE Software Solutions GmbH, Frankenstr. 146, 90461 Nürnberg
HRB 36809 (AG Nürnberg), GF: I. Totev, A. McDonald, W. Knoblich

Re: [PATCH] nvme: select tls config when tcp tls is enabled

Posted by Chaitanya Kulkarni 9 months, 2 weeks ago

On 4/29/25 15:40, Alistair Francis wrote:
> Ensure that TLS support is enabled in the kernel when
> NVME_TCP_TLSS is enabled. This allows TLS secure channels to be
> used out of the box.
>
> Fixes: be8e82caa68 ("nvme-tcp: enable TLS handshake upcall")
> Signed-off-by: Alistair Francis<alistair.francis@wdc.com>

to keep it easy on the git log better we should merge this next to

Looks good.

Reviewed-by: Chaitanya Kulkarni <kch@nvidia.com>

-ck

Re: [PATCH] nvme: select tls config when tcp tls is enabled

Posted by Chaitanya Kulkarni 9 months, 2 weeks ago

On 4/29/25 15:40, Alistair Francis wrote:
> Ensure that TLS support is enabled in the kernel when
> NVME_TCP_TLSS is enabled. This allows TLS secure channels to be
> used out of the box.
>
> Fixes: be8e82caa68 ("nvme-tcp: enable TLS handshake upcall")
> Signed-off-by: Alistair Francis<alistair.francis@wdc.com>


Looks good.

Reviewed-by: Chaitanya Kulkarni <kch@nvidia.com>

-ck