[v2] Fix minor issue in SoundWire slave IRQ mapping

[PATCH v2 0/2] Fix minor issue in SoundWire slave IRQ mapping

Posted by Charles Keepax 9 months, 2 weeks ago

Currently there would be problems if multiple devices on the same bus
attempted to use SoundWire IRQ handling rather than the IRQ callback
mechanism. So far only cs42l43 uses this system so this hasn't caused
any problems.

Thanks,
Charles

Changes since v1:
 - Don't reuse the new IDA for the dev_num
 - Expand the number of devices allowed on a bus to 16

Charles Keepax (2):
  soundwire: bus: Simplify sdw_assign_device_num()
  soundwire: bus: Add internal slave ID and use for IRQs

 drivers/soundwire/bus.c       | 31 ++++++++++++++-----------------
 drivers/soundwire/bus_type.c  | 10 ++++++++++
 drivers/soundwire/irq.c       |  6 +++---
 include/linux/soundwire/sdw.h |  6 ++++++
 4 files changed, 33 insertions(+), 20 deletions(-)

-- 
2.39.5

Re: [PATCH v2 0/2] Fix minor issue in SoundWire slave IRQ mapping

Posted by Vinod Koul 9 months ago

On Tue, 29 Apr 2025 11:18:06 +0100, Charles Keepax wrote:
> Currently there would be problems if multiple devices on the same bus
> attempted to use SoundWire IRQ handling rather than the IRQ callback
> mechanism. So far only cs42l43 uses this system so this hasn't caused
> any problems.
> 
> Thanks,
> Charles
> 
> [...]

Applied, thanks!

[1/2] soundwire: bus: Simplify sdw_assign_device_num()
      commit: 5b1a2927c4f63878d2c108cebad09358e69caa20
[2/2] soundwire: bus: Add internal slave ID and use for IRQs
      commit: aab12022b076f0b385b7a9a78e1161bd2df5d1e3

Best regards,
-- 
~Vinod

Re: [PATCH v2 0/2] Fix minor issue in SoundWire slave IRQ mapping

Posted by Pierre-Louis Bossart 9 months, 1 week ago


On 4/29/25 05:18, Charles Keepax wrote:
> Currently there would be problems if multiple devices on the same bus
> attempted to use SoundWire IRQ handling rather than the IRQ callback
> mechanism. So far only cs42l43 uses this system so this hasn't caused
> any problems.
> 
> Thanks,
> Charles
> 
> Changes since v1:
>   - Don't reuse the new IDA for the dev_num
>   - Expand the number of devices allowed on a bus to 16
> 
> Charles Keepax (2):
>    soundwire: bus: Simplify sdw_assign_device_num()
>    soundwire: bus: Add internal slave ID and use for IRQs

LGTM,

Reviewed-by: Pierre-Louis Bossart <pierre-louis.bossart@linux.dev>

> 
>   drivers/soundwire/bus.c       | 31 ++++++++++++++-----------------
>   drivers/soundwire/bus_type.c  | 10 ++++++++++
>   drivers/soundwire/irq.c       |  6 +++---
>   include/linux/soundwire/sdw.h |  6 ++++++
>   4 files changed, 33 insertions(+), 20 deletions(-)
>