[v2] Enable audio on qcs6490-RB3Gen2 and qcm6490-idp boards

[PATCH v2 5/7] arm64: dts: qcom: qcs6490-rb3gen2: Add sound card

Posted by Prasad Kumpatla 9 months, 2 weeks ago

From: Mohammad Rafi Shaik <quic_mohs@quicinc.com>

Add the sound card node with tested playback over WSA8835 speakers
and digital on-board mics.

Signed-off-by: Mohammad Rafi Shaik <quic_mohs@quicinc.com>
Co-developed-by: Prasad Kumpatla <quic_pkumpatl@quicinc.com>
Signed-off-by: Prasad Kumpatla <quic_pkumpatl@quicinc.com>
---
 arch/arm64/boot/dts/qcom/qcs6490-rb3gen2.dts | 49 ++++++++++++++++++++
 1 file changed, 49 insertions(+)

diff --git a/arch/arm64/boot/dts/qcom/qcs6490-rb3gen2.dts b/arch/arm64/boot/dts/qcom/qcs6490-rb3gen2.dts
index 43cbdbe43afd..9cfe648e29bb 100644
--- a/arch/arm64/boot/dts/qcom/qcs6490-rb3gen2.dts
+++ b/arch/arm64/boot/dts/qcom/qcs6490-rb3gen2.dts
@@ -1078,6 +1078,55 @@
 	status = "okay";
 };
 
+&sound {
+	compatible = "qcom,qcs6490-rb3gen2-sndcard";
+	model = "qcs6490-rb3gen2-snd-card";
+
+	audio-routing =
+		"SpkrLeft IN", "WSA_SPK1 OUT",
+		"SpkrRight IN", "WSA_SPK2 OUT",
+		"VA DMIC0", "vdd-micb",
+		"VA DMIC1", "vdd-micb",
+		"VA DMIC2", "vdd-micb",
+		"VA DMIC3", "vdd-micb";
+
+		#address-cells = <1>;
+		#size-cells = <0>;
+
+	wsa-dai-link {
+		link-name = "WSA Playback";
+
+		codec {
+			sound-dai = <&left_spkr>, <&right_spkr>, <&swr2 0>,
+					<&lpass_wsa_macro 0>;
+		};
+
+		cpu {
+			sound-dai = <&q6apmbedai WSA_CODEC_DMA_RX_0>;
+		};
+
+		platform {
+			sound-dai = <&q6apm>;
+		};
+	};
+
+	va-dai-link {
+		link-name = "VA Capture";
+
+		codec {
+			sound-dai = <&lpass_va_macro 0>;
+		};
+
+		cpu {
+			sound-dai = <&q6apmbedai VA_CODEC_DMA_TX_0>;
+		};
+
+		platform {
+			sound-dai = <&q6apm>;
+		};
+	};
+};
+
 &swr2 {
 	status = "okay";
 	left_spkr: speaker@0,1 {
-- 
2.17.1

Re: [PATCH v2 5/7] arm64: dts: qcom: qcs6490-rb3gen2: Add sound card

Posted by Konrad Dybcio 9 months, 2 weeks ago

On 4/29/25 11:24 AM, Prasad Kumpatla wrote:
> From: Mohammad Rafi Shaik <quic_mohs@quicinc.com>
> 
> Add the sound card node with tested playback over WSA8835 speakers
> and digital on-board mics.
> 
> Signed-off-by: Mohammad Rafi Shaik <quic_mohs@quicinc.com>
> Co-developed-by: Prasad Kumpatla <quic_pkumpatl@quicinc.com>
> Signed-off-by: Prasad Kumpatla <quic_pkumpatl@quicinc.com>
> ---
>  arch/arm64/boot/dts/qcom/qcs6490-rb3gen2.dts | 49 ++++++++++++++++++++
>  1 file changed, 49 insertions(+)
> 
> diff --git a/arch/arm64/boot/dts/qcom/qcs6490-rb3gen2.dts b/arch/arm64/boot/dts/qcom/qcs6490-rb3gen2.dts
> index 43cbdbe43afd..9cfe648e29bb 100644
> --- a/arch/arm64/boot/dts/qcom/qcs6490-rb3gen2.dts
> +++ b/arch/arm64/boot/dts/qcom/qcs6490-rb3gen2.dts
> @@ -1078,6 +1078,55 @@
>  	status = "okay";
>  };
>  
> +&sound {
> +	compatible = "qcom,qcs6490-rb3gen2-sndcard";
> +	model = "qcs6490-rb3gen2-snd-card";
> +
> +	audio-routing =
> +		"SpkrLeft IN", "WSA_SPK1 OUT",

Please unbreak the line and align the entries

[...]

> +		"SpkrRight IN", "WSA_SPK2 OUT",
> +		"VA DMIC0", "vdd-micb",
> +		"VA DMIC1", "vdd-micb",
> +		"VA DMIC2", "vdd-micb",
> +		"VA DMIC3", "vdd-micb";
> +
> +		#address-cells = <1>;
> +		#size-cells = <0>;
> +
> +	wsa-dai-link {
> +		link-name = "WSA Playback";
> +
> +		codec {
> +			sound-dai = <&left_spkr>, <&right_spkr>, <&swr2 0>,
> +					<&lpass_wsa_macro 0>;

Please align the <s

Konrad

Re: [PATCH v2 5/7] arm64: dts: qcom: qcs6490-rb3gen2: Add sound card

Posted by Prasad Kumpatla 9 months, 1 week ago


On 4/29/2025 4:28 PM, Konrad Dybcio wrote:
> On 4/29/25 11:24 AM, Prasad Kumpatla wrote:
>> From: Mohammad Rafi Shaik <quic_mohs@quicinc.com>
>>
>> Add the sound card node with tested playback over WSA8835 speakers
>> and digital on-board mics.
>>
>> Signed-off-by: Mohammad Rafi Shaik <quic_mohs@quicinc.com>
>> Co-developed-by: Prasad Kumpatla <quic_pkumpatl@quicinc.com>
>> Signed-off-by: Prasad Kumpatla <quic_pkumpatl@quicinc.com>
>> ---
>>   arch/arm64/boot/dts/qcom/qcs6490-rb3gen2.dts | 49 ++++++++++++++++++++
>>   1 file changed, 49 insertions(+)
>>
>> diff --git a/arch/arm64/boot/dts/qcom/qcs6490-rb3gen2.dts b/arch/arm64/boot/dts/qcom/qcs6490-rb3gen2.dts
>> index 43cbdbe43afd..9cfe648e29bb 100644
>> --- a/arch/arm64/boot/dts/qcom/qcs6490-rb3gen2.dts
>> +++ b/arch/arm64/boot/dts/qcom/qcs6490-rb3gen2.dts
>> @@ -1078,6 +1078,55 @@
>>   	status = "okay";
>>   };
>>   
>> +&sound {
>> +	compatible = "qcom,qcs6490-rb3gen2-sndcard";
>> +	model = "qcs6490-rb3gen2-snd-card";
>> +
>> +	audio-routing =
>> +		"SpkrLeft IN", "WSA_SPK1 OUT",
> 
> Please unbreak the line and align the entries
> 
> [...]
Ack>
>> +		"SpkrRight IN", "WSA_SPK2 OUT",
>> +		"VA DMIC0", "vdd-micb",
>> +		"VA DMIC1", "vdd-micb",
>> +		"VA DMIC2", "vdd-micb",
>> +		"VA DMIC3", "vdd-micb";
>> +
>> +		#address-cells = <1>;
>> +		#size-cells = <0>;
>> +
>> +	wsa-dai-link {
>> +		link-name = "WSA Playback";
>> +
>> +		codec {
>> +			sound-dai = <&left_spkr>, <&right_spkr>, <&swr2 0>,
>> +					<&lpass_wsa_macro 0>;
> 
> Please align the <s
Ack>
> Konrad